Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On April 1, 2016, 9:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 380-390 > > > > > > It's also possible that `_cleanup` remove the interface directory and > > then

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126477 --- Fix it, then Ship it! Qian, I will submit a subsequent patch to

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 29, 2016, 5:35 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 151 > > > > > > Should have pointed in the earlier patches, why do we need `Info` to be

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 30, 2016, 6:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > I think this is not needed because if recover fails, slave will restart. > > Qian Z

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 31, 2016, 7:33 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 31, 2016, 1:05 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 221-223 > > > > > > Can you separate out this patch? Sure, I have done it in the patch: https://re

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 31, 2016, 2:12 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > I think this is not needed because if recover fails, slave will restart. Agree, but

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126143 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126136 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review126104 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 30, 2016, 9:39 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 30, 2016, 5:12 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

> On March 30, 2016, 1:35 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 103 > > > > > > Why do we need to use a hashmap over here? Why not a vector or a list? >

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review125880 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/#review125905 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Re: Review Request 45383: Implemented recover() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45383/ --- (Updated March 29, 2016, 7 p.m.) Review request for mesos, Avinash sridharan, G