Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-20 Thread Alexander Rukletsov
> On June 14, 2015, 10:46 a.m., Benjamin Hindman wrote: > > Just so I understand, does this mean if we happen to get in the unfortunate > > situation where a slave has neglected to get the dynamic reservation > > because it was just starting up and then it gets the task launch it will > > shut

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Michael Park
> On June 19, 2015, 10:57 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 1579-1583 > > > > > > This should be a CHECK instead? I've created [r35686](https://reviews.apache.org/r/35686/) as a follow-up for this.

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88595 --- src/slave/slave.cpp (lines 1579 - 1583)

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Ben Mahler
> On June 14, 2015, 10:46 a.m., Benjamin Hindman wrote: > > Just so I understand, does this mean if we happen to get in the unfortunate > > situation where a slave has neglected to get the dynamic reservation > > because it was just starting up and then it gets the task launch it will > > shut

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88568 --- Ship it! Ship It! - Benjamin Hindman On June 19, 2015, 2:31 p.m.

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88541 --- Ship it! Ship It! - Alexander Rukletsov On June 19, 2015, 2:31 p

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 19, 2015, 2:31 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 19, 2015, 12:29 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88513 --- Ship it! Want to link the RR with MESOS-2491 for posterity? src/s

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Alexander Rukletsov
> On June 14, 2015, 10:46 a.m., Benjamin Hindman wrote: > > Just so I understand, does this mean if we happen to get in the unfortunate > > situation where a slave has neglected to get the dynamic reservation > > because it was just starting up and then it gets the task launch it will > > shut

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
> On June 18, 2015, 5:27 p.m., Jie Yu wrote: > > src/slave/slave.cpp, line 1409 > > > > > > Have we decided to not capture temp variable by const ref? Maybe you > > want to do a sweep to fix that in this file? I fix

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- (Updated June 19, 2015, 12:42 a.m.) Review request for mesos, Alexander Ruklets