Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review108455 --- Patch looks great! Reviews applied: [40497, 40506, 39415, 39416, 3

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Dec. 1, 2015, 12:18 a.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 30, 2015, 9:58 p.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review108376 --- Ship it! Ship It! - Jie Yu On Nov. 23, 2015, 10:33 p.m., Cong W

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107690 --- Patch looks great! Reviews applied: [40497, 40506, 39415, 39416, 3

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 23, 2015, 10:33 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107485 --- Bad patch! Reviews applied: [40497, 40506, 39415, 39416, 39417] F

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107443 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 20, 2015, 10:27 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107322 --- Bad patch! Reviews applied: [39415, 39416, 40497, 40506, 39417] F

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 19, 2015, 10:59 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107247 --- Bad patch! Reviews applied: [40497] Failed command: ./support/app

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Nov. 19, 2015, 8:15 p.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405 > > > > > > Why not add a 0x prefix if it's not present so you can use numify? > >

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 26, 2015, 5:20 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405 > > > > > > Why not add a 0x prefix if it's not present so you can use numify? > > >

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review104383 --- Patch looks great! Reviews applied: [39415, 39416, 39417] All tes

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- (Updated Oct. 29, 2015, 12:12 a.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote: > > docs/configuration.md, lines 1545-1551 > > > > > > Can we not infer where to put the classifier from any exisiting > > classifiers and only require the user to

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 27, 2015, 12:21 a.m., Ian Downes wrote: > > Also, is there are way to test the different code paths? I tested it manually: with and without this flag; with and without a pre-installed HTB qdisc and class. - Cong --- This is a

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1423-1424 > > > > > > Can we verify this somehow? What's the failure mode? Yeah, I can test it

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

> On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405 > > > > > > Why not add a 0x prefix if it's not present so you can use numify? > >

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review104120 --- Also, is there are way to test the different code paths? - Ian Dow

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review104119 --- docs/configuration.md (lines 1545 - 1551)

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review103048 --- Patch looks great! Reviews applied: [39415, 39416, 39417] All tes

Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos Descriptio