Re: Review Request 41590: Modulize the containerizer interface.

2016-01-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/ --- (Updated Jan. 10, 2016, 6:41 p.m.) Review request for mesos, Ben Mahler, Till T

Re: Review Request 41590: Modulize the containerizer interface.

2016-01-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/#review113662 --- src/slave/containerizer/containerizer.hpp (line 46)

Re: Review Request 41590: Modulize the containerizer interface.

2016-01-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/ --- (Updated Jan. 11, 2016, 5:52 p.m.) Review request for mesos, Ben Mahler, Till T

Re: Review Request 41590: Modulize the containerizer interface.

2016-01-11 Thread haosdent huang
> On Jan. 10, 2016, 7:59 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/containerizer.hpp, line 49 > > > > > > Just having a brief look, but one of the big issues with modularizing > > the containerizer ap

Re: Review Request 41590: Modulize the containerizer interface.

2016-01-11 Thread Benjamin Bannier
> On Jan. 10, 2016, 8:59 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/containerizer.hpp, line 49 > > > > > > Just having a brief look, but one of the big issues with modularizing > > the containerizer ap

Re: Review Request 41590: Modulize the containerizer interface.

2016-01-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/#review116051 --- @haosdent, it is really a big patch, can you please highlight some

Re: Review Request 41590: Modulize the containerizer interface.

2016-01-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41590/#review113693 --- Bad patch! Reviews applied: [41590] Failed command: ./support/ap