Re: Review Request 42516: Add support for user-defined networks.

2016-01-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115329 --- Patch looks great! Reviews applied: [42516] Passed command: expor

Re: Review Request 42516: Add support for user-defined networks.

2016-01-19 Thread Guangya Liu
> On 一月 19, 2016, 11:29 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 1469 > > > > > > What about name it as OVERLAY? > > Ezra Silvera wrote: > We choose USER because it is defined by Docker as "

Re: Review Request 42516: Add support for user-defined networks.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115372 --- include/mesos/mesos.proto (line 1499)

Re: Review Request 42516: Add support for user-defined networks.

2016-01-19 Thread Ezra Silvera
> On Jan. 19, 2016, 11:29 p.m., Guangya Liu wrote: > > A unit test also needed, please refer to > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297 > > for detail Thanks. I'll have a look. We will probably need to add support for "create

Re: Review Request 42516: Add support for user-defined networks.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115278 --- A unit test also needed, please refer to https://github.com/apache

Review Request 42516: Add support for user-defined networks.

2016-01-19 Thread Ezra Silvera
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- Review request for mesos and TimothyIL TimothyIL. Bugs: MESOS-4369 https://

<    1   2