Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Yongqiao Wang
> On March 8, 2016, 9:19 a.m., Adam B wrote: > > docs/weights.md, lines 22-23 > > > > > > This will have to be updated when we add GET I will update this doc for GET request after addressing #MESOS-4316. -

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122507 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated March 8, 2016, 11:27 a.m.) Review request for mesos and Adam B.

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122488 --- Fix it, then Ship it! docs/weights.md (lines 51 - 53)

Re: Review Request 42719: Add doc for weights.

2016-03-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122298 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 42719: Add doc for weights.

2016-03-07 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated March 7, 2016, 11:35 a.m.) Review request for mesos and Adam B.

Re: Review Request 42719: Add doc for weights.

2016-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review121426 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 42719: Add doc for weights.

2016-02-29 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated March 1, 2016, 7:53 a.m.) Review request for mesos and Adam B.

Re: Review Request 42719: Add doc for weights.

2016-02-29 Thread Yongqiao Wang
> On Feb. 28, 2016, 8:21 a.m., Adam B wrote: > > Thanks! Couple of tweaks as I review it again. > > - How did you test that this renders correctly? Did you try > > `support/site-docker` to see if the markdown translates properly to html? > > Just because it looks good in github doesn't mean

Re: Review Request 42719: Add doc for weights.

2016-02-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review121129 --- Thanks! Couple of tweaks as I review it again. - How did you test

Re: Review Request 42719: Add doc for weights.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review119871 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 42719: Add doc for weights.

2016-02-18 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated Feb. 19, 2016, 7:56 a.m.) Review request for mesos and Adam B.

Re: Review Request 42719: Add doc for weights.

2016-02-18 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review119829 --- Fix it, then Ship it! Thanks! (Sorry for the delay)

Re: Review Request 42719: Add doc for weights.

2016-02-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated Feb. 14, 2016, 12:47 p.m.) Review request for mesos and Adam B.

Re: Review Request 42719: Add doc for weights.

2016-02-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review119184 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 42719: Add doc for weights.

2016-02-14 Thread Yongqiao Wang
> On Feb. 10, 2016, 9:03 a.m., Adam B wrote: > > Looks good, but I think we can pull this information into the roles.md and > > endpoint help docs, rather than create a new docs page. Maybe weight will also be supported for framework in the future, so I think it is better to create a new doc

Re: Review Request 42719: Add doc for weights.

2016-02-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review118617 --- Looks good, but I think we can pull this information into the

Review Request 42719: Add doc for weights.

2016-01-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- Review request for mesos and Adam B. Bugs: MESOS-3945

Re: Review Request 42719: Add doc for weights.

2016-01-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review116114 --- Patch looks great! Reviews applied: [42719] Passed command: