Re: Review Request 44084: Windows: Forked os::rename().

2016-04-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review127930 --- Ship it! Ship It! - Michael Park On April 7, 2016, 10:15 a.m

Re: Review Request 44084: Windows: Forked os::rename().

2016-04-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- (Updated April 7, 2016, 10:15 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44084: Windows: Forked os::rename().

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review127502 --- 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-25 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review125451 --- Ship it! Ship It! - Yi Sun On March 24, 2016, 2:59 p.m., Ale

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-24 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- (Updated March 24, 2016, 2:59 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-21 Thread Michael Park
> On March 21, 2016, 7:24 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 222 > > > > > > ``` > > ASSERT_EQ(message, file3Contents.get()); > > ``` Actuall

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-21 Thread Michael Park
> On March 21, 2016, 7:24 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 234 > > > > > > ``` > > ASSERT_TRUE(0u, file2Contents.get()); > > ``` oops. `s/A

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review124623 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/renam

Review Request 44084: Windows: Forked os::rename().

2016-03-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V