Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

2016-03-01 Thread Yi Sun
> On March 1, 2016, 11:47 p.m., Yi Sun wrote: > > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152 > > > > > > The second param for strcpy_s is the number of chars to be copied. It > > doesn't seem right her

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

2016-03-01 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121543 --- Ship it! Ship It! - Yi Sun On March 1, 2016, 8:58 p.m., Dani

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

2016-03-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/#review121540 --- Bad patch! Reviews applied: [44141, 44140] Failed command: ./sup

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

2016-03-01 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/ --- (Updated March 1, 2016, 8:58 p.m.) Review request for mesos, Alex Naparu, Danie