Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.

2016-07-04 Thread Jie Yu
> On July 2, 2016, 5:11 p.m., Joris Van Remoortere wrote: > > 3rdparty/stout/include/stout/os/raw/argv.hpp, line 40 > > > > > > It seems like this extra vector and the subsequent copy into the argv > > array is only

Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.

2016-07-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49424/#review140451 --- 3rdparty/stout/include/stout/os/raw/argv.hpp (line 27)

Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49424/#review140456 --- Ship it! LGTM! - Gilbert Song On June 30, 2016, 9:18 a.m., J

Re: Review Request 49424: Added an abstraction os::raw::Argv in stout.

2016-06-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49424/ --- (Updated June 30, 2016, 4:18 p.m.) Review request for mesos and Joris Van Remoo

Review Request 49424: Added an abstraction os::raw::Argv in stout.

2016-06-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49424/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript