Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review219045 --- Ship it! Ship It! - Greg Mann On Dec. 16, 2019, 9:56 p.m.,

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ --- (Updated Dec. 16, 2019, 1:56 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review219032 --- 3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 45

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ --- (Updated Dec. 10, 2019, 3:52 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

> On Nov. 26, 2019, 11:38 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp > > Lines 212-215 (patched) > > > > > > Are we sure that there are no ill effects of immediately returning 1 > >

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

> On Nov. 26, 2019, 1:59 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp > > Lines 212-215 (patched) > > > > > > I wonder if openssl's internal calls to `BIO_flush()` will retry if the > >

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review218806 --- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 218-236

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review218804 --- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 212-215

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review218800 --- 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 115

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

> On Nov. 19, 2019, 5:28 a.m., Benno Evers wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp > > Lines 83 (patched) > > > > > > It seems like `synchronized()` for atomic flags is implemented as a > > busy

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ --- (Updated Nov. 19, 2019, 12:16 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review218661 --- Fix it, then Ship it!

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review218608 --- Notes from an offline review session:

Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ --- (Updated Oct. 30, 2019, 6:29 p.m.) Review request for mesos, Benno Evers,

Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/ --- Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till