[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137354051 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137353992 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10395] [SQL] Simplifies CatalystReadSup...

2015-09-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8553#discussion_r38617544 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/CatalystReadSupport.scala --- @@ -32,31 +32,56 @@ import org.apache.sp

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137352784 Looks good, thanks for fixing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8581#discussion_r38617290 --- Diff: core/src/main/scala/org/apache/spark/scheduler/AccumulableInfo.scala --- @@ -34,9 +34,15 @@ class AccumulableInfo private[spark] ( overrid

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137352727 [Test build #41961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41961/consoleFull) for PR 8581 at commit [`25c0f7b`](https://gith

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8581#discussion_r38617239 --- Diff: core/src/test/scala/org/apache/spark/rdd/RDDOperationScopeSuite.scala --- @@ -38,6 +38,13 @@ class RDDOperationScopeSuite extends SparkFunSuite w

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137352426 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137352433 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10430][Spark Core]Added hashCode method...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137352088 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-137350715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-137350711 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-137350369 [Test build #41958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41958/console) for PR 8383 at commit [`62cc7e3`](https://github.

[GitHub] spark pull request: SPARK-10314 [CORE]RDD persist to OFF_HEAP tach...

2015-09-02 Thread romansew
Github user romansew closed the pull request at: https://github.com/apache/spark/pull/8482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: SPARK-10314 [CORE]RDD persist to OFF_HEAP tach...

2015-09-02 Thread romansew
Github user romansew commented on the pull request: https://github.com/apache/spark/pull/8482#issuecomment-137344930 I open the other one:https://github.com/apache/spark/pull/8562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-10430][SPARK-10430]Added hashCode metho...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8581#issuecomment-137335470 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-10430][SPARK-10430]Added hashCode metho...

2015-09-02 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/8581 [SPARK-10430][SPARK-10430]Added hashCode methods in AccumulableInfo and RDDOperationScope You can merge this pull request into a Git repository by running: $ git pull https://github.com/vinod

[GitHub] spark pull request: [SPARK-4229] Create hadoop configuration in a ...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3543#issuecomment-137335223 OK, makes sense. Can you close this PR for now then? If there's interest we can always reopen it against the latest master. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-10411][SQL]Move visualization above exp...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10411][SQL]Move visualization above exp...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8570#issuecomment-137334438 LGTM merging into master 1.5 thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-10379] preserve first page in UnsafeShu...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10247] [core] improve readability of a ...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10379] preserve first page in UnsafeShu...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8543#issuecomment-137334210 Merged into master, thanks @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-10247] [core] improve readability of a ...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8434#issuecomment-137333753 Merged into master, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9591][CORE]Job may fail for exception d...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7927#issuecomment-137333723 [Test build #41960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41960/consoleFull) for PR 7927 at commit [`6c6d53d`](https://gith

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8514#discussion_r38613656 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -315,6 +309,14 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request: [SPARK-8707] RDD#toDebugString fails if any ca...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: Removed code duplication in ShuffleBlockFetche...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8514#issuecomment-137333652 Merged into master, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8707] RDD#toDebugString fails if any ca...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7127#issuecomment-13790 I've merged this into master after applying the change myself --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9591][CORE]Job may fail for exception d...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7927#issuecomment-137333165 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9591][CORE]Job may fail for exception d...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7927#issuecomment-137333173 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5636#issuecomment-137333035 Alright, merging into master. I fixed the test name on merge. Thanks everyone. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-9591][CORE]Job may fail for exception d...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7927#issuecomment-137332857 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9672][MESOS] Don’t include SPARK_ENV_...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7979#issuecomment-137332182 [Test build #41959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41959/consoleFull) for PR 7979 at commit [`28a34b8`](https://gith

[GitHub] spark pull request: SPARK-10314 [CORE]RDD persist to OFF_HEAP tach...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8482#issuecomment-137332208 Can you close this now that you've opened another one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-9672][MESOS] Don’t include SPARK_ENV_...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7979#issuecomment-137331644 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9672][MESOS] Don’t include SPARK_ENV_...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7979#issuecomment-137331611 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9672][MESOS] Don’t include SPARK_ENV_...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7979#discussion_r38612921 --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala --- @@ -413,6 +412,15 @@ private[spark] object RestSubmissionClient {

[GitHub] spark pull request: [SPARK-9672][MESOS] Don’t include SPARK_ENV_...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/7979#discussion_r38612889 --- Diff: core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala --- @@ -413,6 +412,15 @@ private[spark] object RestSubmissionClient {

[GitHub] spark pull request: [SPARK-9672][MESOS] Don’t include SPARK_ENV_...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7979#issuecomment-137331334 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5636#discussion_r38612752 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -473,6 +473,282 @@ class DAGSchedulerSuite assertDataStruc

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5636#discussion_r38612691 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -473,6 +473,282 @@ class DAGSchedulerSuite assertDataStruc

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38612598 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -101,6 +134,32 @@ private[spark] abstract class YarnSch

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38612546 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -91,6 +94,36 @@ private[spark] abstract class YarnSched

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-137328959 [Test build #41958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41958/consoleFull) for PR 8383 at commit [`62cc7e3`](https://gith

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-137328168 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-137328114 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-09-02 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-137327156 @davies Thanks for comment and continuing this patch. I still added new commits to fix the problems you mentioned. But free feel to merge #8579 when it is ready. I will c

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8567#issuecomment-137327087 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-137326904 @mccheah Overall this looks pretty good. I think throughout the patch there are still quite a few places where the change is not intended / no longer necessary. Other

[GitHub] spark pull request: [SPARK-9723][ML] params getordefault should th...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10422] [SQL] String column in InMemoryC...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10422] [SQL] String column in InMemoryC...

2015-09-02 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8578#issuecomment-137323772 LGTM, merging this into master 1.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-10419] [SQL] Adding SQLServer support f...

2015-09-02 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/8575#discussion_r38611491 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala --- @@ -240,3 +242,21 @@ case object DB2Dialect extends JdbcDialect {

[GitHub] spark pull request: [SPARK-10422] [SQL] String column in InMemoryC...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8578#issuecomment-137323307 [Test build #1716 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1716/console) for PR 8578 at commit [`2905fd5`](https://github

[GitHub] spark pull request: [SPARK-10332][CORE] Fix yarn spark executor va...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8580#issuecomment-137323237 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10332][CORE] Fix yarn spark executor va...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8580#issuecomment-137323239 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10332][CORE] Fix yarn spark executor va...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8580#issuecomment-137323181 [Test build #41953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41953/console) for PR 8580 at commit [`f7e5b00`](https://github.

[GitHub] spark pull request: [SPARK-9925] [SQL] [TESTS] Set SQLConf.SHUFFLE...

2015-09-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8155#issuecomment-137322854 Will do it tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-10411][SQL]Move visualization above exp...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8570#issuecomment-137322164 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10411][SQL]Move visualization above exp...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8570#issuecomment-137322163 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10411][SQL]Move visualization above exp...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8570#issuecomment-137322099 [Test build #41957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41957/console) for PR 8570 at commit [`9978206`](https://github.

[GitHub] spark pull request: [SPARK-10199][SPARK-10200][SPARK-10201][SPARK-...

2015-09-02 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/spark/pull/8507#issuecomment-137312813 @feynmanliang , fixed your review comments. Could you please verify it? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark pull request: [SPARK-10422] [SQL] String column in InMemoryC...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8578#issuecomment-137311709 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10422] [SQL] String column in InMemoryC...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8578#issuecomment-137311710 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-10422] [SQL] String column in InMemoryC...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8578#issuecomment-137311641 [Test build #41952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41952/console) for PR 8578 at commit [`2905fd5`](https://github.

[GitHub] spark pull request: [SPARK-9066][SQL] Improve cartesian performanc...

2015-09-02 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7417#issuecomment-137310991 @Sephiroth-Lin there are two changes in your patch: using `BroadcastNestedLoopJoin` for the small table, and putting the small table in the left side of `RDD.cartesian`.

[GitHub] spark pull request: [SPARK-10414][MLlib]Fix hashcode issues in MLL...

2015-09-02 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/8565#discussion_r38609166 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -278,7 +278,8 @@ class DenseMatrix @Since("1.3.0") ( }

[GitHub] spark pull request: [SPARK-9066][SQL] Improve cartesian performanc...

2015-09-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/7417#discussion_r38608917 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala --- @@ -27,16 +27,27 @@ import org.apache.spark.sql.execution.{

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5636#issuecomment-137307153 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5636#issuecomment-137307149 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5945] Spark should not retry a stage in...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5636#issuecomment-137306559 [Test build #41951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41951/console) for PR 5636 at commit [`5bb1ae6`](https://github.

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38608268 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -474,18 +509,26 @@ private[yarn] class YarnAllocator(

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38608264 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -474,18 +509,26 @@ private[yarn] class YarnAllocator( c

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38608220 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -236,10 +246,14 @@ private[yarn] class YarnAllocator( if (co

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38608209 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -211,8 +218,11 @@ private[yarn] class YarnAllocator( * Deal w

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38608149 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -474,18 +509,26 @@ private[yarn] class YarnAllocator(

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38608061 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -474,18 +509,26 @@ private[yarn] class YarnAllocator(

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38608057 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -474,18 +509,26 @@ private[yarn] class YarnAllocator(

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607895 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -440,22 +454,43 @@ private[yarn] class YarnAllocator( //

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607757 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -91,6 +94,36 @@ private[spark] abstract class YarnSchedule

[GitHub] spark pull request: [SPARK-10332][CORE] Fix yarn spark executor va...

2015-09-02 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8580#issuecomment-137302069 I'll merge tomorrow morning unless someone chimes in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607674 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -440,22 +454,43 @@ private[yarn] class YarnAllocator( //

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607588 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -440,22 +454,43 @@ private[yarn] class YarnAllocator( //

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607562 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -101,6 +134,32 @@ private[spark] abstract class YarnSchedu

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607365 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -440,22 +454,43 @@ private[yarn] class YarnAllocator( //

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607396 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -440,22 +454,43 @@ private[yarn] class YarnAllocator( //

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607225 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -17,6 +17,7 @@ package org.apache.spark.deploy.yarn

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607194 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -67,6 +68,11 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38607202 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -64,7 +66,7 @@ private[yarn] class YarnAllocator( securityMg

[GitHub] spark pull request: [SPARK-10332][CORE] Fix yarn spark executor va...

2015-09-02 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8580#issuecomment-137300659 Do you want to merge it since I don't have commit bits then? (or wait for srowen to take a look too?) --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10422] [SQL] String column in InMemoryC...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8578#issuecomment-137300609 [Test build #1716 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1716/consoleFull) for PR 8578 at commit [`2905fd5`](https://git

[GitHub] spark pull request: [SPARK-10332][CORE] Fix yarn spark executor va...

2015-09-02 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/8580#issuecomment-137300560 Makes sense --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-10332][CORE] Fix yarn spark executor va...

2015-09-02 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8580#issuecomment-137299432 I wouldn't hold the release for it, but we can definitely push it to branch-1.5. Worst case, it makes it to 1.5.1. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38606027 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -101,6 +134,32 @@ private[spark] abstract class YarnSch

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8007#discussion_r38605954 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -91,6 +94,36 @@ private[spark] abstract class YarnSched

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-137297486 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-09-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-137297480 [Test build #41956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41956/console) for PR 8007 at commit [`e967fa4`](https://github.

  1   2   3   4   5   6   7   >