[GitHub] spark pull request #22063: [WIP][SPARK-25044][SQL] Address translation of LM...

2018-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22063#discussion_r212346762 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -85,9 +85,8 @@ private[recommendation] trait ALSModelParams extends Pa

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-08-23 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 I've rebased onto master 👍 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22063: [WIP][SPARK-25044][SQL] Address translation of LM...

2018-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22063#discussion_r212345138 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala --- @@ -164,19 +164,15 @@ abstract class ClassificationModel[FeaturesTy

[GitHub] spark pull request #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for ...

2018-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22200 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22104: [SPARK-24721][SQL] Exclude Python UDFs filters in...

2018-08-23 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/22104#discussion_r212340459 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvalPythonExec.scala --- @@ -117,15 +117,18 @@ abstract class EvalPythonExec(udf

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22200 LGTM, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #22204: [SPARK-25196][SQL] Analyze column statistics in cached q...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22204 **[Test build #95160 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95160/testReport)** for PR 22204 at commit [`fcc5300`](https://github.com/apache/spark/commit/fc

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22200 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22200 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95150/ Test PASSed. ---

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22200 **[Test build #95150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95150/testReport)** for PR 22200 at commit [`e134258`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #22204: [SPARK-25196][SQL] Analyze column statistics in cached q...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22204 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2489/

[GitHub] spark issue #22204: [SPARK-25196][SQL] Analyze column statistics in cached q...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22204 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22204: [SPARK-25196][SQL] Analyze column statistics in c...

2018-08-23 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/22204 [SPARK-25196][SQL] Analyze column statistics in cached query ## What changes were proposed in this pull request? This pr proposed a new API to analyze column statistics in cached query. In commo

[GitHub] spark issue #22197: [SPARK-25207][SQL] Case-insensitve field resolution for ...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22197 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95149/ Test PASSed. ---

[GitHub] spark issue #22197: [SPARK-25207][SQL] Case-insensitve field resolution for ...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22197 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22112: [SPARK-23243][Core] Fix RDD.repartition() data co...

2018-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22112#discussion_r212332473 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1865,6 +1876,39 @@ abstract class RDD[T: ClassTag]( // RDD chain. @trans

[GitHub] spark issue #22197: [SPARK-25207][SQL] Case-insensitve field resolution for ...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22197 **[Test build #95149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95149/testReport)** for PR 22197 at commit [`2226eae`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #22112: [SPARK-23243][Core] Fix RDD.repartition() data co...

2018-08-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22112#discussion_r212332064 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -855,16 +858,17 @@ abstract class RDD[T: ClassTag]( * a map on the other).

[GitHub] spark pull request #22112: [SPARK-23243][Core] Fix RDD.repartition() data co...

2018-08-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22112#discussion_r212330529 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -855,16 +858,17 @@ abstract class RDD[T: ClassTag]( * a map on the other).

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22203 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2488/

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22203 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22203 **[Test build #95159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95159/testReport)** for PR 22203 at commit [`848bf1c`](https://github.com/apache/spark/commit/84

[GitHub] spark pull request #22157: [SPARK-25126][SQL] Avoid creating Reader for all ...

2018-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22157 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22203 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22203 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95158/ Test FAILed. ---

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22203 **[Test build #95158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95158/testReport)** for PR 22203 at commit [`b7c7bdb`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #22157: [SPARK-25126][SQL] Avoid creating Reader for all orc fil...

2018-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22157 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22203 **[Test build #95158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95158/testReport)** for PR 22203 at commit [`b7c7bdb`](https://github.com/apache/spark/commit/b7

[GitHub] spark issue #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstract meth...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22203 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2487/

[GitHub] spark pull request #22203: [SPARK-25029][BUILD][CORE] Janino "Two non-abstra...

2018-08-23 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22203 [SPARK-25029][BUILD][CORE] Janino "Two non-abstract methods ..." errors ## What changes were proposed in this pull request? Update to janino 3.0.9 to address Java 8 + Scala 2.12 incompatibil

[GitHub] spark issue #22202: [SPARK-25211][Core] speculation and fetch failed result ...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22202 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22202: [SPARK-25211][Core] speculation and fetch failed result ...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22202 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22202: [SPARK-25211][Core] speculation and fetch failed result ...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22202 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22202: [SPARK-25211][Core] speculation and fetch failed ...

2018-08-23 Thread liutang123
GitHub user liutang123 opened a pull request: https://github.com/apache/spark/pull/22202 [SPARK-25211][Core] speculation and fetch failed result in hang of job ## What changes were proposed in this pull request? In current `DAGScheduler.handleTaskCompletion` code, when a shu

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95148/ Test PASSed. ---

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22198 **[Test build #95148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95148/testReport)** for PR 22198 at commit [`d2be692`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #22104: [SPARK-24721][SQL] Exclude Python UDFs filters in...

2018-08-23 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/22104#discussion_r212309541 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvalPythonExec.scala --- @@ -117,15 +117,18 @@ abstract class EvalPythonExec(udf

[GitHub] spark pull request #22112: [SPARK-23243][Core] Fix RDD.repartition() data co...

2018-08-23 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22112#discussion_r212305067 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -855,16 +858,17 @@ abstract class RDD[T: ClassTag]( * a map on the other).

[GitHub] spark pull request #22157: [SPARK-25126][SQL] Avoid creating Reader for all ...

2018-08-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22157#discussion_r212304433 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -562,20 +562,57 @@ abstract class OrcQueryTest e

[GitHub] spark pull request #22157: [SPARK-25126][SQL] Avoid creating Reader for all ...

2018-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22157#discussion_r212302555 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -562,20 +562,57 @@ abstract class OrcQueryTest e

[GitHub] spark pull request #22199: [SPARK-25073][Yarn] AM and Executor Memory valida...

2018-08-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22199#discussion_r212301867 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -338,13 +338,14 @@ private[spark] class Client(

[GitHub] spark issue #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggregate.row....

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21931 **[Test build #95157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95157/testReport)** for PR 21931 at commit [`af2078c`](https://github.com/apache/spark/commit/af

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22171 **[Test build #95156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95156/testReport)** for PR 22171 at commit [`d1ef674`](https://github.com/apache/spark/commit/d1

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2486/

[GitHub] spark pull request #22171: [SPARK-25177][SQL] When dataframe decimal type co...

2018-08-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22171#discussion_r212289525 --- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out --- @@ -197,7 +197,7 @@ select .e3 -- !query 20 select 1E309, -1E309 -

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21860 **[Test build #95155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95155/testReport)** for PR 21860 at commit [`32dbc67`](https://github.com/apache/spark/commit/32

[GitHub] spark issue #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggregate.row....

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21931 **[Test build #95154 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95154/testReport)** for PR 21931 at commit [`03c0a80`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggregate.row....

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21931 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggregate.row....

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21931 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95154/ Test FAILed. ---

[GitHub] spark issue #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggregate.row....

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21931 **[Test build #95154 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95154/testReport)** for PR 21931 at commit [`03c0a80`](https://github.com/apache/spark/commit/03

[GitHub] spark issue #22201: [SPARK-25209][SQL] Avoid deserializer check in Dataset.a...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22201 **[Test build #95153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95153/testReport)** for PR 22201 at commit [`7089e03`](https://github.com/apache/spark/commit/70

[GitHub] spark issue #22201: [SPARK-25209][SQL] Avoid deserializer check in Dataset.a...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22201 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22201: [SPARK-25209][SQL] Avoid deserializer check in Dataset.a...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2485/

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21546 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21546 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95145/ Test PASSed. ---

[GitHub] spark issue #22201: [SPARK-25209][SQL] Avoid deserializer check in Dataset.a...

2018-08-23 Thread bogdanrdc
Github user bogdanrdc commented on the issue: https://github.com/apache/spark/pull/22201 cc @gatorsmile @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22201: [SPARK-25209][SQL] Avoid deserializer check in Da...

2018-08-23 Thread bogdanrdc
GitHub user bogdanrdc opened a pull request: https://github.com/apache/spark/pull/22201 [SPARK-25209][SQL] Avoid deserializer check in Dataset.apply when Dataset is actually DataFrame ## What changes were proposed in this pull request? Dataset.apply calls dataset.deserializer (t

[GitHub] spark issue #21546: [SPARK-23030][SQL][PYTHON] Use Arrow stream format for c...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21546 **[Test build #95145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95145/testReport)** for PR 21546 at commit [`5549644`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggrega...

2018-08-23 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21931#discussion_r212284374 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1444,6 +1444,31 @@ object SQLConf { .intConf .

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-08-23 Thread viktorklang
Github user viktorklang commented on the issue: https://github.com/apache/spark/pull/21342 Scala 2.13.0-M5 and forward has improved handling of InterruptedExceptions and fatal errors should be propagated, I'd welcome feedback on the new logic when possible. Thank you! https:/

[GitHub] spark pull request #21931: [SPARK-24978][SQL]Add spark.sql.fast.hash.aggrega...

2018-08-23 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21931#discussion_r212282015 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1444,6 +1444,31 @@ object SQLConf { .intConf .

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21860 **[Test build #95152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95152/testReport)** for PR 21860 at commit [`da25e97`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21860 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95152/ Test FAILed. ---

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21860 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21860 **[Test build #95152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95152/testReport)** for PR 21860 at commit [`da25e97`](https://github.com/apache/spark/commit/da

[GitHub] spark issue #22195: [SPARK-25205][CORE] Fix typo in spark.network.crypto.key...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22195 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95143/ Test PASSed. ---

[GitHub] spark issue #22195: [SPARK-25205][CORE] Fix typo in spark.network.crypto.key...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22195 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22195: [SPARK-25205][CORE] Fix typo in spark.network.crypto.key...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22195 **[Test build #95143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95143/testReport)** for PR 22195 at commit [`b927b94`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #19691: [SPARK-14922][SPARK-17732][SQL]ALTER TABLE DROP PARTITIO...

2018-08-23 Thread DazhuangSu
Github user DazhuangSu commented on the issue: https://github.com/apache/spark/pull/19691 @maropu ok --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark issue #22187: [SPARK-25178][SQL] Directly ship the StructType objects ...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22187 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22187: [SPARK-25178][SQL] Directly ship the StructType objects ...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22187 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95146/ Test PASSed. ---

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95151/ Test FAILed. ---

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22187: [SPARK-25178][SQL] Directly ship the StructType objects ...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22187 **[Test build #95146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95146/testReport)** for PR 22187 at commit [`81ef75a`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22171 **[Test build #95151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95151/testReport)** for PR 22171 at commit [`b5644d7`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22171 **[Test build #95151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95151/testReport)** for PR 22171 at commit [`b5644d7`](https://github.com/apache/spark/commit/b5

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2484/

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22149: [SPARK-25158][SQL]Executor accidentally exit because Scr...

2018-08-23 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/22149 Gental ping @gatorsmile. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #17745: [SPARK-17159][Streaming] optimise check for new f...

2018-08-23 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/17745#discussion_r212267619 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -196,29 +191,29 @@ class FileInputDStream[K, V, F <:

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22200 **[Test build #95150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95150/testReport)** for PR 22200 at commit [`e134258`](https://github.com/apache/spark/commit/e1

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22200 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22200 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2483/

[GitHub] spark issue #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for Decimal...

2018-08-23 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22200 cc @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark pull request #22200: [SPARK-25208][SQL] Loosen Cast.forceNullable for ...

2018-08-23 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/22200 [SPARK-25208][SQL] Loosen Cast.forceNullable for DecimalType. ## What changes were proposed in this pull request? Casting to `DecimalType` is not always needed to force nullable. If the

[GitHub] spark issue #22199: [SPARK-25073][SQL]When wild card is been used in load co...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22199 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22199: [SPARK-25073][SQL]When wild card is been used in load co...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22199 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22199: [SPARK-25073][SQL]When wild card is been used in load co...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22199 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22199: [SPARK-25073][SQL]When wild card is been used in ...

2018-08-23 Thread sujith71955
GitHub user sujith71955 opened a pull request: https://github.com/apache/spark/pull/22199 [SPARK-25073][SQL]When wild card is been used in load command system ## What changes were proposed in this pull request? When the yarn.nodemanager.resource.memory-mb or yarn.scheduler.maxi

[GitHub] spark issue #22197: [SPARK-25207][SQL] Case-insensitve field resolution for ...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22197 **[Test build #95149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95149/testReport)** for PR 22197 at commit [`2226eae`](https://github.com/apache/spark/commit/22

[GitHub] spark issue #17190: [SPARK-19478][SS] JDBC Sink

2018-08-23 Thread mshtelma
Github user mshtelma commented on the issue: https://github.com/apache/spark/pull/17190 @GaalDornick Have you thought about publishing this code as external spark package ? If you do not mind, I can try doing this. --- -

[GitHub] spark pull request #22157: [SPARK-25126][SQL] Avoid creating Reader for all ...

2018-08-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22157#discussion_r212252932 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala --- @@ -562,20 +562,57 @@ abstract class OrcQueryT

[GitHub] spark pull request #22171: [SPARK-25177][SQL] When dataframe decimal type co...

2018-08-23 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/22171#discussion_r212251852 --- Diff: sql/core/src/test/resources/sql-tests/results/literals.sql.out --- @@ -197,7 +197,7 @@ select .e3 -- !query 20 select 1E309, -1E309

[GitHub] spark pull request #17745: [SPARK-17159][Streaming] optimise check for new f...

2018-08-23 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/17745#discussion_r212251757 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -196,29 +191,29 @@ class FileInputDStream[K, V, F <:

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22198 **[Test build #95148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95148/testReport)** for PR 22198 at commit [`d2be692`](https://github.com/apache/spark/commit/d2

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2482/

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21942: [SPARK-24283][ML] Make ml.StandardScaler skip conversion...

2018-08-23 Thread sujithjay
Github user sujithjay commented on the issue: https://github.com/apache/spark/pull/21942 Hi @mengxr, @jkbradley, @MLnick, @holdenk, @viirya , could you please review this PR ? --- - To unsubscribe, e-mail: reviews-u

<    1   2   3   4   5   6   >