[GitHub] [spark] MaxGekk commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-07-06 Thread GitBox
MaxGekk commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-873967342 > QQ: why do the special values support zone id? I tried PostgreSQL and this is not supported. @gengliangwang We follow PostgreSQL behavior strictly. Time zones are

[GitHub] [spark] MaxGekk commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-07-05 Thread GitBox
MaxGekk commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-873967342 > QQ: why do the special values support zone id? I tried PostgreSQL and this is not supported. @gengliangwang We follow PostgreSQL behavior strictly. Time zones are

[GitHub] [spark] MaxGekk commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-06-01 Thread GitBox
MaxGekk commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-852084312 GA passed. Merging to master. Thank you @yaooqinn and @cloud-fan for your reviews. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] MaxGekk commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-06-01 Thread GitBox
MaxGekk commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851925496 @cloud-fan @HyukjinKwon Are you ok with the changes in general? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] MaxGekk commented on pull request #32714: [SPARK-35581][SQL] Support special datetime values in typed literals only

2021-05-31 Thread GitBox
MaxGekk commented on pull request #32714: URL: https://github.com/apache/spark/pull/32714#issuecomment-851676205 @cloud-fan @HyukjinKwon FYI, I did't add new tests because special values in typed literals are tested in `date.sql`/`timestamp.sql`. -- This is an automated message from the