mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-508262366
@cloud-fan @gengliangwang @rdblue any further concerns or can this be merged?
---
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-500075726
Ok I addressed all the comments. Let me know if there's anything else to
address.
--
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-502325252
@rdblue addressed the last set of comments.
-
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-502916608
retest this please
This is an automated
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-505635599
Ok, I think I addressed everything.
This
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-511924956
@cloud-fan I'm hesitant to introduce an API-only change because it
introduces the API without any context
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-511925927
We can also break this out into a `REPLACE TABLE` and then a separate
`REPLACE TABLE AS SELECT` PR, but t
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-511938184
> I don't see too much worth in splitting them up now that we all have made
multiple
passes of review
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-513050318
Latest patch adds `stageCreateOrReplace` to the staging catalog API.
mccheah commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE
and REPLACE TABLE AS SELECT with V2
URL: https://github.com/apache/spark/pull/24798#issuecomment-513342871
Updated some docs and cleaned up implementations based on comments.
-
10 matches
Mail list logo