Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16596
@shivaram the change would need to be in spark-submit & spark-submit.cmd -
that's where JAVA is resolved (and if it's not there, to empty string)
---
If your project is set up for it, you can r
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16596
I think echoing an error message earlier than 1 minute would be useful.
What would be the files we'd need to change for that ?
---
If your project is set up for it, you can reply to this email and
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16596
@shivaram what do you think about
https://github.com/apache/spark/pull/16596#issuecomment-286015752?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16596
right, i think we could either leave it as-is, or
- check for java like this PR was trying to do originally; or
- check that it resolved to an empty string in spark-submit, and echo an
er
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16596
Ok. That sounds like a bigger change then. I guess we could leave this out
of branch-2.1 and do this for 2.2
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16596
so what I found earlier was that when java is not there spark-submit would
attempt to launch an empty string, which would not do anything.
the issue is that since we are doing fire-and-w
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/16596
@felixcheung Any update on this ? Looking through the list of PRs I thought
this might be a good one to add to a CRAN submission
---
If your project is set up for it, you can reply to this email a
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16596
I've found the root cause, from investigations, but need to test cross
platform for the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH