[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135657152 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135657175 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135654582 [Test build #1701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1701/console) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135657968 [Test build #41733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41733/consoleFull) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135658488 [Test build #41727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41727/console) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135658527 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135658526 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135711841 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135711152 [Test build #41733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41733/console) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135711833 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8492#discussion_r38219598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -145,46 +143,43 @@ case class

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135834146 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135834195 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135836177 [Test build #41751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41751/consoleFull) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8492#discussion_r38229685 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -382,15 +378,13 @@ class DataFrameFunctionsSuite extends QueryTest

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8492#discussion_r38229098 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -382,15 +378,13 @@ class DataFrameFunctionsSuite extends QueryTest

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8492#discussion_r38229646 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -145,46 +143,42 @@ case class

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135856198 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135856179 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135854641 +1 to follow postgres. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135858114 [Test build #41753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41753/consoleFull) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135894175 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135894603 Merged into master and 1.5 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135887380 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135887262 [Test build #41753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41753/console) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135887382 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8492#discussion_r38225619 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -145,46 +143,42 @@ case class

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/8492#discussion_r38227265 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala --- @@ -269,15 +269,5 @@ class ConstantFoldingSuite

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135871275 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135871119 [Test build #41751 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41751/console) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135871271 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135621549 postgresql's output regarding `in`... ``` yhuai=# select cast(null as char(10)) in ('1', cast(null as char(10))); ?column? --

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135636727 [Test build #41727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41727/consoleFull) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135636238 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135620750 Here is the output of some sample tests using hive 1.2.1 ``` hive select cast(null as string) in ('1', cast(null as string)); OK NULL Time taken: 0.042

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135635297 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135635306 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135623342 OK. I guess the main question at here is if we want to have a different semantic with hive on `array_contains` regarding `null`. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135636351 [Test build #1701 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1701/consoleFull) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135636231 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135640246 I'd follow postgres here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135637490 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135637488 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135634760 From PostgresSQL: ``` If the array expression yields a null array, the result of ANY will be null. If the left-hand expression yields null, the result of ANY is

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135589035 [Test build #41712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41712/consoleFull) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135591740 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135591715 [Test build #41712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41712/console) for PR 8492 at commit

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135591739 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135588372 cc @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/8492 [SPARK-10323] [SQL] fix nullability of In/InSet/ArrayContain After this PR, In/InSet/ArrayContain will return null if value is null, instead of false. They also will return null even if there is a

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135588705 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10323] [SQL] fix nullability of In/InSe...

2015-08-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8492#issuecomment-135588718 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not