[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174717824 @yhuai Sorry, I just checked this notification. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174671310 I have pushed https://github.com/apache/spark/commit/00026fa9912ecee5637f1e7dd222f977f31f6766 to fix the 2.11 build. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10895#discussion_r50738824 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -19,13 +19,12 @@ package org.apache.spark.sql.exe

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10895#discussion_r50709959 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala --- @@ -26,16 +26,30 @@ import org.apache.spark.sql.execu

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10895#discussion_r50709990 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -19,13 +19,12 @@ package org.apache.spark.sql.executi

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10895#discussion_r50709870 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala --- @@ -19,13 +19,12 @@ package org.apache.spark.sql.executi

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174547794 @HyukjinKwon If you get a chance, can you fit the scala compilation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10895 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174441100 Thanks - I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174418444 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174418440 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174418164 **[Test build #49977 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49977/consoleFull)** for PR 10895 at commit [`3770ffb`](https://g

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10895#issuecomment-174405059 **[Test build #49977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49977/consoleFull)** for PR 10895 at commit [`3770ffb`](https://gi

[GitHub] spark pull request: [SPARK-12901][SQL] Refactor options for JSON a...

2016-01-24 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/10895 [SPARK-12901][SQL] Refactor options for JSON and CSV datasource (not case class and same format). https://issues.apache.org/jira/browse/SPARK-12901 This PR refactors the options in JSON and