[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176443933 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176443931 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176443884 **[Test build #50297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50297/consoleFull)** for PR 10960 at commit [`1481bb4`](https://g

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176436538 **[Test build #50297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50297/consoleFull)** for PR 10960 at commit [`1481bb4`](https://gi

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176383091 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176383074 **[Test build #50294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50294/consoleFull)** for PR 10960 at commit [`ae83955`](https://g

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176383086 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176382224 **[Test build #50294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50294/consoleFull)** for PR 10960 at commit [`ae83955`](https://gi

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176315428 @davies Did you get a chance to test whole-stage codegen with higher-order statistics like skewness? If it works, the cleanest solution would be changing `CentralMomentA

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51160846 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -125,19 +125,15 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176068652 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176068656 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176068170 **[Test build #50265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50265/consoleFull)** for PR 10960 at commit [`3c8d737`](https://g

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-176043209 **[Test build #50265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50265/consoleFull)** for PR 10960 at commit [`3c8d737`](https://gi

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51086288 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -109,7 +109,7 @@ abstract class Centr

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-175915582 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-175915586 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-175914531 **[Test build #50240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50240/consoleFull)** for PR 10960 at commit [`61edd5e`](https://gi

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-175911728 cc @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-12963] Improve performance of stddev/va...

2016-01-27 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/10960 [SPARK-12963] Improve performance of stddev/variance As benchmarked and discussed here: https://github.com/apache/spark/pull/10786/files#r50038294, benefits from codegen, the declarative aggregate