GitHub user yinxusen opened a pull request:
https://github.com/apache/spark/pull/11266
[SPARK-13038][SPARK-13388][PySpark] Add load/save to pipeline and change it
to use the Scala implementation
## What changes were proposed in this pull request?
JIRA issues:
- htt
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186124333
**[Test build #51543 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51543/consoleFull)**
for PR 11266 at commit
[`b55bc60`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186169486
**[Test build #51543 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51543/consoleFull)**
for PR 11266 at commit
[`b55bc60`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186169618
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186169616
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186697584
retest it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186700385
**[Test build #51603 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51603/consoleFull)**
for PR 11266 at commit
[`4a85cc5`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186714888
**[Test build #51603 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51603/consoleFull)**
for PR 11266 at commit
[`4a85cc5`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186714933
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-186714935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-190935657
cc @yanboliang @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-191174641
@yinxusen I will make a pass soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-191680086
@yinxusen I notice that your change made ```Pipeline``` and
```PipelineModel``` as the wrapper of peer Java object. But I vote to keep the
exist behavior, ```Pipelin
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-192038248
Implementing Pipeline with its Scala companion helps keep consistency
between Scala and Python sides. The Pipeline in Scala side may evolve many
times, it's easy to ma
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-194540106
My thoughts on the pros/cons of having Python's Pipeline be a wrapper for
the Java Pipeline:
Pros:
* Less code duplication. This would have an even highe
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-194617519
@jkbradley I'll try to make it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11266#issuecomment-195858970
Close it since we have https://github.com/apache/spark/pull/11683. I'll
leave JIRA SPARK-13388 to be solved later.
---
If your project is set up for it, you can reply
Github user yinxusen closed the pull request at:
https://github.com/apache/spark/pull/11266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
18 matches
Mail list logo