Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-108035561
LGTM. Merging this, in master and branch 1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-108025305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-108025290
[Test build #33994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33994/consoleFull)
for PR 6555 at commit
[`c0ceea8`](https://git
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107997452
Lgtm pending tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107995146
[Test build #33994 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33994/consoleFull)
for PR 6555 at commit
[`c0ceea8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107994988
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107994949
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6555#discussion_r31493047
--- Diff: external/flume-sink/pom.xml ---
@@ -42,22 +42,47 @@
org.apache.flume
flume-ng-sdk
+
+
+
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6555#discussion_r31491751
--- Diff: external/flume-sink/pom.xml ---
@@ -42,22 +42,47 @@
org.apache.flume
flume-ng-sdk
+
+
+
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6555#discussion_r31490512
--- Diff: external/flume-sink/pom.xml ---
@@ -42,22 +42,47 @@
org.apache.flume
flume-ng-sdk
+
+
+
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6555#discussion_r31490385
--- Diff: external/flume-sink/pom.xml ---
@@ -42,22 +42,47 @@
org.apache.flume
flume-ng-sdk
+
+
+
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107722472
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107722441
[Test build #33914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33914/consoleFull)
for PR 6555 at commit
[`c38228d`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107685017
[Test build #33914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33914/consoleFull)
for PR 6555 at commit
[`c38228d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107684709
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107684663
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107682609
Hmm. Wonder how those tests passed locally. Yeah, I'll add the dependency
in test scope.
---
If your project is set up for it, you can reply to this email and have your
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107681637
Some of the test code's transitive dependencies seem to pull in
`Preconditions`. How about including Guava as a test dependency? Does that
complicate things?
-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107680243
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107680224
[Test build #33909 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33909/consoleFull)
for PR 6555 at commit
[`b7a0349`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107663190
[Test build #33909 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33909/consoleFull)
for PR 6555 at commit
[`b7a0349`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107662798
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107662782
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107656134
Hmm... the build failure doesn't seem related to the changes, but I'll take
another look.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107653652
[Test build #33908 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33908/consoleFull)
for PR 6555 at commit
[`6e0942d`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107653660
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107653465
+1. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107652687
[Test build #33908 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33908/consoleFull)
for PR 6555 at commit
[`6e0942d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107652244
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107652196
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107650637
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107650635
[Test build #33907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33907/consoleFull)
for PR 6555 at commit
[`2d79260`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107649152
[Test build #33907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33907/consoleFull)
for PR 6555 at commit
[`2d79260`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107648186
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107648115
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107647117
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6555#discussion_r31448748
--- Diff: external/flume-sink/pom.xml ---
@@ -85,6 +97,13 @@
+
+org.apache.maven.plugins
+
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107643977
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107643971
[Test build #33905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33905/consoleFull)
for PR 6555 at commit
[`2d79260`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107642767
[Test build #33905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33905/consoleFull)
for PR 6555 at commit
[`2d79260`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107642524
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107642567
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6555#issuecomment-107641973
I verified that there are no references to Guava in the generated bytecode
and that Guava does not show up in `mvn dependency:tree`.
---
If your project is set up for it
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/6555
[SPARK-8015] [flume] Remove Guava dependency from flume-sink.
The minimal change would be to disable shading of Guava in the module,
and rely on the transitive dependency from other libraries inst
45 matches
Mail list logo