[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49400124 QA results for PR 1478:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49401911 QA results for PR 1478:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1478#discussion_r15099390 --- Diff: core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala --- @@ -17,9 +17,49 @@ package org.apache.spark.util.random

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49403909 QA tests have started for PR 1478. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16819/consoleFull ---

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49404149 QA results for PR 1478:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49404318 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49404657 QA tests have started for PR 1478. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16820/consoleFull ---

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49412218 QA results for PR 1478:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49471598 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-17 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/1478 Reservoir sampling implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark reservoirSample Alternatively you can review and

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49395696 QA tests have started for PR 1478. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16808/consoleFull ---

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-17 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1478#discussion_r15096878 --- Diff: core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala --- @@ -17,9 +17,49 @@ package org.apache.spark.util.random

[GitHub] spark pull request: Reservoir sampling implementation.

2014-07-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1478#issuecomment-49396936 QA tests have started for PR 1478. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16810/consoleFull ---