Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18127631
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57075299
Thanks. Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126678
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +144,15 @@ class CoarseGrainedSchedule
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126677
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +144,15 @@ class CoarseGrainedSchedule
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126669
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +176,22 @@ class CoarseGrainedSchedule
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126667
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -297,6 +291,7 @@ class CoarseGrainedSchedulerB
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126665
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -85,16 +79,14 @@ class CoarseGrainedSchedulerB
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126663
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -126,8 +120,8 @@ class CoarseGrainedSchedulerB
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126658
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Fo
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126545
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -104,13 +96,15 @@ class CoarseGrainedScheduler
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126510
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Fo
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18126499
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Fo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57043734
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57043731
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20907/consoleFull)
for PR 2533 at commit
[`6890663`](https://github.com/a
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57042814
LGTM pending a couple of stylistic comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122075
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -104,13 +96,15 @@ class CoarseGrainedScheduler
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122072
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +144,15 @@ class CoarseGrainedSchedule
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122067
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +144,15 @@ class CoarseGrainedSchedule
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122066
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +144,15 @@ class CoarseGrainedSchedule
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122064
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +176,22 @@ class CoarseGrainedSchedule
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122060
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -297,6 +291,7 @@ class CoarseGrainedSchedulerB
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122048
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Fo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18122044
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -85,16 +79,14 @@ class CoarseGrainedSchedulerB
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57042564
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20907/consoleFull)
for PR 2533 at commit
[`6890663`](https://github.com/ap
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57042526
I really like this change. Made some minor comments.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18121960
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -126,8 +120,8 @@ class CoarseGrainedSchedulerBackend
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-57042458
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18121953
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18121952
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18066186
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +178,22 @@ class CoarseGrainedSchedule
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18066183
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +178,22 @@ class CoarseGrainedSchedule
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18065891
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +147,14 @@ class CoarseGrainedSchedule
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18065662
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -126,8 +124,8 @@ class CoarseGrainedSchedulerB
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18065400
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -104,13 +100,15 @@ class CoarseGrainedSchedule
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18065365
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -85,16 +79,18 @@ class CoarseGrainedSchedulerB
Github user tigerquoll commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18065148
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -62,15 +62,9 @@ class CoarseGrainedSchedulerBa
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18027094
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +178,22 @@ class CoarseGrainedScheduler
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18027054
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +178,22 @@ class CoarseGrainedScheduler
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18026933
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -179,25 +178,22 @@ class CoarseGrainedScheduler
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18026850
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -149,13 +147,14 @@ class CoarseGrainedScheduler
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18026763
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -126,8 +124,8 @@ class CoarseGrainedSchedulerBa
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18026654
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -85,16 +79,18 @@ class CoarseGrainedSchedulerBa
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18026675
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -104,13 +100,15 @@ class CoarseGrainedScheduler
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18026563
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -85,16 +79,18 @@ class CoarseGrainedSchedulerBa
Github user Ishiihara commented on a diff in the pull request:
https://github.com/apache/spark/pull/2533#discussion_r18026314
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -62,15 +62,9 @@ class CoarseGrainedSchedulerBac
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2533#issuecomment-56803421
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user tigerquoll opened a pull request:
https://github.com/apache/spark/pull/2533
SPARK-CORE [SPARK-3651] Group common CoarseGrainedSchedulerBackend
variables together
from [SPARK-3651]
In CoarseGrainedSchedulerBackend, we have:
private val executorActor = new
48 matches
Mail list logo
