Github user davies closed the pull request at:
https://github.com/apache/spark/pull/3320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63900346
Thanks a lot @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63899911
Merged into master and branch-1.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63893828
[Test build #23684 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23684/consoleFull)
for PR 3320 at commit
[`8003dfc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63893839
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63881779
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63880964
[Test build #23684 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23684/consoleFull)
for PR 3320 at commit
[`8003dfc`](https://githu
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63880444
@jkbradley done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63877350
@davies Thanks for adding this API! I made a few small comments. Other
than those, LGTM
---
If your project is set up for it, you can reply to this email and have yo
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20676263
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +182,206 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collec
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20676265
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +182,206 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collec
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20676259
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +182,206 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63869599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63869584
[Test build #23677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23677/consoleFull)
for PR 3320 at commit
[`e0df852`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63856051
[Test build #23677 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23677/consoleFull)
for PR 3320 at commit
[`e0df852`](https://githu
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63853606
@mengxr done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63777609
@davies We updated the `RandomForest` API in #3374 . Now `RandomForest`
returns a `RandomForestModel`. Could you rebase and update this PR? Thanks!
---
If your project is
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20619737
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).colle
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20619421
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collect()
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20618922
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).colle
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20618709
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collect()
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20591273
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63418185
[Test build #23528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23528/consoleFull)
for PR 3320 at commit
[`885abee`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63418194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63416983
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63416979
[Test build #23527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23527/consoleFull)
for PR 3320 at commit
[`dae7fc0`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63411351
[Test build #23528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23528/consoleFull)
for PR 3320 at commit
[`885abee`](https://githu
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20481177
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).colle
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63410715
[Test build #23527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23527/consoleFull)
for PR 3320 at commit
[`dae7fc0`](https://githu
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20481058
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collect()
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20480563
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collect()
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20479768
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).colle
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20479607
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -465,6 +465,40 @@ class PythonMLLibAPI extends Serializable {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3320#discussion_r20479562
--- Diff: python/pyspark/mllib/tree.py ---
@@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,
>>> model.predict(rdd).collect()
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63390276
[Test build #23495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23495/consoleFull)
for PR 3320 at commit
[`89a000f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63390282
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63377165
[Test build #23495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23495/consoleFull)
for PR 3320 at commit
[`89a000f`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63371428
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63371418
[Test build #23487 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23487/consoleFull)
for PR 3320 at commit
[`565d476`](https://gith
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3320#issuecomment-63364920
@JoshRosen corrected, thanks! I had these mistakes many times :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
40 matches
Mail list logo