Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20511#discussion_r168691737
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -160,6 +160,15 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168711619
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -395,16 +395,19 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20511#discussion_r168833177
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -160,6 +160,15 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20511#discussion_r168834997
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -160,6 +160,15 @@ abstract class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20511#discussion_r168838556
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -160,6 +160,15 @@ abstract class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Yep. I'll try for this, too. @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20057
Thank you for pinging me, @gatorsmile . Yep. I'll take a look both
`OrcQuerySuite` and this PR in this morning. Sorry for late response,
@danielv
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20511
@gatorsmile .
In general, I agree with your idea to have a complete test coverage.
And, I think we can double the test coverage by enabling and disabling the
vectorization for the
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20511
Thank you. I created [SPARK-23452 Extend test coverage to all ORC
readers](https://issues.apache.org/jira/browse/SPARK-23452) for that. Maybe, we
can add more comments during that JIRA task
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168882085
--- Diff: docs/sql-programming-guide.md ---
@@ -1372,6 +1372,13 @@ the following case-insensitive options:
This is a JDBC writer related
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168882599
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -119,6 +119,8 @@ class JDBCOptions
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168882930
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -102,7 +102,12 @@ object JdbcUtils extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -64,7 +64,15 @@ private class AggregatedDialect(dialects
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -64,7 +64,15 @@ private class AggregatedDialect(dialects
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883216
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -49,4 +49,16 @@ private object DB2Dialect extends JdbcDialect
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883425
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala ---
@@ -42,4 +42,16 @@ private object MsSqlServerDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883267
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -49,4 +49,16 @@ private object DB2Dialect extends JdbcDialect
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883530
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala ---
@@ -42,4 +42,16 @@ private object MsSqlServerDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883553
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ---
@@ -46,4 +46,16 @@ private case object MySQLDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883542
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ---
@@ -46,4 +46,16 @@ private case object MySQLDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -94,5 +94,20 @@ private case object OracleDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883594
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -94,5 +94,20 @@ private case object OracleDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883612
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala ---
@@ -89,11 +89,17 @@ private object PostgresDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168883676
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -31,4 +31,16 @@ private case object TeradataDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168884880
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -860,14 +860,41 @@ class JDBCSuite extends SparkFunSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168885013
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -860,14 +860,41 @@ class JDBCSuite extends SparkFunSuite
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20057
Hi, @danielvdende. I finished my first round review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
The reproducible test case is added into PR description and the code is
updated according to @kiszk and @cloud-fan 's com
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Thank you for last-minute review before vacation. :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Oh..
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
The failure is irrelevant to this PR.
```
org.apache.spark.sql.hive.client.HiveClientSuites.(It is not a test it is a
sbt.testing.NestedSuiteSelector
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20511
Sure. @gatorsmile . I'll create a new PR for Apache Spark 2.4 default
configuration and a migration guide for 2.3 to 2.4 after this PR is m
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Thank you for retriggering, @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20511
Thank you, @gatorsmile !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20634
[SPARK-23456][SPARK-21783] Turn on `native` ORC impl and PPD by default
## What changes were proposed in this pull request?
Apache Spark 2.3 introduced `native` ORC supports with
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Yep. @kiszk . @mgaido91 also reports that, so I'm investigating that more.
However, that doesn't mean this approach is not proper. You can see the
manual test case example i
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
For the following, I'll.
> Would it be worth to add this JIRA number in a comment as we did for ORC?
---
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927406
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala ---
@@ -41,4 +41,16 @@ private object DerbyDialect extends JdbcDialect
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927400
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -102,7 +102,12 @@ object JdbcUtils extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927408
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala ---
@@ -41,4 +41,16 @@ private object DerbyDialect extends JdbcDialect
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927495
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -120,11 +121,13 @@ abstract class JdbcDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927546
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -49,4 +49,17 @@ private object DB2Dialect extends JdbcDialect
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927597
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala ---
@@ -42,4 +42,17 @@ private object MsSqlServerDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927608
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala ---
@@ -42,4 +42,17 @@ private object MsSqlServerDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927633
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ---
@@ -46,4 +46,17 @@ private case object MySQLDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927631
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala ---
@@ -42,4 +42,17 @@ private object MsSqlServerDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927651
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -94,5 +94,21 @@ private case object OracleDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927699
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala ---
@@ -94,5 +94,21 @@ private case object OracleDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927785
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
@@ -64,7 +64,16 @@ private class AggregatedDialect(dialects
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168927868
--- Diff: docs/sql-programming-guide.md ---
@@ -1372,6 +1372,13 @@ the following case-insensitive options:
This is a JDBC writer related
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168928044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -120,11 +121,13 @@ abstract class JdbcDialect extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20057
I finished my second round. Could you update once more?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Thank you for review, @mgaido91 .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Thank you, @kiszk . I added SPARK-23390 in the PR description.
> Would it be worth to add this JIRA number in a comment as we did for
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Oh, @kiszk . The following meat really `comment` in the code. Sorry, I
misunderstood.
> Would it be worth to add this JIRA number in a comment as we did for
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168929352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -395,16 +395,21 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168930195
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala ---
@@ -85,15 +85,24 @@ private object PostgresDialect extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
The final failure is irrelevant to this.
```
org.apache.spark.sql.sources.CreateTableAsSelectSuite.(It is not a test it
is a sbt.testing.SuiteSelector
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168969101
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala ---
@@ -85,15 +85,24 @@ private object PostgresDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168969792
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -102,7 +102,12 @@ object JdbcUtils extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168970903
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -31,4 +31,19 @@ private case object TeradataDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168971074
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -31,4 +31,19 @@ private case object TeradataDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r168971182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -49,4 +49,17 @@ private object DB2Dialect extends JdbcDialect
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20636
Thank you for pining me and working on this issue, @kiszk .
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r169151430
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -58,15 +58,20
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20619
Thank you all!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
Thank you for review, @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20616#discussion_r169248859
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala
---
@@ -42,9 +42,13 @@ object FileStreamSink extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20634
Thank you, @gatorsmile .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169443807
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -31,4 +31,19 @@ private case object TeradataDialect extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
Could you review this, @zsxwing and @gatorsmile ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
With more manual tests, I observed that the original situation happens on
only kerberized environments. I updated PR/JIRA description
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
The warning error messages in kerberized environments are the one in
PR/JIRA description.
For example, Apache Spark 2.2.1 binary on kerberized cluster shows the
following
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
Here, it is. It's `AccessControlException`, @zsxwing .
```
18/02/20 23:46:53 WARN streaming.FileStreamSink: Error while looking for
metadata dire
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20616
Thank you, @zsxwing and @cloud-fan .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169530627
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -31,4 +31,19 @@ private case object TeradataDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169688539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -31,4 +31,19 @@ private case object TeradataDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169689517
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
@@ -31,4 +31,19 @@ private case object TeradataDialect extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169692053
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -684,17 +684,17 @@ class JDBCSuite extends SparkFunSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169692391
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -839,35 +839,68 @@ class JDBCSuite extends SparkFunSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169692336
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -805,13 +805,13 @@ class JDBCSuite extends SparkFunSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169692604
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -839,35 +839,68 @@ class JDBCSuite extends SparkFunSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169692801
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -839,35 +839,68 @@ class JDBCSuite extends SparkFunSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169693135
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -102,7 +102,12 @@ object JdbcUtils extends
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20522
@tgravescs .
Yep. The title of SPARK-22158 was changed recently because it only
supported Table SerDe properties. If you set the ORC property into Table SerDe
properties (not in Table
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20679
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20522
Sure. I'll try, @gatorsmile . It'll take some time for me.
---
-
To unsubscribe, e-mail: review
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Rebased to the master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20684
Hi, @gatorsmile and @cloud-fan .
Since 2.3 vote passed, can we have this in `branch-2.3` for Apache Spark
2.3.1?
The conflicts on `LocalRelation.scala` is simply due to indentation
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Finally, Spark 2.3 passes the vote. Could you review this, @gatorsmile ?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20684
I see. Thank you for confirmation, @gatorsmile !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20208
Thank you for retriggering, @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20687#discussion_r171328612
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala
---
@@ -25,8 +25,8 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20687#discussion_r171328520
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala
---
@@ -331,4 +331,24 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20692#discussion_r171334033
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2264,4 +2264,18 @@ class DataFrameSuite extends QueryTest with
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20688
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20692
The failures of `SQLQueryTestSuite` are legitimate.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
1301 - 1400 of 7376 matches
Mail list logo
