Re: [CVS] RPM: rpm/lib/ fsm.c

2008-12-20 Thread Per Øyvind Karlsen
2008/12/20 Ralf S. Engelschall > > On Sat, Dec 20, 2008, Per Øyvind Karlsen wrote: > > > [...] > > fsm.c: In function 'fsmMapFContext': > > fsm.c:772: warning: unused variable > > 'st' > > > > This one? > > Yes, exactly! > > > I get it on linux as well, but I never figured out why it complained >

Re: [CVS] RPM: rpm/lib/ fsm.c

2008-12-20 Thread Ralf S. Engelschall
On Sat, Dec 20, 2008, Per Øyvind Karlsen wrote: > [...] > fsm.c: In function 'fsmMapFContext': > fsm.c:772: warning: unused variable > 'st' > > This one? Yes, exactly! > I get it on linux as well, but I never figured out why it complained > about st being unused since it seemingly did get used t

Re: [CVS] RPM: rpm/lib/ fsm.c

2008-12-20 Thread Per Øyvind Karlsen
2008/12/20 Ralf S. Engelschall > RPM Package Manager, CVS Repository > http://rpm5.org/cvs/ > > > > Server: rpm5.org Name: Ralf S. Engelschall > Root: /v/rpm/cvs Ema

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
On Jul 18, 2007, at 12:39 PM, Ralf S. Engelschall wrote: On Wed, Jul 18, 2007, Jeff Johnson wrote: [...] Or are you planning that RPM can be really internally run multi-threaded? Then the case is different, of course. Then you _have_ to use POSIX pthreads, of course. rpm is already mult

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Ralf S. Engelschall
On Wed, Jul 18, 2007, Jeff Johnson wrote: > [...] >> Or are you planning that RPM can be really internally run >> multi-threaded? Then the case is different, of course. Then you _have_ >> to use POSIX pthreads, of course. > > rpm is already multi-threaded many years now: > rpm -Uvh --psmthrea

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
On Jul 18, 2007, at 11:11 AM, Ralf S. Engelschall wrote: On Wed, Jul 18, 2007, Jeff Johnson wrote: [...] If I read correctly, the conservative/portable approach is - lpthread in executable so that external libraries linked with -lpthread function correctly. That kinda forces "mandatory" -lp

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
On Jul 18, 2007, at 11:11 AM, Ralf S. Engelschall wrote: On Wed, Jul 18, 2007, Jeff Johnson wrote: [...] If I read correctly, the conservative/portable approach is - lpthread in executable so that external libraries linked with -lpthread function correctly. That kinda forces "mandatory" -lp

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Ralf S. Engelschall
On Wed, Jul 18, 2007, Jeff Johnson wrote: > [...] > If I read correctly, the conservative/portable approach is -lpthread in > executable so that external libraries linked with -lpthread function > correctly. That kinda forces "mandatory" -lpthread for rpm when > external libraries may (or may not)

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
On Jul 18, 2007, at 10:49 AM, Ralf S. Engelschall wrote: [...] I have been linking -lpthreads in rpm because beecrypt uses threads to gather entropy, and because of posix-shared-mutexes. BeeCrypt when built with --disable-threads uses a /dev/random just fine AFAIK. And the POSIX mutexe

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Ralf S. Engelschall
On Wed, Jul 18, 2007, Jeff Johnson wrote: > On Jul 18, 2007, at 10:14 AM, Ralf S. Engelschall wrote: > >> On Wed, Jul 18, 2007, Jeff Johnson wrote: >> >>> Ripping the need for -lpthread is on my todo list. Easier to rip than >>> discuss. >> >> Well, a simple --without-pthreads now does the trick j

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
On Jul 18, 2007, at 10:14 AM, Ralf S. Engelschall wrote: On Wed, Jul 18, 2007, Jeff Johnson wrote: Ripping the need for -lpthread is on my todo list. Easier to rip than discuss. Well, a simple --without-pthreads now does the trick just fine and allows one to build RPM without any needs for

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Ralf S. Engelschall
On Wed, Jul 18, 2007, Jeff Johnson wrote: > Ripping the need for -lpthread is on my todo list. Easier to rip than > discuss. Well, a simple --without-pthreads now does the trick just fine and allows one to build RPM without any needs for an existing POSIX pthreads API. That's all I personally nee

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
Ripping the need for -lpthread is on my todo list. Easier to rip than discuss. 73 de Jeff On Jul 18, 2007, at 8:53 AM, Ralf S. Engelschall wrote: RPM Package Manager, CVS Repository http://rpm5.org/cvs/ __ __

Re: [CVS] RPM: rpm/lib/ fsm.c package.c rpm/rpmdb/ header.c rpmdb.h

2007-07-10 Thread Jeff Johnson
Thank you for lib/fsm.c, my zen meditation on the insanity of compiler warnings. I shall find a new puzzle soon. Note that there are *three* ways to open a rpmdb, and none of the methods takes a path to the rpmdb. Baroque'n! 73 de Jeff On Jul 10, 2007, at 9:05 AM, Ralf S. Engelschall wrote:

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-06-19 Thread Jeff Johnson
On Jun 19, 2007, at 12:20 PM, Ralf S. Engelschall wrote: On Tue, Jun 19, 2007, Jeff Johnson wrote: Getting mmap enabled is likely a large performance win. Maybe, yes. I've now added the missing Autoconf glue AC_FUNC_MMAP for checking whether the system supports a reasonable mmap(2). Let's

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-06-19 Thread Ralf S. Engelschall
On Tue, Jun 19, 2007, Jeff Johnson wrote: > On Jun 19, 2007, at 2:42 AM, Ralf S. Engelschall wrote: > >> RPM Package Manager, CVS Repository >> http://rpm5.org/cvs/ >> >> >> >> Server: rpm5.org

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-06-19 Thread Jeff Johnson
On Jun 19, 2007, at 2:42 AM, Ralf S. Engelschall wrote: RPM Package Manager, CVS Repository http://rpm5.org/cvs/ __ __ Server: rpm5.org Name: Ralf S. Engelschall Root: /v/rpm/cvs