Conan-Kudo approved this pull request.
Looks fantastic to me!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/116#pullrequestreview-15439382__
This PR is related to https://github.com/rpm-software-management/rpm/issues/113.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/117#issuecomment-270818051__
This commit is to support pbzip2 command for parallel (de) compression
with 'rpmbuild' command. The pbzip2 is compatible with the existing bzip2.
* Todo: The next step is adding pbzip2 content in .po files.
Signed-off-by: Geunsik Lim
You can view, comment on, or merge this pull request online at
rpm2cpio and rpm2archive happily write binary data to the output
terminal. This happens, for example, when I'm typing a command such as
"rpm2cpio foo.rpm | less" and I make a typo, hitting instead of
the pipe key. This often results in hilarious (if bewildering) font and
character encoding chang
On Thu, Jan 05, 2017 at 03:40:42PM +0200, Panu Matilainen wrote:
> > > When checking for pre-existing links see if they already point to
> > > the right file and in that case just reuse it instead of creating new
> > > ones.
> >
> > > @@ -1572,6 +1573,16 @@ static int addNewIDSymlink(FileList fl,
On 01/05/2017 02:50 PM, Mark Wielaard wrote:
On Thu, Jan 05, 2017 at 01:47:28PM +0200, Panu Matilainen wrote:
Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited
binary builds (which can be handy for testing when working on large
packages), eg:
rpmbuild -bi foo.spec; rpmbu
On Thu, Jan 05, 2017 at 01:47:28PM +0200, Panu Matilainen wrote:
> Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited
> binary builds (which can be handy for testing when working on large
> packages), eg:
> rpmbuild -bi foo.spec; rpmbuild -bb --short-circuit foo.spec
>
> Th
On 01/05/2017 02:08 PM, Mark Wielaard wrote:
On Thu, Jan 05, 2017 at 12:27:52PM +0200, Panu Matilainen wrote:
It looks commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 intends to skip
symlinks since it filters on S_ISREG(), but since uses fstat()
on already open()'ed file it ends up stat()'ing th
On Thu, Jan 05, 2017 at 12:27:52PM +0200, Panu Matilainen wrote:
> It looks commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 intends to skip
> symlinks since it filters on S_ISREG(), but since uses fstat()
> on already open()'ed file it ends up stat()'ing the symlink target.
> Flip stat() + open() a
Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited
binary builds (which can be handy for testing when working on large
packages), eg:
rpmbuild -bi foo.spec; rpmbuild -bb --short-circuit foo.spec
The problem is that in a short-circuited build all the links already
exist and
Versioned shared libraries typically have several symlinks pointing
to them directly and indirectly. When %_build_id_links is set to compat or
separate this causes bogus warnings about duplicate build-ids.
It looks commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 intends to skip
symlinks since it f
11 matches
Mail list logo
