Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)

2017-11-03 Thread Yuri Dario
ydario commented on this pull request. > @@ -0,0 +1,3 @@ +%__os2_provides%{_rpmconfigdir}/os2deps.sh --provides +%__os2_requires%{_rpmconfigdir}/os2deps.sh --requires +%__os2_magic ^(32|64)-bit.*$ mmhh is it ran across which file types? e.g. DLL magic

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)

2017-11-03 Thread Yuri Dario
ydario commented on this pull request. > @@ -0,0 +1,3 @@ +%__os2_provides%{_rpmconfigdir}/os2deps.sh --provides +%__os2_requires%{_rpmconfigdir}/os2deps.sh --requires +%__os2_magic ^(32|64)-bit.*$ The full output is 32-bit OS/2 executable [WINDOW

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)

2017-11-03 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#pullrequestreview-74173395___ Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)

2017-11-03 Thread ニール・ゴンパ
Conan-Kudo requested changes on this pull request. > @@ -0,0 +1,3 @@ +%__os2_provides%{_rpmconfigdir}/os2deps.sh --provides +%__os2_requires%{_rpmconfigdir}/os2deps.sh --requires +%__os2_magic ^(32|64)-bit.*$ This magic is too broad. Is there a may to m

[Rpm-maint] [rpm-software-management/rpm] RFC Add OS/2 magic and dependency parser for LX executables. (#351)

2017-11-03 Thread Yuri Dario
Added file magic and parser for LX executable format. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/351 -- Commit Summary -- * Add OS/2 magic and dependency parser for LX executables. -- File Changes -- M Makefile.am

[Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)

2017-11-03 Thread Yuri Dario
Disable PIC flags in OS/2 build. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/350 -- Commit Summary -- * Building with PIC enabled is not supported in OS/2. -- File Changes -- M configure.ac (8) -- Patch Links --

[Rpm-maint] [rpm-software-management/rpm] RFC: detect OS/2 operating system (#349)

2017-11-03 Thread Yuri Dario
Detec OS/2 operating system when running configure script. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/349 -- Commit Summary -- * Replace hardcoded lib path with python prefix value. * Detect OS/2 operating system in c

Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)

2017-11-03 Thread Jeff Johnson
Fussing with env-shebangs is the tip of a deeper problem: scripts can/will execute other executables, and there are no attempts to auto-generate rpm dependencies for other needed executables within scripts, including searching run-time (not build-time) PATH to see if executable exists. -- You

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)

2017-11-03 Thread Yuri Dario
The idea was to return a valid file name, so called code has something to open/close. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341742426

Re: [Rpm-maint] [rpm-software-management/rpm] Update Polish plural forms (#347)

2017-11-03 Thread Piotr Drąg
I did try on Zanata, but I don’t think it allows to edit .po headers (including Plural-Forms). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/347#issuecomment-341738032___

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)

2017-11-03 Thread ニール・ゴンパ
@ydario Sure, but then the question becomes, why `/dev/tty` is hardcoded then? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341733198

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)

2017-11-03 Thread Yuri Dario
ah ok now I see. Is "Test for ctermid() existence. This is done because the OS/2 platform does not provide it" a valid commit message? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-managemen

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)

2017-11-03 Thread Yuri Dario
I just checked SHLIB_EXT in python for OS/2, and it reports ['".dll"\r'] which is even wrong. I don't know why historically the code is compiling shared modules with PYD extension. This is a bit strange since DLL is more common and I don't see a good reason for changing it unless original porter

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)

2017-11-03 Thread Yuri Dario
I was not aware that x86_64 was already ending in 64.But python lib can be queried using the code in the 2nd comment, I just don't know how to insert into a .attr file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https:

Re: [Rpm-maint] [rpm-software-management/rpm] Add runtime_library_dirs for custom prefix. (#348)

2017-11-03 Thread Igor Gnatenko
Is RPATH being removed on installation? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/348#issuecomment-341713238___ Rpm-maint m

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)

2017-11-03 Thread Panu Matilainen
Yes, obviously. But the rationale etc needs to be documented in commit messages, not somewhere in GH. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-34171

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)

2017-11-03 Thread Yuri Dario
This is a follow up of discussion on issue #260 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341710617___ Rp

[Rpm-maint] [rpm-software-management/rpm] Add runtime_library_dirs for custom prefix. (#348)

2017-11-03 Thread Jun Aruga
Previously we needed to set `LD_LIBRARY_PATH` to run the Python bindings for custom prefix. ``` $ LD_LIBRARY_PATH=$HOME/git/rpm/dest/lib python3 -c 'import rpm; print(rpm.__version__)' 4.14.90 ``` This PR to do "import rpm" without LD_LIBRARY_PATH. Below is the way to reproduce and test it. Th

Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)

2017-11-03 Thread Jun Aruga
@pmatilai thanks for your checking! > but I don't see this helping #130 at least in the general case. OK, perhaps, I may need to send additional PR for that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.co

Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)

2017-11-03 Thread Panu Matilainen
Dunno but seriously doubt it. Validated patches welcome ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#issuecomment-341685065__

Re: [Rpm-maint] [rpm-software-management/rpm] Check for 'gettext' during configure script (#245)

2017-11-03 Thread Panu Matilainen
Rpm simply does what gettext documentation recommends: ``` AM_GNU_GETTEXT([external]) ``` If you dont have/want gettext, use --disable-nls as explained in the above. I dont see anything to fix here... -- You are receiving this because you are subscribed to this thread. Reply to this email dire

Re: [Rpm-maint] [rpm-software-management/rpm] Check for 'gettext' during configure script (#245)

2017-11-03 Thread Panu Matilainen
Closed #245. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/245#event-1324726714___ Rpm-maint mailing list Rpm-maint@lists.rpm

Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)

2017-11-03 Thread ニール・ゴンパ
@pmatilai Wouldn't using `unmap()` + `mmap()` work as an alternative to bombing out on `mremap()`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#issuecomment-341684

Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)

2017-11-03 Thread Panu Matilainen
Closed #334. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#event-1324715733___ Rpm-maint mailing list Rpm-maint@lists.rpm

Re: [Rpm-maint] [rpm-software-management/rpm] rpm with ndb fails to build on macOS due to missing "mremap()" (#334)

2017-11-03 Thread Panu Matilainen
Fixed in commit 8c4bfd74b568d9be138e8ec4fd38dc2ca427d433. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/334#issuecomment-341682939___

Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)

2017-11-03 Thread ニール・ゴンパ
@ignatenkobrain If we pull in a cleaned up version of #122, we will have a consistent way to manage brp scripts via option 1. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pul

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: show command which is executed for dependency generator in debug mode (#338)

2017-11-03 Thread Igor Gnatenko
@pmatilai great! thanks a lot ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/338#issuecomment-341673616___ Rpm-maint mailin

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: show command which is executed for dependency generator in debug mode (#338)

2017-11-03 Thread Panu Matilainen
Closed #338. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/338#event-1324633493___ Rpm-maint mailing list Rpm-maint@lists.rpm

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: show command which is executed for dependency generator in debug mode (#338)

2017-11-03 Thread Panu Matilainen
Ask nicely and you shall receive :) Example output with commit 1d1ff6c86fc9afb4c6c89b42fdb5be851f13cb7a: [pmatilai@sopuli rpm]$ rpm -ql python2-libs|./rpmdeps -R --rpmfcdebug -vv 2>&1|grep "^D: Executing"|head -5 D: Executing /usr/lib/rpm/pythondistdeps.py --provides --majorver-provides on /usr

Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)

2017-11-03 Thread Panu Matilainen
Merged #327. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/327#event-1324601413___ Rpm-maint mailing list Rpm-maint@lists.rpm.o

Re: [Rpm-maint] [rpm-software-management/rpm] Fix Python bindings library path for custom prefix. (#327)

2017-11-03 Thread Panu Matilainen
Because we haven't had a chance to dig into it? I suppose it's fine for what it is, but I don't see this helping #130 at least in the general case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-soft

Re: [Rpm-maint] [rpm-software-management/rpm] Add a new option --alldeps to rpmdeps (#220)

2017-11-03 Thread Panu Matilainen
Sorry for taking so long with this, and thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/220#issuecomment-341666296_

Re: [Rpm-maint] [rpm-software-management/rpm] Add a new option --alldeps to rpmdeps (#220)

2017-11-03 Thread Panu Matilainen
Merged #220. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/220#event-1324596559___ Rpm-maint mailing list Rpm-maint@lists.rpm.o

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)

2017-11-03 Thread Panu Matilainen
Yup, %{_libdir} is wrong on x86_64 and technically like with %{_prefix}, there's no actual guarantee that python shares the same prefix as rpm. So I guess the really right thing to do would be querying all those different library paths out of python itself: we have %python_sitelib and %python_s

Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)

2017-11-03 Thread Miro Hrončok
JFYI (Python specific) https://github.com/fedora-python/python-rpm-porting/issues/24 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/344#issuecomment-341651577_

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)

2017-11-03 Thread Panu Matilainen
I think it might be actually better to just not export posix.ctermid() on systems that don't support it. I don't see much good coming out of claiming the controlling terminal is /dev/tty on a system that doesn't have terminals at all. And yeah a bit of rationale as for the why part is in order,

Re: [Rpm-maint] [rpm-software-management/rpm] Update Polish plural forms (#347)

2017-11-03 Thread Panu Matilainen
Merged, but in general translation updates should go through Zanata. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/347#issuecomment-341645006__

Re: [Rpm-maint] [rpm-software-management/rpm] Update Polish plural forms (#347)

2017-11-03 Thread Panu Matilainen
Merged #347. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/347#event-1324449164___ Rpm-maint mailing list Rpm-maint@lists.rpm.o

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Test for ctermid() existence. (#345)

2017-11-03 Thread Igor Gnatenko
Some rationale (e.g. where function doesn't exist) would be good ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/345#issuecomment-341633520___

Re: [Rpm-maint] [rpm-software-management/rpm] RFC: Replace hardcoded path with _libdir macro as done in pkgconfig.attr. (#346)

2017-11-03 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -1,4 +1,4 @@ %__python_provides %{_rpmconfigdir}/pythondeps.sh --provides %__python_requires %{_rpmconfigdir}/pythondeps.sh --requires -%__python_path ^((/usr/lib(64)?/python[[:digit:]]\\.[[:digit:]]/.*\\.(py[oc]?|so))|(%{_bindir}/py

Re: [Rpm-maint] [rpm-software-management/rpm] scripts: add brp-mangle-shebangs (#344)

2017-11-03 Thread Igor Gnatenko
> Down that path, you'd probably want to add some further restrictions to some > interpreters, eg -E / -I / -s for Python etc. This would be good idea (cc @encukou @hroncok @stratakis @torsava) > So lets just accept there are valid reasons for both, and not make life > unnecessarily hard for ei