Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-02-02 Thread Paolo Bonzini
On 02/02/2011 09:42 AM, Gleb Natapov wrote: > The alternative would be to get it via fw_cfg. > How will this help? We want to lie that we support RTC wakeup without actually supporting it. We would be able to lie or say the truth at will. Distros that care about WHQL/SVVP can turn the lie o

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-02-02 Thread Paolo Bonzini
On 01/30/2011 04:33 PM, Gleb Natapov wrote: > > In theory a guest could check whether RTC alarm reboot is supported, > if not it keeps awake, if it is it can set the alarm to sleep. So > if seabios lies it could break that guest. > Theoretically possible. > However that's an unlikely scen

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 09:43:38AM +0100, Paolo Bonzini wrote: > On 02/02/2011 09:42 AM, Gleb Natapov wrote: > >>> The alternative would be to get it via fw_cfg. > >>> > >How will this help? We want to lie that we support RTC wakeup without > >actually supporting it. > > We would be able to lie o

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-02-02 Thread Gleb Natapov
On Wed, Feb 02, 2011 at 09:31:37AM +0100, Paolo Bonzini wrote: > On 01/30/2011 04:33 PM, Gleb Natapov wrote: > >>> > >>> In theory a guest could check whether RTC alarm reboot is supported, > >>> if not it keeps awake, if it is it can set the alarm to sleep. So > >>> if seabios lies it could br

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Avi Kivity
On 01/30/2011 04:34 PM, Gleb Natapov wrote: On Sun, Jan 30, 2011 at 09:29:57AM -0500, Kevin O'Connor wrote: > On Sun, Jan 30, 2011 at 02:17:11PM +0200, Gleb Natapov wrote: > > WHQL complains otherwise. > > > > Signed-off-by: Gleb Natapov > > Can you get this acked by one of the kvm/qemu ma

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
On Sun, Jan 30, 2011 at 05:25:05PM +0200, Avi Kivity wrote: > On 01/30/2011 05:23 PM, Gleb Natapov wrote: > >On Sun, Jan 30, 2011 at 05:15:49PM +0200, Avi Kivity wrote: > >> On 01/30/2011 05:13 PM, Gleb Natapov wrote: > >> >On Sun, Jan 30, 2011 at 05:08:18PM +0200, Avi Kivity wrote: > >> >> On

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Avi Kivity
On 01/30/2011 05:13 PM, Gleb Natapov wrote: On Sun, Jan 30, 2011 at 05:08:18PM +0200, Avi Kivity wrote: > On 01/30/2011 04:34 PM, Gleb Natapov wrote: > >On Sun, Jan 30, 2011 at 09:29:57AM -0500, Kevin O'Connor wrote: > >> On Sun, Jan 30, 2011 at 02:17:11PM +0200, Gleb Natapov wrote: > >>

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Avi Kivity
On 01/30/2011 05:23 PM, Gleb Natapov wrote: On Sun, Jan 30, 2011 at 05:15:49PM +0200, Avi Kivity wrote: > On 01/30/2011 05:13 PM, Gleb Natapov wrote: > >On Sun, Jan 30, 2011 at 05:08:18PM +0200, Avi Kivity wrote: > >> On 01/30/2011 04:34 PM, Gleb Natapov wrote: > >> >On Sun, Jan 30, 2011

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
On Sun, Jan 30, 2011 at 05:15:49PM +0200, Avi Kivity wrote: > On 01/30/2011 05:13 PM, Gleb Natapov wrote: > >On Sun, Jan 30, 2011 at 05:08:18PM +0200, Avi Kivity wrote: > >> On 01/30/2011 04:34 PM, Gleb Natapov wrote: > >> >On Sun, Jan 30, 2011 at 09:29:57AM -0500, Kevin O'Connor wrote: > >> >>

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
On Sun, Jan 30, 2011 at 05:08:18PM +0200, Avi Kivity wrote: > On 01/30/2011 04:34 PM, Gleb Natapov wrote: > >On Sun, Jan 30, 2011 at 09:29:57AM -0500, Kevin O'Connor wrote: > >> On Sun, Jan 30, 2011 at 02:17:11PM +0200, Gleb Natapov wrote: > >> > WHQL complains otherwise. > >> > > >> > Signed

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Kevin O'Connor
On Sun, Jan 30, 2011 at 03:30:43PM +0100, Peter Stuge wrote: > Gleb Natapov wrote: > > > > WHQL complains otherwise. > > > > > > Is there something further that should be activated, to actually > > > allow the wakeup to work? Hm, isn't S4 hibernate? > > > > Not in a bios. Qemu currently exits on

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
On Sun, Jan 30, 2011 at 09:29:57AM -0500, Kevin O'Connor wrote: > On Sun, Jan 30, 2011 at 02:17:11PM +0200, Gleb Natapov wrote: > > WHQL complains otherwise. > > > > Signed-off-by: Gleb Natapov > > Can you get this acked by one of the kvm/qemu maintainers? > Avi, Marcelo, Anthony can you look a

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Peter Stuge
Gleb Natapov wrote: > > > WHQL complains otherwise. > > > > Is there something further that should be activated, to actually > > allow the wakeup to work? Hm, isn't S4 hibernate? > > Not in a bios. Qemu currently exits on S4 (hibernate to disk). Restarting > it activates resume process. On real H

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Kevin O'Connor
On Sun, Jan 30, 2011 at 02:17:11PM +0200, Gleb Natapov wrote: > WHQL complains otherwise. > > Signed-off-by: Gleb Natapov Can you get this acked by one of the kvm/qemu maintainers? -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabio

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
On Sun, Jan 30, 2011 at 03:01:43PM +0100, Peter Stuge wrote: > Typo in subject. > > Gleb Natapov wrote: > > WHQL complains otherwise. > > Is there something further that should be activated, to actually > allow the wakeup to work? Hm, isn't S4 hibernate? > > Not in a bios. Qemu currently exits

Re: [SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Peter Stuge
Typo in subject. Gleb Natapov wrote: > WHQL complains otherwise. Is there something further that should be activated, to actually allow the wakeup to work? Hm, isn't S4 hibernate? //Peter ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabio

[SeaBIOS] [PATCH] lest pretend that RTC can be used to wakeup from S4

2011-01-30 Thread Gleb Natapov
WHQL complains otherwise. Signed-off-by: Gleb Natapov diff --git a/src/acpi.c b/src/acpi.c index 18830dc..27a78a8 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -259,8 +259,8 @@ build_fadt(int bdf) fadt->plvl2_lat = cpu_to_le16(0xfff); // C2 state not supported fadt->plvl3_lat = cpu_to_le1