Re: code review request: 6973371: X509Factory should recognize PEM headers

On 08/03/2010 05:10 AM, Sean Mullan wrote: On 7/31/10 9:46 AM, Weijun Wang wrote: Yes, you're correct. I regard "not-working" -> "working" a fix, not a regression. I think I would regard it as underspecified. There's nothing in CertificateFactory.generateCertificate that says it skips non-C

Re: 6653372 code review request

Looks good. Thanks Max On 08/03/2010 03:21 AM, Sean Mullan wrote: Hi Max, Can you review this simple fix? http://cr.openjdk.java.net/~mullan/6653372/webrev.00/ Thanks, Sean

hg: jdk7/tl/langtools: 6973626: test/tools/javac/processing/* tests fail with assertions enabled

Changeset: 6318230cdb82 Author:jjg Date: 2010-08-02 16:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6318230cdb82 6973626: test/tools/javac/processing/* tests fail with assertions enabled Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/processing/JavacP

Re: code review request: 6973371: X509Factory should recognize PEM headers

On 7/31/10 9:46 AM, Weijun Wang wrote: Yes, you're correct. I regard "not-working" -> "working" a fix, not a regression. I think I would regard it as underspecified. There's nothing in CertificateFactory.generateCertificate that says it skips non-Certificate blocks. I suppose one could interp

hg: jdk7/tl/langtools: 6971877: Project Coin: improve semantics of suppressed exceptions in try-with-resources

Changeset: 38e2c23309f1 Author:darcy Date: 2010-08-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/38e2c23309f1 6971877: Project Coin: improve semantics of suppressed exceptions in try-with-resources Reviewed-by: jjb + test/tools/javac/TryWithResources/TwrSupp

6653372 code review request

Hi Max, Can you review this simple fix? http://cr.openjdk.java.net/~mullan/6653372/webrev.00/ Thanks, Sean