code review request, CR 7166885 X509CRLEntryImpl does not handle CRLs with no extension properly

Hi, Please review the fix for a synchronization issue of JSSE. webrev: http://cr.openjdk.java.net./~xuelei/7166885/webrev.00/ Cause of the issue: the extensions filed in a X509 CRL may be empty. For such cases, the X509CRLEntryImpl.getExtensions() should return empty map instead of throwing Null

hg: jdk8/tl/jdk: 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking

Changeset: 5152c832745a Author:khazra Date: 2012-05-09 16:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5152c832745a 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Summary: Set localAddress only when connection is established

hg: jdk8/tl/jdk: 7167362: SecureRandom.init should be converted, amendment to 7084245

Changeset: 6438f1277df6 Author:wetmore Date: 2012-05-09 16:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6438f1277df6 7167362: SecureRandom.init should be converted, amendment to 7084245 Reviewed-by: sherman ! src/share/classes/sun/security/provider/SecureRandom.java

Re: Minor Codereview.

looks good. -Sherman On 5/9/2012 12:46 PM, Brad Wetmore wrote: Sherman, Can you please review: http://cr.openjdk.java.net/~wetmore/7167362/ This is for: 7167362: SecureRandom.init should be converted, amendment to 7084245 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7084245 This is t

Minor Codereview.

Sherman, Can you please review: http://cr.openjdk.java.net/~wetmore/7167362/ This is for: 7167362: SecureRandom.init should be converted, amendment to 7084245 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7084245 This is the bug where there were an instance of exception chaining that go

Re: RFR : 7163470 : Build fails if javax.crypto src files not present.

On 05/09/12 07:03, Seán Coffey wrote: The JDK has historically allowed builds without the javax.crypto package src. Bug fix 7058133 altered the bootclasspath for security library builds. This fix simply allows the builds to continue if javax.crypto package is not present. In such cases we ap

hg: jdk8/tl/jdk: 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE

Changeset: 59121a4c71c6 Author:khazra Date: 2012-05-09 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59121a4c71c6 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE Summary: Insert null argument check in AbstractPreferences.remove() Reviewed-by: dholm

hg: jdk8/tl/jdk: 7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking

Changeset: 5e8caf6984f5 Author:ksrini Date: 2012-05-09 07:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e8caf6984f5 7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking Reviewed-by: alanb, dholmes, ksrini Contributed-by: youd...@linux.vnet.ibm.com ! src/sh

RFR : 7163470 : Build fails if javax.crypto src files not present.

The JDK has historically allowed builds without the javax.crypto package src. Bug fix 7058133 altered the bootclasspath for security library builds. This fix simply allows the builds to continue if javax.crypto package is not present. In such cases we append the jce.jar to bootclasspath. I'v