Changeset: 014c04fd7460
Author:ascarpino
Date: 2013-12-04 17:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/014c04fd7460
8029550: javadoc since tag for recent Hashtable updates
Reviewed-by: mullan
! src/share/classes/java/security/Provider.java
On 12/04/2013 05:46 PM, Bradford Wetmore wrote:
I really don't think formatting changes as part of other approved
changes would be taboo. Joe Darcy has the same opinion. I would
restore, but too late now. I knew I should have got to this email
earlier. :)
Yeah, I wish you had sent earlier s
I really don't think formatting changes as part of other approved
changes would be taboo. Joe Darcy has the same opinion. I would
restore, but too late now. I knew I should have got to this email
earlier. :)
One question, I haven't tried this out, but will the simple @since 8
additions cl
Hi Xuelei,
Can you help to submit this change to repository? I don't have openjdk
account.
Thanks
Kevin
On 2013/12/4 15:41, Xuelei Fan wrote:
Looks fine to me.
Xuelei
On 12/4/2013 3:24 PM, zaiyao liu wrote:
Hi Xuelei,
I have updated, please
review:http://cr.openjdk.java.net/~ewang/kevin/
Changeset: 4a2ed1900428
Author:mchung
Date: 2013-12-04 15:39 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a2ed1900428
8029216: (jdeps) Provide a specific option to report JDK internal APIs
Reviewed-by: alanb
! src/share/classes/com/sun/tools/jdeps/JdepsTask.java
! s
Changeset: 4345e3e82c55
Author:mchung
Date: 2013-12-04 13:35 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4345e3e82c55
8029552: Remove java/lang/management/MemoryMXBean/CollectionUsageThreshold.java
from ProblemList.txt
Reviewed-by: alanb
! test/ProblemList.txt
Just 2 comments on DistributionPointFetcher:
You can eliminate some duplication of code by changing the existing
getCRLs method to just call the new method with a null prevCert parameter.
On lines 659-663, you don't need to add @code tags, that is only for
javadoc comments.
--Sean
On 12/03
Ok.. I've removed the formatting changes and updated the webrev in-place.
Tony
On 12/04/2013 11:52 AM, Sean Mullan wrote:
Looks ok to me. I'm not really sure if code formatting changes are
considered a docs change though, I think this is stretching the
definition, so I would probably just make
Looks ok to me. I'm not really sure if code formatting changes are
considered a docs change though, I think this is stretching the
definition, so I would probably just make the @since changes.
--Sean
On 12/04/2013 02:14 PM, Anthony Scarpino wrote:
Hi,
I need a quick review of the below. The
Changeset: 6a5a54193118
Author:mfang
Date: 2013-12-04 09:29 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a5a54193118
8027244: Need to translate new error message and usage information for jar tool
Reviewed-by: naoto, yhuang
! src/share/classes/sun/tools/jar/resources/jar_
Hi,
I need a quick review of the below. The changes reflect comments that
Brad made about javadoc @since tags not being inherited from the new
methods, additionally some formatting changes. No code changes were made
8029550 javadoc since tag and formatting updates for recent Hashtable
upda
Changeset: 6deabb82f72b
Author:ascarpino
Date: 2013-12-04 10:59 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6deabb82f72b
8027218: TEST_BUG: sun/security/pkcs11/ec tests fail because of ever-changing
key size restrictions
Reviewed-by: vinnie
! test/sun/security/pkcs11/PKC
Changeset: a3b804e3d5f7
Author:mchung
Date: 2013-12-04 09:26 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3b804e3d5f7
7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java
hanging intermittently
Reviewed-by: mchung
Contributed-by: yiming.w...@oracl
Your test changes look good.
Thanks.
On 3 Dec 2013, at 22:26, Anthony Scarpino wrote:
> Hi,
>
> I need a review of the below test bug fix:
>
> 8027218: TEST_BUG: sun/security/pkcs11/ec tests fail because of ever-changing
> key size restrictions
>
> http://cr.openjdk.java.net/~ascarpino/8027
Changeset: 2a6611ebfb6c
Author:smarks
Date: 2013-12-04 18:02 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a6611ebfb6c
8029141: Add @FunctionalInterface annotation to Callable interface
Reviewed-by: chegar, alanb
! src/share/classes/java/util/concurrent/Callable.java
Changeset: c009462c1e92
Author:erikj
Date: 2013-12-04 12:45 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/c009462c1e92
8027963: Create unlimited policy jars.
Reviewed-by: wetmore, ihse
! common/autoconf/spec.gmk.in
Changeset: 0f1332dd805c
Author:coffeys
Date: 2013-12-04 17:03 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1332dd805c
8029347: sun/rmi/runtime/Log/checkLogging/CheckLogging.java fails in nightly
intermittently
Reviewed-by: alanb
! test/sun/rmi/runtime/Log/checkLogging/C
Changeset: 6d583b9d99e1
Author:henryjen
Date: 2013-12-04 08:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d583b9d99e1
8029434: Spliterator of Stream returned by BufferedReader.lines() should have
NONNULL characteristic
Reviewed-by: mduigou
! src/share/classes/java/io/B
Changeset: e0b4483668a7
Author:jlaskey
Date: 2013-11-26 11:58 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e0b4483668a7
8029173: Debugger support doesn't handle ConsString
Reviewed-by: lagergren, hannesw, sundar
Contributed-by: james.las...@oracle.com
! src/jdk/nashorn
Changeset: e984e2871bf7
Author:jfranck
Date: 2013-12-04 11:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e984e2871bf7
8029117: (reflect) clarify javadoc for getMethod(...) and getMethods()
Reviewed-by: darcy
! src/share/classes/java/lang/Class.java
Changeset: 2aa455506c49
Author:psandoz
Date: 2013-12-04 10:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2aa455506c49
8029164: Race condition in CompletableFuture.thenCompose with asynchronous task
Reviewed-by: dl, chegar, mduigou
! src/share/classes/java/util/concurrent
Changeset: aed9ca4d33ec
Author:joehw
Date: 2013-12-04 00:17 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/aed9ca4d33ec
8027973: Error in the documentation for newFactory method of the
javax.xml.stream factories
Reviewed-by: alanb, dfuchs, lancea, rriggs
! src/javax/xml/st
Changeset: d30f49aa2d01
Author:sla
Date: 2013-12-03 17:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d30f49aa2d01
6461635: [TESTBUG] BasicTests.sh test fails intermittently
Summary: Transform dummy class instead of BigInteger to avoid complication by
-Xshare. Ported from
Changeset: 6b37ae056340
Author:cl
Date: 2013-11-28 08:23 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6b37ae056340
Added tag jdk8-b118 for changeset e4e5069250e7
! .hgtags
Changeset: 69a930376c70
Author:lana
Date: 2013-12-03 10:46 -0800
URL: http://hg.open
Changeset: 5029f982dfae
Author:cl
Date: 2013-11-28 08:22 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5029f982dfae
Added tag jdk8-b118 for changeset d6820a414f18
! .hgtags
Changeset: 379fc7609beb
Author:lana
Date: 2013-12-03 10:46 -0800
URL: http://hg.ope
25 matches
Mail list logo