Hi Vincent,
I fixed the typo and added a remark to the first line of the bug text.
Best regards,
Goetz.
> -Original Message-
> From: Vincent Ryan [mailto:vincent.x.r...@oracle.com]
> Sent: Mittwoch, 30. November 2016 17:10
> To: Lindenmaier, Goetz
> Cc:
Hi ,
Would you help to review the path for "8157529:Remove intermittent key
from javax/net/ssl/DTLS/CipherSuite.java" , the intermittently failed
issue was fixed by JDK-8167680 , '@key intermittent ' can be removed.Thanks.
JBS: https://bugs.openjdk.java.net/browse/JDK-8157529
webrev:
I've updated to:
* @run main/othervm CryptoPolicyFallback
I'll have a new review out shortly.
Brad
On 11/23/2016 2:29 AM, Wang Weijun wrote:
Hi Brad
I think I found a problem with the test. Before you set your local
java.security file, the system java.security file was already read (in
Hi Goetz,
DataBufferNative.c
Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer.
75 lockInfo.resBase = NULL;
Did you actually compile this ? The variable is called "rasBase", not
"resBase".
And strictly there is no problem since inside DBN_GetPixelPointer
Hi Goetz,
I have some small remarks.
src/java.desktop/unix/native/common/awt/fontpath.c:
247 fontDirPath[sizeof(fontDirPath)-1] = '\0';
-> you should add spaces left and right of '-'
248 strncat(fontDirPath, "/fonts.dir", sizeof(fontDirPath) -
strlen(fontDirPath));
-> I
cc 2d-dev.
On 30.11.16 18:41, Lindenmaier, Goetz wrote:
Hi Vincent,
thanks for the quit review!
Good catch that I lost the change to p11_mutex.c ... I had to change
it and it fell out of my patches.
I edited the Last Modified Date, and also updated the copyright messages.
New webrev:
Hi Vincent,
thanks for the quit review!
Good catch that I lost the change to p11_mutex.c ... I had to change
it and it fell out of my patches.
I edited the Last Modified Date, and also updated the copyright messages.
New webrev:
http://cr.openjdk.java.net/~goetz/wr16/8170525-awt-dev/
Best
Hi,
I'd like to propose a row of smaller fixes where code is noted down a bit
questionable.
SAP's quality process requires that we fix these in our internal delivery, and I
Would like to share my fixes with openJdk. Some of these fixes are of more
theoretical nature as how I understand the code
Change looks fine.
One nit: the extra space at the beginning of line 24 looks strange.
Thanks
Max
On 11/30/2016 5:27 PM, Sibabrata Sahoo wrote:
Hi,
Please review the patch for,
JBS: https://bugs.openjdk.java.net/browse/JDK-8170247
Webrev: