hg: jdk7/tl/jdk: 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-04-13 Thread chris . hegarty
Changeset: 1672f0212f02 Author:chegar Date: 2010-04-13 12:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1672f0212f02 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String Reviewed-by: alanb, michaelm, andrew ! src/sh

Code Review 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux

2010-04-15 Thread Chris Hegarty
Hi Andrew, These tests have canned certs with 'localhost' as a subject alternative name in the client certificate. This fails client authentication on the accepted server socket if the platform returns anything other than 'localhost' for the remote address. This can happen on Linux which typi

hg: jdk7/tl/jdk: 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux

2010-04-15 Thread chris . hegarty
Changeset: ed61accf772e Author:chegar Date: 2010-04-15 16:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ed61accf772e 6943219: test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java fail in linux Reviewed-by: andrew ! test/sun/security/s

Re: [security-dev 01563]: Subject lines in security-dev.

2010-04-20 Thread Chris Hegarty
Brad, Sorry to chime in late, but would it make server side rules/filtering simpler if we added the mailing list name in the subject line? The reason I ask is that since moving to a new mail server I can no longer create filters on the 'sender' ( or any other more exotic ) headers. This make

Re: code review request: 6856069 PrincipalName.clone() does not invoke super.clone()

2010-04-21 Thread Chris Hegarty
Max, Good catch to find this bug! Some comments: 1) I don't get why salt now becomes transient. I don't see that it has any effect on how the object is cloned and class is not Serializable. 2) You should be able to remove L128 in the new file. The cloned object will have same value for na

Re: code review request: 6856069 PrincipalName.clone() does not invoke super.clone()

2010-04-21 Thread Chris Hegarty
On 21/04/2010 12:24, Weijun Wang wrote: On Apr 21, 2010, at 6:53 PM, Chris Hegarty wrote: Max, Good catch to find this bug! Some comments: 1) I don't get why salt now becomes transient. I don't see that it has any effect on how the object is cloned and class is not Se

hg: jdk7/tl/jdk: 6718504: IN6_IS_ADDR_ANY tests only 12 bytes of 16-byte address

2010-04-27 Thread chris . hegarty
Changeset: 0c27202d66c1 Author:chegar Date: 2010-04-27 09:42 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0c27202d66c1 6718504: IN6_IS_ADDR_ANY tests only 12 bytes of 16-byte address Reviewed-by: alanb ! src/windows/native/java/net/net_util_md.h + test/java/net/DatagramSoc

hg: jdk7/tl/jdk: 6886723: light weight http server doesn't return correct status code for HEAD requests

2010-05-05 Thread chris . hegarty
Changeset: 5dfa4f0429d8 Author:chegar Date: 2010-05-05 13:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5dfa4f0429d8 6886723: light weight http server doesn't return correct status code for HEAD requests Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/Excha

hg: jdk7/tl/jdk: 6946825: com.sun.net.httpserver.HttpServer; Memory Leak on Non HTTP conform open socket

2010-05-06 Thread chris . hegarty
Changeset: 0bda20126372 Author:chegar Date: 2010-05-06 17:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bda20126372 6946825: com.sun.net.httpserver.HttpServer; Memory Leak on Non HTTP conform open socket Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/Serv

hg: jdk7/tl/jdk: 6947917: Error in basic authentication when user name and password are long

2010-05-07 Thread chris . hegarty
Changeset: a6928350e1f2 Author:chegar Date: 2010-05-07 10:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a6928350e1f2 6947917: Error in basic authentication when user name and password are long Reviewed-by: weijun ! src/share/classes/sun/net/www/protocol/http/BasicAuthent

hg: jdk7/tl/jdk: 6946673: DatagramSocket.connect() documentation contradicts the implementation

2010-05-07 Thread chris . hegarty
Changeset: 4fba3512c566 Author:chegar Date: 2010-05-07 16:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4fba3512c566 6946673: DatagramSocket.connect() documentation contradicts the implementation Reviewed-by: alanb ! src/share/classes/java/net/DatagramSocket.java

hg: jdk7/tl/jdk: 6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail after rebranding

2010-06-08 Thread chris . hegarty
Changeset: 489c1720757b Author:chegar Date: 2010-06-08 10:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/489c1720757b 6957375: java/net/ResponseCache getResponseCode and ResponseCacheTest fail after rebranding Reviewed-by: ohair, wetmore, alanb ! test/java/net/ResponseCa

hg: jdk7/tl/jdk: 2 new changesets

2010-06-28 Thread chris . hegarty
Changeset: 6d274503d1b7 Author:chegar Date: 2010-06-28 14:55 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6d274503d1b7 6954525: Testcase failure java/net/Authenticator/B4769350.java Reviewed-by: michaelm, weijun ! src/share/classes/sun/net/www/protocol/http/HttpURLConnecti

hg: jdk7/tl/jdk: 6961029: java/net/BindException/Test.java should not use wildcard address

2010-06-28 Thread chris . hegarty
Changeset: 7c3da1f0e17c Author:chegar Date: 2010-06-28 20:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c3da1f0e17c 6961029: java/net/BindException/Test.java should not use wildcard address Reviewed-by: michaelm, alanb ! test/ProblemList.txt ! test/java/net/BindExceptio

hg: jdk7/tl/jdk: 3 new changesets

2010-07-12 Thread chris . hegarty
Changeset: a7f8f269f741 Author:chegar Date: 2010-07-12 18:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a7f8f269f741 6967937: Scope id no longer being set after 6931566 Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/NetworkInterface.c ! test/java/net/Inet6A

Re: code review request: 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException

2010-07-13 Thread Chris Hegarty
This change looks fine. -Chris. On 07/13/10 12:36, Weijun Wang wrote: 6670889: Keystore created under Hindi Locale causing ArrayIndexOutOfBoundsException Webrev: http://cr.openjdk.java.net/~weijun/6670889/webrev.00/ Thanks Max

hg: jdk7/tl/jdk: 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-21 Thread chris . hegarty
Changeset: 58f325ba3e27 Author:chegar Date: 2010-07-21 13:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58f325ba3e27 6969395: TEST_BUG: Tests in java/net sun/net problems Reviewed-by: alanb ! test/ProblemList.txt ! test/com/sun/net/httpserver/Test1.java ! test/com/sun/ne

hg: jdk7/tl/jdk: 6970262: TEST_BUG: test/java/net/NetworkInterface/IPv4Only.java has wrong test name in @run tag

2010-07-21 Thread chris . hegarty
Changeset: f90999d7c404 Author:chegar Date: 2010-07-21 13:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f90999d7c404 6970262: TEST_BUG: test/java/net/NetworkInterface/IPv4Only.java has wrong test name in @run tag Reviewed-by: alanb, dsamersoff ! test/java/net/NetworkInt

hg: jdk7/tl/jdk: 2 new changesets

2010-07-29 Thread chris . hegarty
Changeset: a8a79f5b669e Author:chegar Date: 2010-07-29 10:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8a79f5b669e 6972374: NetworkInterface.getNetworkInterfaces throws "java.net.SocketException" on Solaris zone Reviewed-by: alanb, dsamersoff ! src/solaris/native/java

hg: jdk7/tl/jdk: 6973030: NTLM proxy authentication fails with https

2010-08-03 Thread chris . hegarty
Changeset: 367b90ed38b1 Author:chegar Date: 2010-08-03 12:03 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/367b90ed38b1 6973030: NTLM proxy authentication fails with https Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/sun

hg: jdk7/tl/jdk: 6882910: Unexplained lack of IP4 network ability when transparent IP6 to IP4 is disabled.

2010-08-10 Thread chris . hegarty
Changeset: 1f996198877b Author:chegar Date: 2010-08-10 17:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f996198877b 6882910: Unexplained lack of IP4 network ability when transparent IP6 to IP4 is disabled. Reviewed-by: alanb ! src/solaris/native/java/net/PlainDatagramS

hg: jdk7/tl/jdk: 6968584: Thread should not be Cloneable

2010-08-23 Thread chris . hegarty
Changeset: fd28003bc1d6 Author:chegar Date: 2010-08-23 14:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd28003bc1d6 6968584: Thread should not be Cloneable Reviewed-by: dholmes ! src/share/classes/java/lang/Thread.java

hg: jdk7/tl/jdk: 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-23 Thread chris . hegarty
Changeset: 03218163f4d5 Author:chegar Date: 2010-08-23 16:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03218163f4d5 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe Reviewed-by: michaelm ! src/share/classes/java/net/HttpCookie.java

hg: jdk7/tl/jdk: 6977851: NPE from FileURLConnection.connect

2010-08-23 Thread chris . hegarty
Changeset: cb67f0263bd4 Author:chegar Date: 2010-08-23 21:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb67f0263bd4 6977851: NPE from FileURLConnection.connect Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/file/FileURLConnection.java + test/sun/net/www/

hg: jdk8/tl/jdk: 8005696: Add CompletableFuture

2013-04-09 Thread chris . hegarty
Changeset: 50bc8e085a09 Author:chegar Date: 2013-04-09 17:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50bc8e085a09 8005696: Add CompletableFuture Reviewed-by: chegar, martin ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/CompletableFuture.java

hg: jdk8/tl/jdk: 8008118: (process) Possible null pointer dereference in jdk/src/solaris/native/java/lang/UNIXProcess_md.c

2013-04-13 Thread chris . hegarty
Changeset: 0111bab8dc35 Author:jzavgren Date: 2013-04-11 12:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0111bab8dc35 8008118: (process) Possible null pointer dereference in jdk/src/solaris/native/java/lang/UNIXProcess_md.c Summary: Modified the path processing code so

hg: jdk8/tl/jdk: 8011799: CompletableFuture/Basic.java fails intermittently

2013-04-14 Thread chris . hegarty
Changeset: 5c406a747192 Author:chegar Date: 2013-04-14 19:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c406a747192 8011799: CompletableFuture/Basic.java fails intermittently Reviewed-by: martin, alanb ! test/java/util/concurrent/CompletableFuture/Basic.java

hg: jdk8/tl/jdk: 8012343: Objects.requireNonNull(Object, Supplier) breaks genstubs build

2013-04-16 Thread chris . hegarty
Changeset: 61cfbe08ce5d Author:chegar Date: 2013-04-16 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61cfbe08ce5d 8012343: Objects.requireNonNull(Object,Supplier) breaks genstubs build Reviewed-by: alanb ! src/share/classes/java/util/Objects.java ! test/java/util/Obje

hg: jdk8/tl/jdk: 8012237: CompletableFuture/Basic.java still fails intermittently

2013-04-16 Thread chris . hegarty
Changeset: e2a0e37b152c Author:chegar Date: 2013-04-16 12:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2a0e37b152c 8012237: CompletableFuture/Basic.java still fails intermittently Reviewed-by: martin ! test/java/util/concurrent/CompletableFuture/Basic.java

hg: jdk8/tl/jdk: 8012244: java/net/Socket/asyncClose/Race.java fails intermittently on Windows

2013-04-16 Thread chris . hegarty
Changeset: 6135c60e77e5 Author:chegar Date: 2013-04-16 13:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6135c60e77e5 8012244: java/net/Socket/asyncClose/Race.java fails intermittently on Windows Reviewed-by: alanb, dsamersoff ! src/windows/classes/java/net/DualStackPlain

hg: jdk8/tl/hotspot: 2 new changesets

2013-04-16 Thread chris . hegarty
Changeset: 3d641132f83b Author:twisti Date: 2013-02-26 16:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3d641132f83b 8004336: Better handling of method handle intrinsic frames Reviewed-by: kvn, jrose, ahgross ! src/share/vm/opto/library_call.cpp Changeset: 124ca2243

hg: jdk8/tl/jaxp: 2 new changesets

2013-04-16 Thread chris . hegarty
Changeset: 10db50a26b39 Author:joehw Date: 2013-02-18 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/10db50a26b39 6657673: Issues with JAXP Reviewed-by: alanb, lancea, ahgross, mullan ! src/com/sun/org/apache/bcel/internal/classfile/JavaClass.java ! src/com/sun/org/ap

hg: jdk8/tl/jdk: 37 new changesets

2013-04-16 Thread chris . hegarty
Changeset: c5ead5aa2e13 Author:bae Date: 2013-02-07 19:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5ead5aa2e13 8007014: Improve image handling Reviewed-by: prr, mschoene, jgodinez ! src/share/classes/sun/awt/image/ByteComponentRaster.java ! src/share/classes/sun/awt/i

hg: jdk8/tl/jdk: 8010505: HTTP DIGEST implementation incorrectly quotes header values, fails auth

2013-04-19 Thread chris . hegarty
Changeset: 90b03f9a2e77 Author:jzavgren Date: 2013-04-17 11:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90b03f9a2e77 8010505: HTTP DIGEST implementation incorrectly quotes header values, fails auth Summary: The extraneous quotes were removed. Reviewed-by: chegar ! src/

hg: jdk8/tl/jdk: 2 new changesets

2013-04-29 Thread chris . hegarty
Changeset: 9d324d667bb3 Author:jzavgren Date: 2013-04-29 08:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d324d667bb3 8012108: Memory leak in jdk/src/windows/native/java/net/NetworkInterface_winXP.c Summary: Modified code to fix this leak and then proactively fixed impro

hg: jdk8/tl/jdk: 8007373: Inet6Address serialization incompatibility

2013-04-30 Thread chris . hegarty
Changeset: 49d6596100db Author:msheppar Date: 2013-04-29 23:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49d6596100db 8007373: Inet6Address serialization incompatibility Reviewed-by: alanb, chegar ! src/share/classes/java/net/Inet6Address.java + test/java/net/Inet6Addre

hg: jdk8/tl/jdk: 6594296: NetworkInterface.getHardwareAddress returns zero length byte array

2013-05-01 Thread chris . hegarty
Changeset: 17cf61ff Author:chegar Date: 2013-05-01 10:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17cf61ff 6594296: NetworkInterface.getHardwareAddress returns zero length byte array Reviewed-by: alanb ! src/windows/native/java/net/NetworkInterface_winXP.c ! te

hg: jdk8/tl/jdk: 2 new changesets

2013-05-01 Thread chris . hegarty
Changeset: 73793f2af80a Author:msheppar Date: 2013-04-30 16:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73793f2af80a 8007799: Base64.getEncoder(0, byte[]) returns an encoder that unexpectedly inserts line separators Reviewed-by: sherman, iris ! src/share/classes/java/

hg: jdk8/tl/jdk: 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up

2013-05-16 Thread chris . hegarty
Changeset: bb01cc14223c Author:ewang Date: 2013-05-16 10:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb01cc14223c 8004177: test/java/lang/Thread/GenerifyStackTraces.java doesn't clean-up Reviewed-by: alanb, dholmes, chegar ! test/java/lang/Thread/GenerifyStackTraces.ja

hg: jdk8/tl/jdk: 2 new changesets

2013-05-17 Thread chris . hegarty
Changeset: 3981ad7ec458 Author:chegar Date: 2013-05-17 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3981ad7ec458 8014791: More ProblemList.txt updates (5/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: fab0e4b682e8 Author:chegar Date: 2013-05-17

hg: jdk8/tl/jdk: 2 new changesets

2013-05-17 Thread chris . hegarty
Changeset: 222da3d4692a Author:chegar Date: 2013-05-17 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/222da3d4692a 8014783: java/net/HttpURLPermission/HttpURLPermissionTest.java leaves files open Reviewed-by: michaelm ! test/java/net/HttpURLPermission/HttpURLPermission

hg: jdk8/tl/jdk: 8014076: Arrays parallel and serial sorting improvements

2013-05-23 Thread chris . hegarty
Changeset: 3b23e3529ab3 Author:dl Date: 2013-05-23 18:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b23e3529ab3 8014076: Arrays parallel and serial sorting improvements Reviewed-by: chegar, mduigou ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/

hg: jdk8/tl/jdk: 2 new changesets

2013-05-27 Thread chris . hegarty
Changeset: a2dc42667df3 Author:chegar Date: 2013-05-27 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2dc42667df3 8015439: Minor/sync/cleanup of ConcurrentHashMap Reviewed-by: chegar Contributed-by: Doug Lea , Chris Hegarty ! src/share/classes/java/util/concurrent

hg: jdk8/tl/jdk: 8015299: Memory leak in jdk/src/solaris/bin/java_md_solinux.c

2013-05-30 Thread chris . hegarty
Changeset: 6df9b071b04d Author:jzavgren Date: 2013-05-30 12:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6df9b071b04d 8015299: Memory leak in jdk/src/solaris/bin/java_md_solinux.c Reviewed-by: martin, dholmes, chegar, ksrini ! src/solaris/bin/java_md_solinux.c

Re: RFR JDK-8003245

2013-05-30 Thread Chris Hegarty
[cc'ing security-dev since this change is in their area] John, http://cr.openjdk.java.net/~jzavgren/8003245/webrev.01/ The changes in your above webrev look fine to me. I can sponsor this for you, unless someone from the security area wants to, or even additional reviews. -Chris. On 03/27

hg: jdk8/tl/jdk: 7107883: getNetworkPrefixLength() does not return correct prefix length

2013-05-31 Thread chris . hegarty
Changeset: dcf42861b5b1 Author:chegar Date: 2013-05-31 09:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcf42861b5b1 7107883: getNetworkPrefixLength() does not return correct prefix length Reviewed-by: alanb, michaelm ! src/solaris/native/java/net/NetworkInterface.c ! te

hg: jdk8/tl/jdk: 8005704: Update ConcurrentHashMap to v8

2013-06-04 Thread chris . hegarty
Changeset: d6401129327e Author:dl Date: 2013-06-04 21:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6401129327e 8005704: Update ConcurrentHashMap to v8 Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java

hg: jdk8/tl/jdk: 8011719: Properties.loadFromXML fails with a chunked HTTP connection

2013-06-05 Thread chris . hegarty
Changeset: 5edcc8ca4146 Author:chegar Date: 2013-06-05 16:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5edcc8ca4146 8011719: Properties.loadFromXML fails with a chunked HTTP connection Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection

hg: jdk8/tl/jdk: 8015963: Add at since tags to new ConcurrentHashMap methods

2013-06-05 Thread chris . hegarty
Changeset: c1af6b5a979a Author:chegar Date: 2013-06-05 16:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1af6b5a979a 8015963: Add at since tags to new ConcurrentHashMap methods Reviewed-by: shade, martin ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java

hg: jdk8/tl/jaxws: 8013021: Rebase 8005432 & 8003542 against the latest jdk8/jaxws; ...

2013-06-12 Thread chris . hegarty
Changeset: 8f2986ff0235 Author:mkos Date: 2013-06-12 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8f2986ff0235 8013021: Rebase 8005432 & 8003542 against the latest jdk8/jaxws 8003542: Improve processing of MTOM attachments 8005432: Update access to JAX-WS Reviewed-b

Re: RFR JDK-8014307

2013-06-13 Thread Chris Hegarty
Looks ok to me John. -Chris. On 06/13/2013 01:35 PM, John Zavgren wrote: All: Please give this change one more consideration. Thanks! John Original Message Subject:Re: Re: RFR JDK-8014307 Date: Fri, 24 May 2013 15:56:11 -0400 From: John Zavgren To: Security

hg: jdk8/tl/jdk: 7181748: java/lang/ThreadGroup/Suspend.java test fails intermittently

2013-06-13 Thread chris . hegarty
Changeset: f3609297a868 Author:igerasim Date: 2013-06-13 15:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3609297a868 7181748: java/lang/ThreadGroup/Suspend.java test fails intermittently Reviewed-by: chegar, dholmes ! test/java/lang/ThreadGroup/Suspend.java

hg: jdk8/tl/jdk: 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level)

2013-06-17 Thread chris . hegarty
Changeset: adf70cb48ce0 Author:chegar Date: 2013-06-17 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adf70cb48ce0 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level) Reviewed-by: darcy ! src/macosx/classes/sun/lwawt/LWComponentPeer.java

hg: jdk8/tl/hotspot: 11 new changesets

2013-06-18 Thread chris . hegarty
Changeset: f75faf51e8c4 Author:hseigel Date: 2013-03-07 11:49 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f75faf51e8c4 7158805: Better rewriting of nested subroutine calls Reviewed-by: mschoene, coleenp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/alloca

hg: jdk8/tl/jaxp: 9 new changesets

2013-06-18 Thread chris . hegarty
Changeset: f14f72174f00 Author:chegar Date: 2013-04-24 10:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f14f72174f00 Merge Changeset: b225607e056b Author:chegar Date: 2013-04-28 08:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b225607e056b M

hg: jdk8/tl/corba: 9 new changesets

2013-06-18 Thread chris . hegarty
Changeset: 39d15bbb5741 Author:coffeys Date: 2013-04-08 23:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/39d15bbb5741 8001032: Restrict object access Summary: Restrict object access; fix reviewed also by Alexander Fomin Reviewed-by: alanb, ahgross ! make/com/sun/corba/

hg: jdk8/tl/nashorn: 9 new changesets

2013-06-18 Thread chris . hegarty
Changeset: af8a98ea83d4 Author:chegar Date: 2013-04-24 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/af8a98ea83d4 Merge Changeset: 2237e2ff3685 Author:chegar Date: 2013-04-28 08:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2237e2ff3

hg: jdk8/tl/langtools: 14 new changesets

2013-06-18 Thread chris . hegarty
Changeset: 4d4818b6df72 Author:chegar Date: 2013-04-24 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d4818b6df72 Merge Changeset: 27cda5134748 Author:chegar Date: 2013-04-28 08:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27cda

hg: jdk8/tl/jdk: 2 new changesets

2013-06-19 Thread chris . hegarty
Changeset: 22337da71eca Author:chegar Date: 2013-06-19 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22337da71eca 8017044: anti-delta fix for 8015402 Reviewed-by: alanb ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/j

hg: jdk8/tl/langtools: 2 new changesets

2013-06-19 Thread chris . hegarty
Changeset: be62183f938a Author:chegar Date: 2013-06-19 11:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be62183f938a 8017045: anti-delta fix for 8013789 Reviewed-by: alanb ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/jav

hg: jdk8/tl/jdk: 6 new changesets

2013-06-19 Thread chris . hegarty
Changeset: e7ece2dbdc70 Author:sla Date: 2013-06-10 11:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7ece2dbdc70 8005008: Add Java Flight Recorder Phase II Reviewed-by: erikj Contributed-by: Karen Kinnear , Bengt Rutisson , Calvin Cheung , Erik Gahlin , Erik Helin , Je

hg: jdk8/tl/hotspot: 5 new changesets

2013-06-19 Thread chris . hegarty
Changeset: d0add7016434 Author:amurillo Date: 2013-06-07 09:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0add7016434 8016078: new hotspot build - hs25-b37 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f2110083203d Author:sla Date: 2013-06-10 11:3

hg: jdk8/tl/jdk: 8014499: MulticastSocket should enable IP_MULTICAST_ALL (lnx)

2013-06-20 Thread chris . hegarty
Changeset: bf2bacf934d1 Author:chegar Date: 2013-06-20 18:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf2bacf934d1 8014499: MulticastSocket should enable IP_MULTICAST_ALL (lnx) Reviewed-by: alanb, chegar Contributed-by: John Zavgren , Chris Hegarty ! src/solaris

hg: jdk8/tl/jdk: 7157360: HttpURLConnection: HTTP method DELETE doesn't support output

2013-06-22 Thread chris . hegarty
Changeset: fd050ba1cf72 Author:arieber Date: 2013-06-22 08:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd050ba1cf72 7157360: HttpURLConnection: HTTP method DELETE doesn't support output Reviewed-by: chegar ! src/share/classes/sun/net/www/http/PosterOutputStream.java !

hg: jdk8/tl/jdk: 8017271: Crash may occur in java.net.DualStackPlainSocketImpl::initIDs due to unchecked values returned from JNI functions

2013-06-22 Thread chris . hegarty
Changeset: cb3f3a05eee3 Author:chegar Date: 2013-06-22 08:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb3f3a05eee3 8017271: Crash may occur in java.net.DualStackPlainSocketImpl::initIDs due to unchecked values returned from JNI functions Reviewed-by: alanb, khazra ! s

hg: jdk8/tl/jdk: 8014233: java.lang.Thread should have @Contended on TLR fields

2013-06-25 Thread chris . hegarty
Changeset: ac61efd8c593 Author:shade Date: 2013-06-25 20:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac61efd8c593 8014233: java.lang.Thread should have @Contended on TLR fields Summary: add the @Contended over three TLR fields. Reviewed-by: psandoz, chegar, dholmes, dl

hg: jdk8/tl/jdk: 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum)

2013-06-26 Thread chris . hegarty
Changeset: e83cdd58f1cf Author:chegar Date: 2013-06-26 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83cdd58f1cf 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum) Reviewed-by: chegar, alanb, psandoz Contributed-by: Doug Lea , Tristan Yan , Chris

Re: Review Request: JDK-8019227: JDK-8010325 broke the old build

2013-06-27 Thread Chris Hegarty
On 27/06/2013 07:13, Alan Bateman wrote: On 27/06/2013 05:37, Brad Wetmore wrote: Brent/Alan/Mike, Hashing.java was removed from the JDK workspace, but was not removed from the old java/java/FILES_java.gmk. Things that still depend on the old build (JCE/deploy) are currently broken. http://cr.

hg: jdk8/tl/jdk: 2 new changesets

2013-06-27 Thread chris . hegarty
Changeset: 370e7beff8a0 Author:wetmore Date: 2013-06-27 10:19 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/370e7beff8a0 8019227: JDK-8010325 broke the old build Reviewed-by: alanb, chegar ! make/java/java/FILES_java.gmk Changeset: 4e69a7dfbeac Author:chegar Date:

hg: jdk8/tl/jdk: 4 new changesets

2013-06-28 Thread chris . hegarty
Changeset: 1919c226b427 Author:dl Date: 2013-06-28 12:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1919c226b427 8017739: ReentrantReadWriteLock is confused by the Threads with reused IDs Reviewed-by: chegar ! src/share/classes/java/util/concurrent/locks/ReentrantReadWri

Fwd: Re: TLS and Pre-shared Keys

2013-07-18 Thread Chris Hegarty
Forward to security-dev. Original Message Subject: Re: TLS and Pre-shared Keys Date: Wed, 17 Jul 2013 12:52:59 -0700 From: Matthew Hall To: roger riggs CC: net-...@openjdk.java.net On Wed, Jul 17, 2013 at 03:45:19PM -0400, roger riggs wrote: Hi, Is there support in SSLEngin

hg: jdk8/tl/jdk: 2 new changesets

2013-07-22 Thread chris . hegarty
Changeset: dcd89e60051a Author:khazra Date: 2013-07-22 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dcd89e60051a 8020498: Crash when both libnet.so and libmawt.so are loaded Reviewed-by: chegar, dsamersoff ! src/share/native/java/net/net_util.c Changeset: a3a2889b10

hg: jdk8/tl/jdk: 8021261: ProblemList.txt updates (7/2013)

2013-07-24 Thread chris . hegarty
Changeset: fd1b5adcfdf0 Author:chegar Date: 2013-07-24 22:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd1b5adcfdf0 8021261: ProblemList.txt updates (7/2013) Reviewed-by: alanb, mcimadamore ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8021417: Fix doclint issues in java.util.concurrent

2013-07-25 Thread chris . hegarty
Changeset: 690dcbaa69b7 Author:chegar Date: 2013-07-25 19:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690dcbaa69b7 8021417: Fix doclint issues in java.util.concurrent Reviewed-by: chegar, lancea Contributed-by: Doug Lea ! src/share/classes/java/util/concurrent/Abstrac

hg: jdk8/tl/jdk: 8021421: More doclint fixes in java.net

2013-07-25 Thread chris . hegarty
Changeset: 9cd5159fa870 Author:chegar Date: 2013-07-25 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cd5159fa870 8021421: More doclint fixes in java.net Reviewed-by: lancea, darcy ! src/share/classes/java/net/URI.java

hg: jdk8/tl/jdk: 8020539: Clean up doclint problems in java.util package, part 2

2013-07-31 Thread chris . hegarty
Changeset: 5561b34f6d4c Author:bpb Date: 2013-07-30 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5561b34f6d4c 8020539: Clean up doclint problems in java.util package, part 2 Summary: Clean up doclint errors and warnings in classes in java.util Reviewed-by: darcy, cheg

hg: jdk8/tl/jdk: 8022061: More ProblemList.txt updates (7/2013)

2013-08-01 Thread chris . hegarty
Changeset: c49b538ef054 Author:chegar Date: 2013-08-01 12:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c49b538ef054 8022061: More ProblemList.txt updates (7/2013) Reviewed-by: alanb, psandoz ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8022087: Fix doclint issues in j.u.Deque & Queue

2013-08-01 Thread chris . hegarty
Changeset: cd13a4a45a37 Author:chegar Date: 2013-08-01 16:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd13a4a45a37 8022087: Fix doclint issues in j.u.Deque & Queue Reviewed-by: chegar, darcy Contributed-by: Doug Lea ! src/share/classes/java/util/Deque.java ! src/share

hg: jdk8/tl/jdk: 8022121: Remove superfluous @test tag from SpliteratorTraversingAndSplittingTest

2013-08-02 Thread chris . hegarty
Changeset: 60c275e56a69 Author:chegar Date: 2013-08-02 11:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60c275e56a69 8022121: Remove superfluous @test tag from SpliteratorTraversingAndSplittingTest Reviewed-by: psandoz ! test/java/util/Spliterator/SpliteratorTraversingAn

hg: jdk8/tl/jdk: 8020291: j.u.c.CompletionStage; ...

2013-08-02 Thread chris . hegarty
Changeset: 6ec910ff3ea1 Author:chegar Date: 2013-08-02 14:29 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ec910ff3ea1 8020291: j.u.c.CompletionStage 8020435: CompletableFuture/Basic.java fails on single core machine Reviewed-by: chegar, psandoz Contributed-by: Doug Lea !

Re: Code review request: 8021788: JarInputStream doesn't provide certificates for some file under META-INF

2013-08-06 Thread Chris Hegarty
This looks ok to me Max, but I think it would be good to get a second review on this too. -Chris. On 05/08/2013 02:28, Weijun Wang wrote: Please take a look at http://cr.openjdk.java.net/~weijun/8021788/webrev.00/ The problem is that the method treats no META-INF entry as normal. If we can b

hg: jdk8/tl/jdk: 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java

2013-08-06 Thread chris . hegarty
Changeset: 6773af0dda02 Author:chegar Date: 2013-08-06 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6773af0dda02 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java Reviewed-by: michaelm, alanb ! test/java/net/NetworkInterface/IndexTest.j

hg: jdk8/tl/jdk: 8022661: InetAddress.writeObject() performs flush() on object output stream

2013-08-09 Thread chris . hegarty
Changeset: 84004d0e3fdd Author:chegar Date: 2013-08-09 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/84004d0e3fdd 8022661: InetAddress.writeObject() performs flush() on object output stream Reviewed-by: michaelm, alanb ! src/share/classes/java/net/InetAddress.java

hg: jdk8/tl/jdk: 8022724: lint warnings in j.u.concurrent packages

2013-08-09 Thread chris . hegarty
Changeset: ce1c874903cb Author:dl Date: 2013-08-09 17:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce1c874903cb 8022724: lint warnings in j.u.concurrent packages Reviewed-by: chegar, lancea, darcy ! src/share/classes/java/util/concurrent/CompletableFuture.java ! src/sha

Re: [8] Review Request: 8022897: Add test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java to ProblemList

2013-08-13 Thread Chris Hegarty
Dammit, only seeing this now. I just pushed Amy's ProblemList updates a few minutes ago, could have added this too. Anyway, consider it reviewed. -Chris. On 08/13/2013 02:41 PM, Sean Mullan wrote: Could I get a quick code review on this? Thanks, Sean $ hg diff ProblemList.txt diff -r 5b14d7

hg: jdk8/tl/jdk: 8022779: ProblemList.txt updates (8/2013)

2013-08-13 Thread chris . hegarty
Changeset: 18e15d92610b Author:chegar Date: 2013-08-13 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18e15d92610b 8022779: ProblemList.txt updates (8/2013) Summary: Update ProblemList and remove AggressiveOpts MOAT test run Reviewed-by: chegar, alanb Contributed-by: Am

hg: jdk8/tl/jdk: 8022584: Memory leak in some NetworkInterface methods

2013-08-15 Thread chris . hegarty
Changeset: 7d7d553a8c61 Author:igerasim Date: 2013-08-13 13:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d7d553a8c61 8022584: Memory leak in some NetworkInterface methods Reviewed-by: alanb, dholmes, chegar, michaelm ! src/solaris/native/java/net/NetworkInterface.c + t

hg: jdk8/tl/jdk: 8023103: FJ parallelism zero; ...

2013-08-15 Thread chris . hegarty
Changeset: 3223342fb76e Author:dl Date: 2013-08-15 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3223342fb76e 8023103: FJ parallelism zero 8020537: java/util/concurrent/forkjoin/ThrowingRunnable.java Reviewed-by: chegar, mduigou, alanb ! src/share/classes/java/util/co

hg: jdk8/tl/jdk: 8023104: ConcurrentHashMap typo

2013-08-15 Thread chris . hegarty
Changeset: b07b19182e40 Author:dl Date: 2013-08-15 15:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07b19182e40 8023104: ConcurrentHashMap typo Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java

hg: jdk8/tl/jdk: 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress

2013-08-15 Thread chris . hegarty
Changeset: e7137695dce3 Author:chegar Date: 2013-08-15 15:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7137695dce3 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress Reviewed-by: smarks, alanb, michaelm, darcy ! src/share/c

hg: jdk8/tl: 8021820: Number of opened files used in select() is limited to 1024 [macosx]

2013-08-19 Thread chris . hegarty
Changeset: 00dcfaa6bc01 Author:aefimov Date: 2013-08-16 18:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/00dcfaa6bc01 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks ! common/autoconf/generated-configure.

hg: jdk8/tl/jdk: 8021820: Number of opened files used in select() is limited to 1024 [macosx]

2013-08-19 Thread chris . hegarty
Changeset: 11ccaabdb2a8 Author:aefimov Date: 2013-08-16 18:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11ccaabdb2a8 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks + test/java/net/ServerSocket/Selec

hg: jdk8/tl/jdk: 6470700: Math.random() / Math.initRNG() uses "double checked locking"

2013-08-23 Thread chris . hegarty
Changeset: 223be1d3494f Author:bpb Date: 2013-08-22 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/223be1d3494f 6470700: Math.random() / Math.initRNG() uses "double checked locking" Summary: Replace class Random variable with a static final holder class Reviewed-by: ala

hg: jdk8/tl/jaxws: 8022885: Update JAX-WS RI integration to 2.2.9-b14140; ...

2013-08-23 Thread chris . hegarty
Changeset: b99d7e355d4b Author:mkos Date: 2013-08-23 09:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b99d7e355d4b 8022885: Update JAX-WS RI integration to 2.2.9-b14140 8013016: Rebase 8009009 against the latest jdk8/jaxws Reviewed-by: alanb, chegar ! src/share/jaxws_

hg: jdk8/tl/jaxws: 8023636: Missing files from 8022885

2013-08-23 Thread chris . hegarty
Changeset: d8593d8581df Author:mkos Date: 2013-08-23 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d8593d8581df 8023636: Missing files from 8022885 Reviewed-by: alanb, chegar + src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/StreamingSOAP.java + src/sha

Re: [8] Request for review: 8023769: JDK-8016850 broke the old build

2013-08-27 Thread Chris Hegarty
Looks fine Sean. I'll refrain from making the obvious comment on the old build ;-) -Chris. On 27/08/2013 15:01, Sean Mullan wrote: Hi, Could you please review my fix for 8023769: webrev: http://cr.openjdk.java.net/~mullan/webrevs/8023769/webrev.00/ The bug is not yet available on bugs.sun.c

hg: jdk8/tl/jdk: 8024103: AtomicLongArray getAndAccumulate/accumulateAndGet have int type for new value arg

2013-09-02 Thread chris . hegarty
Changeset: 441da45931fa Author:chegar Date: 2013-09-02 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/441da45931fa 8024103: AtomicLongArray getAndAccumulate/accumulateAndGet have int type for new value arg Reviewed-by: alanb, psandoz ! src/share/classes/java/util/conc

hg: jdk8/tl/jdk: 2 new changesets

2013-09-09 Thread chris . hegarty
Changeset: 02064634bc88 Author:msheppar Date: 2013-09-06 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02064634bc88 8023326: [TESTBUG] java/net/CookieHandler/LocalHostCookie.java misplaced try/finally Summary: amended test to be more robust to set of potential excepti

hg: jdk8/tl/jdk: 8024508: Fix doclint issues in com.sun.nio.sctp

2013-09-11 Thread chris . hegarty
Changeset: 517c5e99fb2f Author:chegar Date: 2013-09-11 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/517c5e99fb2f 8024508: Fix doclint issues in com.sun.nio.sctp Reviewed-by: alanb ! src/share/classes/com/sun/nio/sctp/Association.java ! src/share/classes/com/sun/nio/s

hg: jdk8/tl/jdk: 8023090: Additional debug info for java/net/NetworkInterface/Equals.java

2013-09-11 Thread chris . hegarty
Changeset: d389dedd1ccb Author:chegar Date: 2013-09-11 11:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d389dedd1ccb 8023090: Additional debug info for java/net/NetworkInterface/Equals.java Reviewed-by: alanb ! test/java/net/NetworkInterface/Equals.java

  1   2   3   4   5   >