On 2013-02-01 01:34, serguei.spit...@oracle.com wrote:
Stefan,
Looks good.
Agreed with Coleen: do_redefine => doRedefine.
I guess, this name was taken from one of old tests. :)
I'm Ok with two definitions of the interface ParameterAnnotation.
Thanks for the review,
StefanK
Thanks,
Setguei
On 2013-02-01 00:15, Coleen Phillimore wrote:
Stefan,
I just read through this test and it looks like a good test to me (but
I'm not an expert and it took a while to figure out how it worked).
I had two questions. Why does the same definition for @interface
ParameterAnnotation {} appear i
Reviewed but not sponsored (sorry).
David
On 30/01/2013 10:16 PM, Markus Grönlund wrote:
Greetings,
Asking for review and sponsoring of this very simple change:
Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007134
Webrev: http://cr.openjdk.java.net/~mgronlun/8007134/webrev01/
C
On 1/02/2013 4:54 PM, Rickard Bäckman wrote:
That was the idea.
However, can I have Ok for checking this into hs24 while waiting?
Sorry - ignore the hs25 comment - been looking at too many JDK review
requests.
Yes this seems fine for hs24.
David
Thanks
/R
On Jan 21, 2013, at 11:33 PM, Da
Changeset: 17b643956999
Author:chegar
Date: 2013-02-01 06:51 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17b643956999
8006395: Race in async socket close on Linux
Reviewed-by: alanb, dsamersoff
! src/solaris/native/java/net/linux_close.c
+ test/java/net/Socket/asyncClose/
That was the idea.
However, can I have Ok for checking this into hs24 while waiting?
Thanks
/R
On Jan 21, 2013, at 11:33 PM, David Holmes wrote:
> On 22/01/2013 12:09 AM, Rickard Bäckman wrote:
>> Yes, that code has changed. Checked in to hs24.
>
> Okay but this is a review for hs25 ;-) So I as
Hi Staffan,
First, please refrain from doing code cleanup (long line reformatting)
alongside a fairly significant change - it makes the true changes harder
to spot. Thanks.
Based on our discussions this all looks good to me.
Thanks,
David
On 18/01/2013 5:48 AM, Staffan Larsen wrote:
This i
Changeset: 3d97a9a7a82b
Author:jjg
Date: 2013-01-31 19:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d97a9a7a82b
8004353: Generated html is wrong for overview.html; content has incorrect css
footer class
Reviewed-by: jjg
Contributed-by: roger.ri...@oracle.com
! s
Changeset: 3ab64e4293a1
Author:jjg
Date: 2013-01-31 19:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ab64e4293a1
8007329: minor issues in impl class hierarchry for DCTree.* classes
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javac/tree/DCTree.java
Changeset: bec996065c45
Author:darcy
Date: 2013-01-31 18:58 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bec996065c45
8007351: Malformed copyright statements in typeAnnotations test directory
Reviewed-by: jjg
! test/tools/javac/annotations/typeAnnotations/TargetTypes
Stefan,
Looks good.
Agreed with Coleen: do_redefine => doRedefine.
I guess, this name was taken from one of old tests. :)
I'm Ok with two definitions of the interface ParameterAnnotation.
Thanks,
Setguei
On 1/31/13 3:15 PM, Coleen Phillimore wrote:
Stefan,
I just read through this test and
Changeset: d2495b9984fa
Author:weijun
Date: 2013-02-01 07:39 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d2495b9984fa
8006564: Test sun/security/util/Oid/S11N.sh fails with timeout on Linux 32-bit
Reviewed-by: alanb
+ test/sun/security/util/Oid/S11N.java
- test/sun/securi
Stefan,
I just read through this test and it looks like a good test to me (but
I'm not an expert and it took a while to figure out how it worked). I
had two questions. Why does the same definition for @interface
ParameterAnnotation {} appear in both
RedefineMethodWithAnnotationTarget*.jav
Changeset: a09a37cff333
Author:mchung
Date: 2013-01-31 14:29 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a09a37cff333
6355704: (fmt) %f formatting of BigDecimals is incorrect
Reviewed-by: darcy
Contributed-by: brian.burkhal...@oracle.com
! test/java/util/Formatter/Basic-X
Changeset: 89fc17e8d808
Author:katleman
Date: 2013-01-24 16:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/89fc17e8d808
Added tag jdk8-b74 for changeset 1a3e54283c54
! .hgtags
Changeset: d58b7b43031b
Author:amurillo
Date: 2013-01-11 02:02 -0800
URL: ht
Changeset: 54e4ba223319
Author:katleman
Date: 2013-01-24 16:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/54e4ba223319
Added tag jdk8-b74 for changeset 56c97aff46bb
! .hgtags
Changeset: c2e11e2ec4a3
Author:lana
Date: 2013-01-26 19:24 -0800
URL: http
Changeset: d4e68ce17795
Author:katleman
Date: 2013-01-24 16:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d4e68ce17795
Added tag jdk8-b74 for changeset 2132845cf5f7
! .hgtags
Changeset: 69bc57b1ebdd
Author:katleman
Date: 2013-01-24 16:48 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/69bc57b1ebdd
Added tag jdk8-b74 for changeset 2087e24a4357
! .hgtags
Changeset: ff0b73a6b3f6
Author:lana
Date: 2013-01-26 18:25 -0800
URL: http://hg
Changeset: 966bf9f3c41a
Author:katleman
Date: 2013-01-24 16:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/966bf9f3c41a
Added tag jdk8-b74 for changeset 12db3c5a3393
! .hgtags
Changeset: 50307da0149e
Author:jqzuo
Date: 2012-12-31 14:52 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/rev/50307da0149e
8005583: Install build(gnumake all) failed preventing RE from doing JDK8 combo
builds
Reviewed-by: paulk, billyh
! make/install-rules.gmk
Changeset: e5664599
Changeset: cff8d7768d72
Author:mduigou
Date: 2013-01-31 13:27 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cff8d7768d72
8006709: Add minimal support of MacOSX platform for NetBeans Projects
Summary: Adds support for MacOSX platform and architecture detection. Other
minor u
Changeset: e5ce312a5b10
Author:sherman
Date: 2013-01-31 13:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5ce312a5b10
8007298: Base64.getMimeDecoder().decode() throws IAE for a single non-base64
character
8006526: Base64.Decoder.decode(String) spec contains a copy-paste
Changeset: a5f38e811ab0
Author:darcy
Date: 2013-01-31 12:23 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5f38e811ab0
8007115: Refactor regression tests for java.lang.reflect.Parameter
Reviewed-by: emc
! test/java/lang/reflect/Parameter/WithoutParameters.java
Changeset: 8e4c22acebeb
Author:darcy
Date: 2013-01-31 12:16 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e4c22acebeb
8007313: Remove use of {ContainerFor/ContainedBy} from langtools
Reviewed-by: jjg
!
test/tools/javac/annotations/typeAnnotations/classfile/Combinati
Changeset: 278397f752da
Author:darcy
Date: 2013-01-31 12:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/278397f752da
8005832: Remove java.lang.annotation.{ContainedBy, ContainerFor} annotation
types
Reviewed-by: mduigou
- src/share/classes/java/lang/annotation/ContainedB
Serguei,
Thanks
Yumin
On 1/31/2013 11:10 AM, serguei.spit...@oracle.com wrote:
Hi Yumin,
Looks good.
A couple of minor comments.
1. All the copyright comments are outdated.
2.
*
agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java
***
agent/src/share
Hi Yumin,
Looks good.
A couple of minor comments.
1. All the copyright comments are outdated.
2.
*agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java
***agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/x86/WindbgX86Thread.java
**
37 //The address ar
Changeset: 857d99bef21d
Author:sherman
Date: 2013-01-31 11:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/857d99bef21d
8005394: Base64.Decoder/Encoder.wrap(XStream) don't throw NPE for null args
passed
Summary: to check null for dec/enc.wrap methods
Reviewed-by: alanb
!
Changeset: 3f766f58c48a
Author:dbuck
Date: 2013-01-31 10:55 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f766f58c48a
7042126: (alt-rt) HashMap.clone implementation should be re-examined
Summary: Test case for cr7042126. Issue only found in OracleJDK, but test case
is vali
Thanks, Nils
Yumin
On 1/31/2013 12:12 AM, Nils Loodin wrote:
Ah, was just about to take a look a this too!
Looks good and equal to what I had in my workspace :)
/Nisse
On Jan 31, 2013, at 8:16 , Yumin Qi wrote:
Please have your comments on:
http://cr.openjdk.java.net/~minqi/8000973/
This
Changeset: 5097fe015763
Author:jfranck
Date: 2013-01-31 10:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5097fe015763
8005712: Simplify support for repeating annotations in j.l.r.AnnotatedElement
8004919: AnnotationSupport uses possibly half-constructed AnnotationType
in
Ah, was just about to take a look a this too!
Looks good and equal to what I had in my workspace :)
/Nisse
On Jan 31, 2013, at 8:16 , Yumin Qi wrote:
> Please have your comments on:
>
> http://cr.openjdk.java.net/~minqi/8000973/
>
> This only affected Windows platform.
>
> Summary: After bug
32 matches
Mail list logo