Re: RFR: JDK-8187498: Add a -Xmanagement flag as syntactic sugar for -Dcom.sun.management.jmxremote.* properties

2018-01-24 Thread Harsha Wardhana B
Hi Erik, The minimal command line would be, "-Xmanagement", that will start only the local management server. "-Xmanagement:local=true,port=" will start the remote management server without SSL or authentication. On Wednesday 24 January 2018 06:13 PM, Erik Gahlin wrote: Hi Harsha,

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-01-24 Thread David Holmes
Hi Jini, On 25/01/2018 3:43 AM, Jini George wrote: Hello, Requesting reviews for the issue: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes ID: https://bugs.openjdk.java.net/browse/JDK-8175384 Webrev: http://cr.openjdk.java.net/~jgeorge/8175384/webrev.01/

Re: RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-01-24 Thread serguei.spit...@oracle.com
Hi Jini, It looks good to me. Thanks, Serguei On 1/24/18 09:43, Jini George wrote: Hello, Requesting reviews for the issue: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes ID: https://bugs.openjdk.java.net/browse/JDK-8175384 Webrev:

RFR: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes

2018-01-24 Thread Jini George
Hello, Requesting reviews for the issue: SA: clhsdb 'printall' throws ClassCastException while printing out the bytecodes ID: https://bugs.openjdk.java.net/browse/JDK-8175384 Webrev: http://cr.openjdk.java.net/~jgeorge/8175384/webrev.01/ The issue was seen while printing out the details of

Re: RFR: JDK-8187498: Add a -Xmanagement flag as syntactic sugar for -Dcom.sun.management.jmxremote.* properties

2018-01-24 Thread Erik Gahlin
Hi Harsha, Very nice to see progress on this! Before reviewing, the minimal command line to start up the default management server now becomes -Xmanagement:ssl=false,authenticate=false and if you use a property that doesn't exist, or that is mandatory, you will get an error message stating

Re: RFR: JDK-8187498: Add a -Xmanagement flag as syntactic sugar for -Dcom.sun.management.jmxremote.* properties

2018-01-24 Thread Alan Bateman
On 24/01/2018 11:18, Harsha Wardhana B wrote: Hi, Please review the changes for above enhancement having webrev at, http://cr.openjdk.java.net/~hb/8187498/webrev.00/ One of the guidelines in JEP 293 [1] is to not introduce new options with -X as a prefix. I think a related discussion point is

RFR: JDK-8187498: Add a -Xmanagement flag as syntactic sugar for -Dcom.sun.management.jmxremote.* properties

2018-01-24 Thread Harsha Wardhana B
Hi, Please review the changes for above enhancement having webrev at, http://cr.openjdk.java.net/~hb/8187498/webrev.00/ Thanks Harsha