+1
Thanks,
David
On 15/05/2020 6:18 am, serguei.spit...@oracle.com wrote:
Hi Alex,
LGTM.
Thanks,
Serguei
On 5/14/20 11:04, Alex Menkov wrote:
I agree with the point.
updated webrev (only WAITING handling is added):
http://cr.openjdk.java.net/~amenkov/jdk15/Locks_waiting/webrev.2/
--alex
Hi Alex,
LGTM.
Thanks,
Serguei
On 5/14/20 11:04, Alex Menkov wrote:
I agree with the point.
updated webrev (only WAITING handling is added):
http://cr.openjdk.java.net/~amenkov/jdk15/Locks_waiting/webrev.2/
--alex
On 05/13/2020 19:20, David Holmes wrote:
Hi Alex,
On 14/05/2020 10:55 am,
I agree with the point.
updated webrev (only WAITING handling is added):
http://cr.openjdk.java.net/~amenkov/jdk15/Locks_waiting/webrev.2/
--alex
On 05/13/2020 19:20, David Holmes wrote:
Hi Alex,
On 14/05/2020 10:55 am, Alex Menkov wrote:
Hi all,
Please review the fix for
https://bugs.openj
Hi Alex,
It looks good in general.
But I agree with David, the TIMED_WAITING thread state can be escaped by
timeout.
More sophisticated logic is require to track it precisely.
I'd suggest to get rid of the TIMED_WAITING in this condition as it is
never passed to the assertThreadState() as an
Hi Alex,
On 14/05/2020 10:55 am, Alex Menkov wrote:
Hi all,
Please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8229829
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/Locks_waiting/webrev/
The fix adds handling for WAITING
That part is good.
(and for consistency TIMED_WAIT
Looks good to me.
On Wed, May 13, 2020 at 5:55 PM Alex Menkov wrote:
>
> Hi all,
>
> Please review the fix for
> https://bugs.openjdk.java.net/browse/JDK-8229829
> webrev:
> http://cr.openjdk.java.net/~amenkov/jdk15/Locks_waiting/webrev/
>
> The fix adds handling for WAITING (and for consistency
Hi all,
Please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8229829
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/Locks_waiting/webrev/
The fix adds handling for WAITING (and for consistency TIMED_WAITING
which is not used in the test) states as it has for BLOCKED state.
--