Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Fabio Estevam
On 3/26/2012 5:59 PM, Uwe Kleine-König wrote: > In my version of drivers/spi/spi-imx.c struct spi_imx_data is only > defined once. I guess you wanted to say "forward declaration". Yes, correct. ... > Does this really work? struct spi_imx_data has a member Yes, tested it on a mx31pdk board. Re

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Uwe Kleine-König
On Mon, Mar 26, 2012 at 03:13:52PM -0300, Fabio Estevam wrote: > Structure struct spi_imx_data is defined twice. > > Remove one of its definition. In my version of drivers/spi/spi-imx.c struct spi_imx_data is only defined once. I guess you wanted to say "forward declaration". > Signed-off-by: Fab

spi_imx imx31-cspi.0: master is unqueued, this is deprecated

2012-03-26 Thread Fabio Estevam
Hi, On a mx31pdk board (which uses spi-imx driver) I get the following message running linux-next: spi_imx imx31-cspi.1: probed spi_imx imx31-cspi.0: master is unqueued, this is deprecated l4f00242t03 spi0.0: Epson l4f00242t03 lcd probed. spi_imx imx31-cspi.0: probed What is the correct way to q

[PATCH v2] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Fabio Estevam
Structure struct spi_imx_data is defined twice. Remove one of its definition. In order to do so, it is also necessary to move spi_imx_devtype_data structure after the definition of spi_imx_data. Signed-off-by: Fabio Estevam --- Changes since v1: - Explain why I moved spi_imx_devtype_data locat

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Shubhrajyoti Datta
Hi Fabio, On Tue, Mar 27, 2012 at 12:34 AM, Fabio Estevam wrote: > Shubhrajyoti Datta wrote: >> Hi Fabio, >> >> On Mon, Mar 26, 2012 at 11:43 PM, Fabio Estevam >> wrote: >>> Structure struct spi_imx_data is defined twice. >>> >>> Remove one of its definition. >>> >>> Signed-off-by: Fabio Estevam

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Fabio Estevam
Shubhrajyoti Datta wrote: > Hi Fabio, > > On Mon, Mar 26, 2012 at 11:43 PM, Fabio Estevam > wrote: >> Structure struct spi_imx_data is defined twice. >> >> Remove one of its definition. >> >> Signed-off-by: Fabio Estevam >> --- >> drivers/spi/spi-imx.c | 20 +--- >> 1 files ch

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Shubhrajyoti Datta
Hi Fabio, On Mon, Mar 26, 2012 at 11:43 PM, Fabio Estevam wrote: > Structure struct spi_imx_data is defined twice. > > Remove one of its definition. > > Signed-off-by: Fabio Estevam > --- >  drivers/spi/spi-imx.c |   20 +--- >  1 files changed, 9 insertions(+), 11 deletions(-) >

[PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Fabio Estevam
Structure struct spi_imx_data is defined twice. Remove one of its definition. Signed-off-by: Fabio Estevam --- drivers/spi/spi-imx.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 31054e3..f1f6700

[PATCH v2 1/5] spi/omap: Remove bus_num usage for instance index

2012-03-26 Thread Shubhrajyoti D
From: Benoit Cousson bus_num was used to reference the mcspi controller instance in a fixed array. Remove this array and store this information directly inside drvdata structure. bus_num is now just set if the pdev->id is present or with -1 for dynamic allocation by SPI core, but the driver does

[PATCH v2 5/5] spi: omap2-mcspi: add support for pm_runtime autosuspend

2012-03-26 Thread Shubhrajyoti D
Adds support for configuring the omap2-mcspi driver use autosuspend for runtime power management. This can reduce the latency in starting an spi transfer by not suspending the device immediately following completion of a transfer. If another transfer then takes place before the autosuspend timeout

[PATCH v2 4/5] spi: omap2-mcspi: use devm_* functions

2012-03-26 Thread Shubhrajyoti D
The various devm_* functions allocate memory that is released when a driver detaches. This patch uses devm_request_and_ioremap to request memory in probe function. Since the freeing is not needed the calls are deleted from remove function.Also use use devm_kzalloc for the cs memory allocation. Sig

[PATCH v2 2/5] spi: omap2-mcspi: make it behave as a module

2012-03-26 Thread Shubhrajyoti D
From: Felipe Balbi move probe away from __init section and use platform_driver_register() instead of platform_driver_probe(). Signed-off-by: Felipe Balbi Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --

[PATCH 0/5] spi: omap2-mcspi: driver updates

2012-03-26 Thread Shubhrajyoti D
The patch series does the following cleanups - Converts the spi to module_platform_driver - Use the devm functions so that the freeing need not be done in the driver. - Makes the driver use autosuspend - Folds Benoit's bus_num removal patch in the series Changes from the previous version - Make

[PATCH v2 3/5] spi: omap2-mcspi: convert to module_platform_driver

2012-03-26 Thread Shubhrajyoti D
From: Felipe Balbi this will delete a few lines of code, no functional changes. Signed-off-by: Felipe Balbi Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/d

Billets de train à 19 Eur0s seulement, reservez vite

2012-03-26 Thread SNCF avec l'Officiel des vacances
Si vous ne visualisez pas correctement ce message, cliquez ici. L'Officiel-des-vacances.com - La r*f*rence des bons plans vacances [IMG]L'*t* commence maintenant Envie de soleil ? Réservez