Re: [RFC] Time to talk about StringNG merge again?

2013-04-01 Thread Amos Jeffries
On 2/04/2013 6:57 a.m., Alex Rousskov wrote: -- This is not a review, but I wanted to clarify or emphasize some of the points in Amos' review. Thank you Amos for working on this! On 03/30/2013 02:32 AM, Amos Jeffries wrote: in src/SBuf.cc: * SBuf::chop() - the TODO optimization is not possibl

Re: [RFC] Time to talk about StringNG merge again?

2013-04-01 Thread Alex Rousskov
On 04/01/2013 11:43 AM, Kinkie wrote: > Attached is a bundle containing the changes from this review. Will you commit that to your stringng branch on lp? Or should I patch that branch before reviewing/testing instead? Thank you, Alex.

Re: [RFC] Time to talk about StringNG merge again?

2013-04-01 Thread Kinkie
Hi, I forgot to mention another couple of changes: - I added an explicit copy-constructor to import std::string - I relaxed the behavior of the chop() method for out-of-bounds cases: instead of throwing, it'll now ignore the part of the specified limits that is out of bounds. On Mon, Apr 1, 2013

Re: [RFC] Time to talk about StringNG merge again?

2013-04-01 Thread Alex Rousskov
-- This is not a review, but I wanted to clarify or emphasize some of the points in Amos' review. Thank you Amos for working on this! On 03/30/2013 02:32 AM, Amos Jeffries wrote: > in src/SBuf.cc: > > * SBuf::chop() - the TODO optimization is not possible. We cannot be > completely sure we are t

[PATCH] NAT lookups upgrade for FreeBSD and OpenBSD

2013-04-01 Thread Amos Jeffries
Current OpenBSD implementation of PF divert-to works similarly to TPROXY and only requires a getsockname() lookup to locate the TCP packet original destination. The work by Marios with some additional tweaks discovered in recent testing has now gone into 3.HEAD providing Squid with working htt