[sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-02 Thread David Villasmil
- modified pv_parse_hep_name() and pv_get_hep() to expose the HEP's packet source ip address on replies. The associated pv $hep(src_ip), i.e.: onreply_route { ... xlog("[onreply_route] Source IP: $hep(src_ip)\n"); ... } You can view, comment on, or merge this pull request onli

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-02 Thread David Villasmil
@adubovikov I hope this is better. If you find I'm not adhering in any way to guidelines, please point them out as it's my first time contributing. Many thanks! David -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-04 Thread Daniel-Constantin Mierla
miconda commented on this pull request. the declaraton of buf_ip has to be static because you return the pointer to it. Right now it is allocated on the stack and the pointer becomes invalid when the function finishes its execution. It has to be like: ``` static char buf_ip ... ``` Alternative

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-06 Thread David Villasmil
@davidcsi pushed 1 commit. fb6328e sipcapture: Set char buf_ip as static -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/879/files/b8680815fc46c6612de9d41339f5c537d252dbc6..fb6328edcdb9edd06d474e8cd3c10ecf9817e3a

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-06 Thread David Villasmil
Changed "char buf_ip" as static -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-265088845___ sr-dev mailing list sr-dev@li

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-07 Thread Daniel-Constantin Mierla
@adubovikov - is this pull ok to merge? If yes, then let me do it manually this time, because I am going to work on restructuring of the source code tree and don't want to mess it. @davidcsi - for the future pull requests, do not do reformatting (indentation changes, renaming, etc.) in a pull r

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-07 Thread Alexandr Dubovikov
I am ok for this. Of course ideally will be add more "aliases" but it's ok for start! :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-265383852

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-08 Thread David Villasmil
Yes, sorry about those beautifications... vim (spf13 mod) did it automatically.. i'll be more careful in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#issuecomment-

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-09 Thread Daniel-Constantin Mierla
I reworked the patch to use buffered print of ip address in order to avoid the str copy. Test and if any issue is found, open a bug report. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamaili

Re: [sr-dev] [kamailio/kamailio] sipcapture: expose pv $hep(src_ip) (#879)

2016-12-09 Thread Daniel-Constantin Mierla
Closed #879. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/879#event-888072343___ sr-dev mailing list sr-dev@lists.sip-router.org http://