Re: [SR-Users] possible bug with dialog module

2010-04-23 Thread Daniel-Constantin Mierla
Hello, thanks, so the Contact header is missing, that makes the 200ok invalid for invitate - afaik contact is mandatory. Anyhow, crash should not happen, but I wonder what happens with such call, practically the caller does not know where to send the BYE. Or maybe 18x reply has contact hdr an

Re: [SR-Users] possible bug with dialog module

2010-04-23 Thread Daniel-Constantin Mierla
Hello, thanks, so the Contact header is missing, that makes the 200ok invalid for invitate - afaik contact is mandatory. Anyhow, crash should not happen, but I wonder what happens with such call, practically the caller does not know where to send the BYE. Or maybe 18x reply has contact hdr an

Re: [SR-Users] possible bug with dialog module

2010-04-22 Thread Kelvin Chua
these Cisco ATAs are so old, we are maintaining around 300 of these, and a lot of times we encounter corrupted SIP messages of which some are fixed by just reboots, other times, by upgrading firmwares. most of the times, kamailio manages to stay afloat in the midst of all these corruption except f

Re: [SR-Users] possible bug with dialog module

2010-04-22 Thread Kelvin Chua
(gdb) print buf+300 $2 = 0x869fec "65\r\nCall-ID: 0901b21e13a60e0247988caf7d72f...@10.17.0.200\r\ncseq: 102 INVITE\r\nServer: Cisco ATA 186 v3.2.0 atasip (04A)\r\nAllow: ACK, BYE, CANCEL, INVITE, NOTIFY, OPTIONS, REFER, REGISTER, PRACK, U"... (gdb) print buf+400 $1 = 0x86a050 "v3.2.0 atasip (

Re: [SR-Users] possible bug with dialog module

2010-04-22 Thread Timo Reimann
Hey Daniel, Daniel-Constantin Mierla wrote: > thanks for troubleshooting. I committed the patch that moves setting of > bind_addr before any error case in populate_leg_info(). I backported to > kamailio_3.0 branch as well. > > Kelvin, can you get the lasted git version for branch kamailio_3.0 an

Re: [SR-Users] possible bug with dialog module

2010-04-22 Thread Daniel-Constantin Mierla
Hi, if you still have the core file, can you print more of buffer until it gets to end of headers? I am curios to see what is wrong with the contact. Just increase by 100: (gdb) print buf+300 (gdb) print buf+400 ... Thanks, Daniel On 4/21/10 3:15 PM, Kelvin Chua wrote: (gdb) bt #0 0x

Re: [SR-Users] possible bug with dialog module

2010-04-22 Thread Daniel-Constantin Mierla
Hi Timo, thanks for troubleshooting. I committed the patch that moves setting of bind_addr before any error case in populate_leg_info(). I backported to kamailio_3.0 branch as well. Kelvin, can you get the lasted git version for branch kamailio_3.0 and test? Thanks, Daniel On 4/22/10 1:21 A

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Timo Reimann
Hello, Kelvin Chua wrote: > (gdb) bt > #0 0x2ab61b62779a in update_dialog_dbinfo (cell=0x2ab61c9100f8) at > dlg_db_handler.c:501 This corresponds to SET_STR_VALUE(values+8, cell->bind_addr[DLG_CALLEE_LEG]->sock_str); so assumingly sip-router crashes when it tries to access the callee's

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Kelvin Chua
(gdb) bt #0 0x2ab61b62779a in update_dialog_dbinfo (cell=0x2ab61c9100f8) at dlg_db_handler.c:501 #1 0x2ab61b628ea8 in dlg_onreply (t=0x7d5228, type=, param=) at dlg_handlers.c:361 #2 0x2ab617965505 in run_trans_callbacks_internal (cb_lst=0x2ab61c938830, type=128, trans=0x2ab61c9387c0

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Daniel-Constantin Mierla
On 4/21/10 1:31 PM, Iñaki Baz Castillo wrote: 2010/4/21 Daniel-Constantin Mierla: Hello, are you using the latest git version of branch kamailio_3.0? It was a fix to dialog after the 3.0.0 release, adding some sanity checks for broken messages: http://git.sip-router.org/cgi-bin/gitweb.cgi

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Iñaki Baz Castillo
2010/4/21 Daniel-Constantin Mierla : > Hello, > > are you using the latest git version of branch kamailio_3.0? It was a fix to > dialog after the 3.0.0 release, adding some sanity checks for broken > messages: > http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=787fabb1e0085355aa1

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Daniel-Constantin Mierla
Hello, On 4/21/10 12:23 PM, Kelvin Chua wrote: hi daniel, i'm not using git version. so maybe i'm missing some patches. can you confirm if what i am experiencing is the same problem and the fix is indeed available from the git version? thanks I recommend using at least 3.0.1, as a matter of

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Kelvin Chua
hi daniel, i'm not using git version. so maybe i'm missing some patches. can you confirm if what i am experiencing is the same problem and the fix is indeed available from the git version? thanks here is the backtrace: #0 0x2ab61b62779a in update_dialog_dbinfo (cell=0x2ab61c9100f8) at dlg_d

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Daniel-Constantin Mierla
Hello, are you using the latest git version of branch kamailio_3.0? It was a fix to dialog after the 3.0.0 release, adding some sanity checks for broken messages: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=787fabb1e0085355aa1eeb77d5f17e7940f4ed3c On the other hand, I

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Kelvin Chua
ok, i'll enable debug for now. but if it's indeed a buggy UA, the dialog module should not have crashed but instead dropped the dialog/session and moved on, something i think we need to address to be more resilient. i hope i catch the culprit when this happens again. Kelvin Chua On Wed, Apr 21,

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Iñaki Baz Castillo
2010/4/21 Kelvin Chua : > i wonder if anybody from list is also experiencing this? Perhaps in your case you have a buggy UA setting an invalid Contact header and it causes Kamailio to crash, maybe the reason others have not detected same issue. Could you get some SIP traces until the problem occu

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Kelvin Chua
yeah lots of traffic. so there's no way of telling whether that particular BYE caused the crashed or not. unless i enable debug for the server. besides, you're right it might just be a simple case of receiving a BYE for an expired dialog or something, doesn't seem too fishy at all. i wonder if any

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Iñaki Baz Castillo
2010/4/21 Kelvin Chua : > hi inaki, > unfortunately since i am not expecting any segfaults from kamailio, i have > very little > debug info, only those spurted out by syslog. not been using 1.5 for some > time now. > bad news, happened twice today. in a > span of 3 hours. seems like an inbound BYE.

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Kelvin Chua
hi inaki, unfortunately since i am not expecting any segfaults from kamailio, i have very little debug info, only those spurted out by syslog. not been using 1.5 for some time now. bad news, happened twice today. in a span of 3 hours. seems like an inbound BYE. here is the other instance: Apr 21

Re: [SR-Users] possible bug with dialog module

2010-04-21 Thread Iñaki Baz Castillo
2010/4/21 Kelvin Chua : > currently using kamailio 3.0 with around 1000 users. > Apr 21 10:19:57 kamvm-1 /usr/local/sbin/kamailio[28511]: ERROR: dialog > [dlg_handlers.c:218]: bad sip message or missing Contact hdr > Apr 21 10:19:57 kamvm-1 /usr/local/sbin/kamailio[28511]: ERROR: dialog > [dlg_hand

[SR-Users] possible bug with dialog module

2010-04-21 Thread Kelvin Chua
currently using kamailio 3.0 with around 1000 users. Apr 21 10:19:57 kamvm-1 /usr/local/sbin/kamailio[28511]: ERROR: dialog [dlg_handlers.c:218]: bad sip message or missing Contact hdr Apr 21 10:19:57 kamvm-1 /usr/local/sbin/kamailio[28511]: ERROR: dialog [dlg_handlers.c:350]: could not add furth