[SSSD] [sssd PR#721][opened] AD/IPA: Reset subdomain service name, not domain name

2018-12-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/721 Author: jhrozek Title: #721: AD/IPA: Reset subdomain service name, not domain name Action: opened PR body: """ Related: https://pagure.io/SSSD/sssd/issue/3911 Since commit 778f241e78241b0d6b8734148175f8dee804f494 the subdomain fail over services use

[SSSD] [sssd PR#720][comment] contrib/ci/deps.sh: added missing dependency

2018-12-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/720 Title: #720: contrib/ci/deps.sh: added missing dependency sumit-bose commented: """ > Thanks for explanations! > > Does it mean that if test_pam_responder.py will be fixed properly then > libnss3-dev is not needed as well in Debian dependency list? I

[SSSD] [sssd PR#720][comment] contrib/ci/deps.sh: added missing dependency

2018-12-20 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/720 Title: #720: contrib/ci/deps.sh: added missing dependency alexey-tikhonov commented: """ Thanks for explanations! Does it mean that if test_pam_responder.py will be fixed properly then libnss3-dev is not needed as well in Debian dependency list? """

[SSSD] [sssd PR#720][comment] contrib/ci/deps.sh: added missing dependency

2018-12-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/720 Title: #720: contrib/ci/deps.sh: added missing dependency sumit-bose commented: """ I'm sorry, I think should have given more context. SSSD can be build with either NSS or OpenSSL crypto libraries. The CI build for Debian is using OpenSSL which can be

[SSSD] [sssd PR#715][comment] Use 120 second default timeout for dbus (#1654537)

2018-12-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537) jhrozek commented: """ Two notes: 1) I think the patch is correct, it obviously helps the problem Adam saw. The only reason I ask @pbrezina for review is that he knows the sbus IPC much b

[SSSD] [sssd PR#720][comment] contrib/ci/deps.sh: added missing dependency

2018-12-20 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/720 Title: #720: contrib/ci/deps.sh: added missing dependency alexey-tikhonov commented: """ > Adding it as a dependency is ok, however if it is possible with pytest to run > the related fixtures only for the NSS build this would be even better. I agree w