[SSSD] [sssd PR#734][comment] sss_client: minor fixes

2019-01-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/734 Title: #734: sss_client: minor fixes jhrozek commented: """ Thank you, this was so much easier to review. """ See the full comment at https://github.com/SSSD/sssd/pull/734#issuecomment-455352466 ___

[SSSD] [sssd PR#736][comment] KCM: Allow representing ccaches with a NULL principal

2019-01-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/736 Title: #736: KCM: Allow representing ccaches with a NULL principal jhrozek commented: """ For anyone who wishes to reproduce the bug, this is probably the simplest use-case: - kinit $user - ssh -K -l $user hostname - klist Prior to the patch,

[SSSD] [sssd PR#735][comment] sbus: do not use signature when copying dictionary entry

2019-01-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/735 Title: #735: sbus: do not use signature when copying dictionary entry jhrozek commented: """ I opened upstream issue #3921 just so we track the fix somewhere (also downstream) and pushed the patch as bc1e8ffd5cca74aa8408c1c6bce0a3cf42a0974b """ See

[SSSD] [sssd PR#735][closed] sbus: do not use signature when copying dictionary entry

2019-01-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/735 Author: pbrezina Title: #735: sbus: do not use signature when copying dictionary entry Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/735/head:pr735 git checkout pr735

[SSSD] [sssd PR#735][+Pushed] sbus: do not use signature when copying dictionary entry

2019-01-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/735 Title: #735: sbus: do not use signature when copying dictionary entry Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#730][comment] confdb: sssd tools don't handle the implicit domain

2019-01-17 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/730 Title: #730: confdb: sssd tools don't handle the implicit domain alexey-tikhonov commented: """ Looks good. The only remark I have: may be it would make sense to mark `confdb_ensure_files_domain()` as `static` since it is not supposed to be used

[SSSD] [sssd PR#734][comment] sss_client: minor fixes

2019-01-17 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/734 Title: #734: sss_client: minor fixes alexey-tikhonov commented: """ > each change, however cosmetic, _especially_ in the client code should be in > its separate patch. Re-pushed """ See the full comment at

[SSSD] [sssd PR#734][synchronized] sss_client: minor fixes

2019-01-17 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/734 Author: alexey-tikhonov Title: #734: sss_client: minor fixes Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/734/head:pr734 git checkout pr734 From