[PATCH] drm/i915: Init power domains early in driver load

2016-01-07 Thread Daniel Vetter
eelis Roos <mr...@linux.ee> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Fixes: ac9b8236551d ("drm/i915: Introduce a gmbus power domain") Cc: stable@vger.kernel.org References: http://www.spinics.net/lists/intel-gfx/msg83075.html Tested-by: Meelis Roos <mr...@linux.ee

[PATCH] drm/i915: Init power domains early in driver load

2016-01-07 Thread Daniel Vetter
: ac9b8236551d ("drm/i915: Introduce a gmbus power domain") Cc: stable@vger.kernel.org References: http://www.spinics.net/lists/intel-gfx/msg83075.html Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- drivers/gpu/drm/i915/i915_dma.c | 6 ++ 1 file changed, 2 insertions(+

[PATCH] drm/i915: Init power domains early in driver load

2016-01-07 Thread Daniel Vetter
c: Jani Nikula <jani.nik...@intel.com> Cc: Meelis Roos <mr...@linux.ee> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Fixes: ac9b8236551d ("drm/i915: Introduce a gmbus power domain") Cc: stable@vger.kernel.org References: http://www.spinics.net/lists/intel-gfx/msg83075.html S

Re: [PATCH] drm/i915: Init power domains early in driver load

2016-01-07 Thread Daniel Vetter
On Thu, Jan 7, 2016 at 1:52 PM, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Thu, Jan 07, 2016 at 12:44:21PM +0100, Daniel Vetter wrote: >> Since >> >> commit ac9b8236551d1177fd07b56aef9b565d1864420d >> Author: Ville Syrjälä <ville.syrj...@linux.in

[PATCH] drm/i915: Init power domains early in driver load

2016-01-07 Thread Daniel Vetter
http://www.spinics.net/lists/intel-gfx/msg83075.html Tested-by: Meelis Roos <mr...@linux.ee> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- drivers/gpu/drm/i915/i915_dma.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v3] drm/i915: intel_hpd_init(): Fix suspend/resume reprobing

2016-01-07 Thread Daniel Vetter
intel_connector->encoder->hpd_pin > HPD_NONE) > connector->polled = DRM_CONNECTOR_POLL_HPD; > } > > -- > 2.5.0 > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH v2] drm/i915: intel_hpd_init(): Fix suspend/resume reprobing

2016-01-05 Thread Daniel Vetter
(!connector->polled && I915_HAS_HOTPLUG(dev) && intel_connector->encoder->hpd_pin > HPD_NONE) connector->polled = DRM_CONNECTOR_POLL_HPD; } That yields even tidier code and gives us a place for a comment. Can you pls respi

Re: [Intel-gfx] [PATCH] drm/i915: Workaround CHV pipe C cursor fail

2015-12-21 Thread Daniel Vetter
sktop.org/show_bug.cgi?id=92826 > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Well can't really review with Bspec and I don't expect we can get confirmation from hw engineers. But does what it says in the commit message. Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch&

Re: [Intel-gfx] [PATCH] drm/i915: Workaround CHV pipe C cursor fail

2015-12-21 Thread Daniel Vetter
On Mon, Dec 21, 2015 at 02:49:18PM +0100, Daniel Vetter wrote: > On Fri, Dec 18, 2015 at 07:24:39PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > > Turns out CHV pipe C was glued on somewhat poorly, and

Re: [PATCH] drm/i915: Hide one invalid cancellation bug in i915_switch_context()

2015-12-21 Thread Daniel Vetter
; Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/i915/i915_gem_context.c | 29 + > 1 file changed, 17 insertions(+), 12 deletions(-) &g

Re: [PATCH 03/32] drm/i915: Only spin whilst waiting on the current request

2015-12-18 Thread Daniel Vetter
(timing issue). > Here, we do not need the w/a to force ordering of the read with an > interrupt. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> > Cc: "Rogozhkin, Dmitry V" <dmitry.

Re: [Intel-gfx] [PATCH v5] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

2015-12-17 Thread Daniel Vetter
e. > > > > > > v4: Try to simplify the pinning even further. > > > v5: Leak the VMA (cleaned up by object-free) to avoid complicated error > > > paths. > > > > > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > > Cc:

Re: [PATCH v5] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

2015-12-16 Thread Daniel Vetter
ration of fb can then be > changed thus: > > - struct drm_framebuffer *fb = NULL; > + struct drm_framebuffer *fb; > > Kind regards, Yeah there's room for follow-up polish, but this seems good enough at least for -fixes. Reviewed-by: Daniel Vetter <daniel.vet...@ffwl

Re: [Intel-gfx] [PATCH v2] drm/i915: Do a better job at disabling primary plane in the noatomic case.

2015-12-10 Thread Daniel Vetter
keep > plane_state->visible set, or a WARN_ON in intel_plane_atomic_calc_changes > triggers. There are other code points that rely on accurate > plane_state->visible > too, so make sure the bool is cleared. Oh dear is this a mess :( As a bugfix this is Reviewed-by: Daniel Vette

Re: [Intel-gfx] [PATCH] drm/i915: Unbreak check_digital_port_conflicts()

2015-12-10 Thread Daniel Vetter
encoder. And then check this in the atomic helpers. But that's way too much for -fixes. On the patch itself, for -fixes: Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Ander Conselvan de Oliveira <ander.conselvan.de.olive...@intel.com> > Fixes: 5448a00d3f06 ("drm/i91

Re: [PATCH 1/7] drm: Don't overwrite UNVERFIED mode status to OK

2015-12-04 Thread Daniel Vetter
least a duplicate of it was on that list). This way we will > correctly prune away any mode from the old mode list that didn't > appear on the probed_modes list. > > Cc: stable@vger.kernel.org > Cc: Adam Jackson <a...@redhat.com> > Fixes: 05acaec334fc ("drm: Reorganize p

Re: [PATCH] drm/i915: Fix RPS pointer passed from wait_ioctl to i915_wait_request

2015-12-04 Thread Daniel Vetter
o use of passing a void pointer, I didn't spot one > > callsite in wait-ioctl was passing the wrong pointer. > > > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > > Cc: stable@vger.kernel.org > >

Re: [PATCH] drm/i915: Check the timeout passed to i915_wait_request

2015-11-26 Thread Daniel Vetter
optimisations > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Lionel Landwerlin <lionel.g.landwer...@linux.intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: stable@vger.kernel.org C

Re: [Intel-gfx] [PATCH v4] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

2015-11-24 Thread Daniel Vetter
to allocate fb_info\n"); >232 ret = PTR_ERR(info); >233goto out_unpin; > > --- > 0-DAY kernel test infrastructureOpen Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] drm/i915: Mark uneven memory banks on gen4 desktop as unknown swizzling

2015-11-19 Thread Daniel Vetter
nen <c...@tnsp.org> > References: https://bugs.freedesktop.org/show_bug.cgi?id=90725 > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Matti Hämäläinen <c...@tnsp.org> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Jani Nikula <j

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Mark uneven memory banks on gen4 desktop as unknown swizzling

2015-11-18 Thread Daniel Vetter
lse { > swizzle_x = I915_BIT_6_SWIZZLE_9_10; > swizzle_y = I915_BIT_6_SWIZZLE_9; > -- > 2.6.2 > > _______ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > http://lists.freedesk

Re: [PATCH 1/4] drm: Fix primary plane size for stereo doubled modes for legacy setcrtc

2015-11-17 Thread Daniel Vetter
et gets > rejected on machines where the primary plane must be fullscreen, and on > the rest only the first eye would get a visible plane. > > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: stable@vger.kernel.org > Fixes: 042652ed9599 ("drm/atomic-helper: implementatations fo

Re: [Intel-gfx] [PATCH] drm/i915: Unpin framebuffers when crtc is deconfigured.

2015-11-17 Thread Daniel Vetter
NTEL_INFO(dev)->cursor_needs_physical)) { > intel_unpin_fb_obj(old_state->fb, old_state); > + } > > /* prepare_fb aborted? */ > if ((old_obj && (old_obj->frontbuffer_bits & > intel_plane->frontbuffer_bit)) || > -- >

Re: [PATCH 2/5] drm/core: Fix old_fb handling in drm_mode_atomic_ioctl.

2015-11-17 Thread Daniel Vetter
n.lankho...@linux.intel.com> > Cc: stable@vger.kernel.org #v4.3 Nice catch, but a bit a terse commit message. We should add "Without this fix the plane->fb refcounting might get out of sync on retries, resulting in either leaked memory or use-after-free." With that: Revi

Re: [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-17 Thread Daniel Vetter
s the struct > for another addfb2, the ioctl will be rejected since it's now asking for > some modifiers w/o the flag set. > > Fix the problem by making a copy of the user provided structure. We can > play any games we want with the copy. > > Cc: stable@vger.kernel.org >

Re: [Intel-gfx] [PATCH] drm/i915: Deny wrapping an userptr into a framebuffer

2015-10-23 Thread Daniel Vetter
using. Deny it. > > Can we allow this for unsynchronized userptrs? I'd like to not add more complexity to a root-only feature. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe stable&

Re: [Intel-gfx] [PATCH 10/11] drm/i915/skl: Update watermarks before the crtc is disabled.

2015-10-22 Thread Daniel Vetter
+ intel_update_watermarks(crtc); Does this ever do anything at all? We just killed the crtc completely above, those watermark writes will get cleansed as soon as the power well goes down. -Daniel > } > } > > -- > 2.1.0 > > _

Re: [Intel-gfx] [PATCH 09/11] drm/i915/skl: Prevent unclaimed register writes on skylake.

2015-10-22 Thread Daniel Vetter
well is off. > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92181 > Cc: stable@vger.kernel.org Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Jani, one for you. -Daniel > ---

Re: [Intel-gfx] [PATCH 4.1, 4.2] drm/i915: Silence DDR DVFS errors on CHV

2015-10-19 Thread Daniel Vetter
It shuts up a spurious error in dmesg about a feature which isn't even implemented and took about 20+ patches to get right in Linus tree. Option B is to waste reporters time if we leave that DRM_ERROR in there with filing bugs that we'll close right away. There's no way we can backport DVFS suppor

Re: [Intel-gfx] [PATCH] drm/i915: Flush pipecontrol post-sync writes

2015-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2015 at 03:45:58PM +0300, Jani Nikula wrote: > On Wed, 26 Aug 2015, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > > On Wed, Aug 26, 2015 at 11:16:34AM +0200, Daniel Vetter wrote: > >> On Fri, Aug 21, 2015 at 04:08:41PM +0100, Chris Wilson wrote:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Restore lost DPLL register write on gen2-4

2015-10-13 Thread Daniel Vetter
On Tue, Oct 13, 2015 at 04:10:19PM +0300, Jani Nikula wrote: > On Thu, 08 Oct 2015, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > > On Thu, Oct 08, 2015 at 10:17:30AM +0200, Daniel Vetter wrote: > >> On Wed, Oct 07, 2015 at 10:08:24PM +0300, ville.syrj...@lin

Re: [Intel-gfx] [PATCH] drm/i915: Deny wrapping an userptr into a framebuffer

2015-10-13 Thread Daniel Vetter
es to unmap its address space. The situation can be even more > >complicated when the buffer is passed between processes, between a > >client and display server, where the lifetime and hardware access is > >even more confusing. Deny it. > > Reviewed-by: Tvrtko Ursulin <tv

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Restore lost DPLL register write on gen2-4

2015-10-08 Thread Daniel Vetter
I915_READ(DPLL(!crtc->pipe)) | DPLL_DVO_2X_MODE); Don't we also need a POSTING_READ here to make sure the two-step 2x mode sequence is still followed? With that addressed Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> > } > > + I915_WRITE(reg,

Re: [PATCH] drm/i915: Resurrect golden context on gen6/7

2015-10-07 Thread Daniel Vetter
On Thu, Oct 01, 2015 at 07:13:11PM +0300, Francisco Jerez wrote: > Daniel Vetter <daniel.vet...@ffwll.ch> writes: > > > In > > > > commit 8f0e2b9d95a88ca5d8349deef2375644faf184ae > > Author: Daniel Vetter <daniel.vet...@ffwll.ch> > > Date: Tu

[PATCH] drm/i915: Resurrect golden context on gen6/7

2015-10-01 Thread Daniel Vetter
In commit 8f0e2b9d95a88ca5d8349deef2375644faf184ae Author: Daniel Vetter <daniel.vet...@ffwll.ch> Date: Tue Dec 2 16:19:07 2014 +0100 drm/i915: Move golden context init into ->init_context I've shuffled around per-ctx init code a bit for legacy contexts but accidentally dropped t

[PATCH] drm: Fix locking for sysfs dpms file

2015-09-29 Thread Daniel Vetter
tch to just grab the mode_config.connection_mutex, but we can do a bit better. Reported-by: Jens Axboe <ax...@fb.com> Cc: Jens Axboe <ax...@fb.com> Cc: Rob Clark <robdcl...@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> --- drivers/gpu

[PATCH] drm: Fix locking for sysfs dpms file

2015-09-29 Thread Daniel Vetter
tch to just grab the mode_config.connection_mutex, but we can do a bit better. v2: Remove unused variables I failed to git add for real. Reported-by: Jens Axboe <ax...@fb.com> Cc: Jens Axboe <ax...@fb.com> Cc: Rob Clark <robdcl...@gmail.com> Cc: stable@vger.kernel.org Signed

Re: [PATCH] drm/i915: Limit the number of loops for reading a split 64bit register

2015-09-08 Thread Daniel Vetter
are not stable. > > Just give up after a couple of tries and report whatever we read last. > > > > Reported-by: russianneuroman...@ya.ru > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91906 > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>

Re: [PATCH v2] drm/i915: Limit the number of loops for reading a split 64bit register

2015-09-08 Thread Daniel Vetter
> > v2: Use the most recent values when erring out on an unstable register. > > Reported-by: russianneuroman...@ya.ru > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91906 > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Michał Winiarski <michal.w

Re: [PATCH] drm/i915: Always mark the object as dirty when used by the GPU

2015-09-02 Thread Daniel Vetter
tions under which userspace may wish to tell white lies to the > kernel... > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Kristian Høgsberg <k...@bitplanet.net> > Cc: Jesse Barnes <jbar...@virtuou

Re: [Intel-gfx] [PATCH] drm/i915: Check DP link status on long hpd too

2015-08-26 Thread Daniel Vetter
://bugs.freedesktop.org/show_bug.cgi?id=89453 Tested-by: Palmer Dabbelt pal...@dabbelt.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91407 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89461 Bugzilla: https

Re: [Intel-gfx] [PATCH] drm/i915: Flush pipecontrol post-sync writes

2015-08-26 Thread Daniel Vetter
intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] drm/i915: Set the map-and-fenceable flag for preallocated objects

2015-08-26 Thread Daniel Vetter
On Wed, Aug 26, 2015 at 03:06:59PM +0200, Daniel Vetter wrote: On Wed, Aug 26, 2015 at 12:55:57PM +0100, Chris Wilson wrote: As we mark the preallocated objects as bound, we should also flag them correctly as being map-and-fenceable (if appropriate!) so that latter users do not get confused

Re: [PATCH] drm/i915: Set the map-and-fenceable flag for preallocated objects

2015-08-26 Thread Daniel Vetter
-and-fenceable binding. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Goel, Akash akash.g...@intel.com Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: Jesse Barnes jbar...@virtuousgeek.org Cc: stable@vger.kernel.org Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Jani, can you please pick

Re: [Intel-gfx] [PATCH] drm/dp/mst: Remove port after removing connector.

2015-08-15 Thread Daniel Vetter
the driver's connector cleanup function asynchronously. And that is very unhappy that the port is now gone. So perfectly ok regression fix imo to restore the ordering we had before your patch in the cleanup code. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] drm/i915: Flag the execlists context object as dirty after every use

2015-08-14 Thread Daniel Vetter
this already. Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch -Daniel --- drivers/gpu/drm/i915/intel_lrc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 138964afd187..41cfa6fa909d 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/dp/mst: Remove port after removing connector.

2015-08-11 Thread Daniel Vetter
introduced with 6b8eeca65b18ae77e175cc2b6571731f0ee413bf drm/dp/mst: close deadlock in connector destruction. Cc: stable@vger.kernel.org Cc: Dave Airlie airl...@redhat.com Signed-off-by: Maarten Lankhorst maarten.lankho...@linux.intel.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Jani

[PATCH 3/4] drm/dp-mst: Remove debug WARN_ON

2015-08-03 Thread Daniel Vetter
-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/drm_dp_mst_topology.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 778bbb6425b8..b0487c9f018c 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b

Re: [PATCH] drm/i915: Declare the swizzling unknown for L-shaped configurations

2015-07-30 Thread Daniel Vetter
for an individual page is unknown (it depends on its physical address only known to the kernel), userspace cannot correctly swizzle. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91105 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc

Re: [Intel-gfx] [PATCH v3] drm/i915: Use two 32bit reads for select 64bit REG_READ ioctls

2015-07-21 Thread Daniel Vetter
___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line unsubscribe stable

Re: [Intel-gfx] [PATCH v3] drm/i915: Use two 32bit reads for select 64bit REG_READ ioctls

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 10:45:45AM +0100, Chris Wilson wrote: On Tue, Jul 21, 2015 at 08:49:31AM +0200, Daniel Vetter wrote: On Fri, Jul 17, 2015 at 05:10:25PM +0200, Michał Winiarski wrote: On Thu, Jul 16, 2015 at 12:37:56PM +0100, Chris Wilson wrote: Since the hardware sometimes

[PATCH 1/2] drm: Stop resetting connector state to unknown

2015-07-16 Thread Daniel Vetter
/gmane.comp.freedesktop.xorg.drivers.intel/62584 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=100641 Cc: Rui Matos tiagoma...@gmail.com Cc: Julien Wajsberg fel...@gmail.com Cc: kuddel.m...@gmx.de Cc: Lennart Poettering mzxre...@0pointer.de Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter

[PATCH] Revert drm/i915: Declare the swizzling unknown for L-shaped configurations

2015-07-14 Thread Daniel Vetter
this we need to extend the ioctl with new paramters that only new userspace looks at. Cc: Harald Arnesen har...@skogtun.org Cc: Chris Wilson ch...@chris-wilson.co.uk Reported-by: Harald Arnesen har...@skogtun.org Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter daniel.vet...@intel.com

Re: [Intel-gfx] [PATCH 2/2] drm: Provide compat ioctl for addfb2.1

2015-07-14 Thread Daniel Vetter
the ioctl need explicit compat handling. v2: Removed the typedef. (Daniel Vetter) Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Cc: dri-de...@lists.freedesktop.org Cc: Rob Clark robdcl...@gmail.com Cc: Daniel Stone dani

Re: [PATCH v2] drm/i915: Declare the swizzling unknown for L-shaped configurations

2015-07-09 Thread Daniel Vetter
known to the kernel), userspace cannot correctly swizzle objects. v2: Mark the global swizzling as unknown rather than adjust the value reported to userspace. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91105 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter

[PATCH RESEND] drm/kms-helper: disable hpd_irq handling when poll=0

2015-07-07 Thread Daniel Vetter
When inlining the actual hpd output probing in commit 69787f7da6b2adc4054357a661aaa1701a9ca76f Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Tue Oct 23 18:23:34 2012 + drm: run the hpd irq event code directly the check for the drm_kms_hlper.poll module option was lost

Re: [PATCH] drm/rockchip: use drm_gem_mmap helpers

2015-07-07 Thread Daniel Vetter
djku...@chromium.org Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Cc: stable@vger.kernel.org Applied to topic/drm-fixes to make sure it won't get lost, but I expect rockchip maintainers to pick this one up. -Daniel --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 67

Re: [PATCH] drm/i915: Declare the swizzling unknown for L-shaped configurations

2015-06-29 Thread Daniel Vetter
known to the kernel), userspace cannot correctly swizzle. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91105 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: stable@vger.kernel.org Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch

Re: [PATCH] agp/intel: Fix typo in needs_ilk_vtd_wa()

2015-06-29 Thread Daniel Vetter
://bugs.freedesktop.org/show_bug.cgi?id=91127 References: https://bugzilla.freedesktop.org/show_bug.cgi?id=60391 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: stable@vger.kernel.org Oops, can't count how often we've committed this mistake. Reviewed-by: Daniel

[PATCH] drm/vgem: Set unique to vgem

2015-06-23 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/vgem/vgem_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 7a207ca547be..6394547cf67a 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers

Re: [Intel-gfx] [PATCH] drm/i915: Officially give up on seqno coherency

2015-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2015 at 01:05:41PM +0300, Jani Nikula wrote: On Fri, 19 Jun 2015, Daniel Vetter daniel.vet...@ffwll.ch wrote: We've never figured out the magic trick to make irq vs. seqno updates coherent, only tricks to make it work. And since commit

Re: [PATCH] drm/i915: Avoid GPU hang when coming out of s3 or s4

2015-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2015 at 9:12 AM, Jani Nikula jani.nik...@intel.com wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89600 Cc: stable@vger.kernel.org # 4.0+ Signed-off-by: Peter Antoine peter.anto...@intel.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch [Jani: fixed typo

[PATCH] drm/i915: Officially give up on seqno coherency

2015-06-19 Thread Daniel Vetter
Janes mark.a.ja...@intel.com Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index e6bb72dca3ff

[PATCH] drm/i915: Officially give up on seqno coherency

2015-06-19 Thread Daniel Vetter
NOTICE since it might be of value for bug reports (Chris). Cc: Mark Janes mark.a.ja...@intel.com Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix DDC probe for passive adapters

2015-05-28 Thread Daniel Vetter
); + if (bla) + goto retry; + goto out; timeout: --- Totally untested ofc ;-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord

Re: [Intel-gfx] [PATCH v2] drm/i915: Force wmb() on using GTT io_mapping_map_wc

2015-05-26 Thread Daniel Vetter
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-26 Thread Daniel Vetter
On Thu, May 21, 2015 at 5:30 PM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, May 21, 2015 at 04:22:55PM +0100, Chris Wilson wrote: On Thu, May 21, 2015 at 04:21:46PM +0200, Daniel Vetter wrote: Hm right. What about emphasising this a bit more in the comment: /* * Empirical

Re: [Intel-gfx] [PATCH v2] drm/i915: Force wmb() on using GTT io_mapping_map_wc

2015-05-26 Thread Daniel Vetter
On Tue, May 26, 2015 at 09:49:15AM +0100, Chris Wilson wrote: On Tue, May 26, 2015 at 10:01:24AM +0200, Daniel Vetter wrote: On Mon, May 25, 2015 at 06:48:44PM +0100, Chris Wilson wrote: Since the advent of mmap(wc), where we reused the same cache domain for WC and GTT paths (oh, how I

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 02:00:34PM +0100, Chris Wilson wrote: On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote: On Mon, May 11, 2015 at 04:25:52PM +0100, Chris Wilson wrote: On Mon, May 11, 2015 at 12:34:37PM +0200, Daniel Vetter wrote: On Mon, May 11, 2015 at 08:51:36AM

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 04:22:55PM +0100, Chris Wilson wrote: On Thu, May 21, 2015 at 04:21:46PM +0200, Daniel Vetter wrote: Hm right. What about emphasising this a bit more in the comment: /* * Empirical evidence indicates that we need a write barrier to * make sure

Re: [Intel-gfx] [PATCH] drm/i915: Unconditionally flush writes before execbuffer

2015-05-21 Thread Daniel Vetter
On Thu, May 21, 2015 at 02:13:01PM +0100, Chris Wilson wrote: On Thu, May 21, 2015 at 03:07:54PM +0200, Daniel Vetter wrote: On Thu, May 21, 2015 at 02:00:34PM +0100, Chris Wilson wrote: On Tue, May 19, 2015 at 03:41:48PM +0100, Chris Wilson wrote: On Mon, May 11, 2015 at 04:25:52PM

[PATCH] drm/plane-helper: Adapt cursor hack to transitional helpers

2015-05-20 Thread Daniel Vetter
In commit f02ad907cd9e7fe3a6405d2d005840912f1ed258 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Thu Jan 22 16:36:23 2015 +0100 drm/atomic-helpers: Recover full cursor plane behaviour we've added a hack to atomic helpers to never to vblank waits for cursor updates through the legacy

[PATCH 1/2] drm/i915: Fix locking in DRRS flush/invalidate hooks

2015-04-09 Thread Daniel Vetter
...@chris-wilson.co.uk Cc: Ville Syrjälä ville.syrj...@linux.intel.com Cc: Ramalingam C ramalinga...@intel.com Cc: Rodrigo Vivi rodrigo.v...@intel.com Cc: Vandana Kannan vandana.kan...@intel.com Cc: stable@vger.kernel.org (4.0+ only) Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu

Re: [Intel-gfx] [PATCH] drm/edid: set ELD for firmware and debugfs override EDIDs

2015-03-26 Thread Daniel Vetter
, so Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Cheers, Daniel --- drivers/gpu/drm/drm_edid_load.c| 1 + drivers/gpu/drm/drm_probe_helper.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c index 732cb6f8e653

Re: [PATCH] drm/i915: Make WAIT_IOCTL negative timeouts be indefinite again

2015-03-06 Thread Daniel Vetter
On Fri, Mar 06, 2015 at 08:54:35AM +, Chris Wilson wrote: On Thu, Mar 05, 2015 at 01:27:43PM +0100, Daniel Vetter wrote: On Wed, Mar 04, 2015 at 06:09:26PM +, Chris Wilson wrote: This fixes a regression from commit 5ed0bdf21a85d78e04f89f15ccf227562177cbd9 Author: Thomas

Re: [PATCH] drm/i915: Make WAIT_IOCTL negative timeouts be indefinite again

2015-03-05 Thread Daniel Vetter
timeout return immediately rather than the previously defined behaviour of waiting indefinitely. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter daniel.vet...@ffwll.ch Cc: Ben Widawsky benjamin.widaw...@intel.com Cc: Kristian Høgsberg k...@bitplanet.net Cc: stable

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

2015-02-27 Thread Daniel Vetter
to switch will be buggy as well ;-) /me is chicken Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] drm: Don't assign fbs for universal cursor support to files

2015-02-27 Thread Daniel Vetter
, but doesn't add it anywhere. Signed-off-by: Daniel Vetter daniel.vet...@intel.com (fix commit msg) Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk (provider of lipstick) Cc: Ville Syrjälä ville.syrj...@linux.intel.com Cc: Matt Roper matthew.d.ro...@intel.com Cc: Rob Clark robdcl

[PATCH] drm: Fixup racy refcounting in plane_force_disable

2015-02-27 Thread Daniel Vetter
Originally it was impossible to be dropping the last refcount in this function since there was always one around still from the idr. But in commit 83f45fc360c8e16a330474860ebda872d1384c8c Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Wed Aug 6 09:10:18 2014 +0200 drm: Don't grab an fb

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-26 Thread Daniel Vetter
, -- 2.1.0 ___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2015-02-23 Thread Daniel Vetter
On Mon, Feb 23, 2015 at 01:29:57PM -0800, Jesse Barnes wrote: On 11/24/2014 06:13 AM, Chris Wilson wrote: On Mon, Nov 24, 2014 at 03:10:05PM +0100, Daniel Vetter wrote: On Mon, Nov 24, 2014 at 10:35:29AM +, Chris Wilson wrote: Pinning is a useful tool and it would also be useful to have

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj-pages under mempressure

2015-02-11 Thread Daniel Vetter
)); or similar. Otherwise when we extended them in upstream (which we're just doing, the kernel 0-fills the new fields automatically) it'll break because after a recompile there's now garbage in the new fields. I just spent a while fixing up libdrm ;-) -Daniel -- Daniel Vetter Software Engineer, Intel

[PATCH] drm/i915: Align initial plane backing objects correctly

2015-02-10 Thread Daniel Vetter
Wilson ch...@chris-wilson.co.uk Cc: Jani Nikula jani.nik...@linux.intel.com Reported-by: Johannes W jar...@molb.org Signed-off-by: Daniel Vetter daniel.vet...@intel.com -- Johannes, can you please test this patch instead of the one from Chris? Thanks, Daniel --- drivers/gpu/drm/i915

[PATCH] drm/i915: Align initial plane backing objects correctly

2015-02-10 Thread Daniel Vetter
Cc: Johannes W jar...@molb.org Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: Jani Nikula jani.nik...@linux.intel.com Reported-by: Johannes W jar...@molb.org Signed-off-by: Daniel Vetter daniel.vet...@intel.com -- Johannes, can you please test this patch instead of the one from Chris? Thanks

[PATCH] drm/i915: Do not invalidate obj-pages under mempressure

2015-02-09 Thread Daniel Vetter
@vger.kernel.org Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: Jani Nikula jani.nik...@intel.com Signed-off-by: Daniel Vetter daniel.vet...@intel.com (v2) --- drivers/gpu/drm/i915/i915_gem.c | 49 ++--- 1 file changed, 2 insertions(+), 47 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Insert a command barrier on BLT/BSD cache flushes

2015-01-22 Thread Daniel Vetter
-- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Intel-gfx] [PATCH] drm/i915: Quietly reject attempts to create non-pagealigned stolen objects

2015-01-21 Thread Daniel Vetter
On Wed, Jan 21, 2015 at 07:45:01PM +0200, Jani Nikula wrote: On Wed, 10 Dec 2014, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Dec 10, 2014 at 08:17:11AM +, Chris Wilson wrote: This added as a BUG_ON as it considered that no one would ever request an unaligned object. However, it turns

Re: [PATCH v2] drm/i915: Initialize primary plane src/dst coords when reading hw state

2015-01-20 Thread Daniel Vetter
, or is that too late for when we change pipe state when sanititizing crtcs? -Daniel DRM_DEBUG_KMS([CRTC:%d] hw state readout: %s\n, crtc-base.base.id, -- 1.9.1 -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http

Re: [PATCH v2] drm/i915: Initialize primary plane src/dst coords when reading hw state

2015-01-20 Thread Daniel Vetter
On Tue, Jan 20, 2015 at 11:46:57AM +0200, Ville Syrjälä wrote: On Tue, Jan 20, 2015 at 11:33:22AM +0200, Ander Conselvan de Oliveira wrote: On 01/20/2015 11:22 AM, Daniel Vetter wrote: On Mon, Jan 19, 2015 at 03:51:47PM +0200, Ander Conselvan de Oliveira wrote: @@ -13346,6 +13364,7

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj-pages under mempressure

2015-01-16 Thread Daniel Vetter
On Thu, Jan 15, 2015 at 08:44:00PM +, Chris Wilson wrote: On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote: On Wed, Jan 14, 2015 at 9:34 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: This (partially) reverts commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj-pages under mempressure

2015-01-15 Thread Daniel Vetter
pressure Shouldn't we also revert the hunk in i915_gem_free_objects? Without the truncate vs. invalidate disdinction it seems to have lost it's reason for existence ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj-pages under mempressure

2015-01-14 Thread Daniel Vetter
); + if (i915_gem_object_is_purgeable(obj)) + i915_gem_object_truncate(obj); return 0; } -- 2.1.4 ___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel

Re: [Intel-gfx] [PATCH] drm/i915: Initialize primary plane src/dst coords when reading hw state

2015-01-13 Thread Daniel Vetter
On Tue, Jan 13, 2015 at 01:24:12PM +0200, Ville Syrjälä wrote: On Tue, Jan 13, 2015 at 12:34:06AM +0100, Daniel Vetter wrote: On Mon, Jan 12, 2015 at 05:36:52PM +0200, Ander Conselvan de Oliveira wrote: Otherwise setting the rotation property will cause the primary plane to be disabled

Re: [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Daniel Vetter
On Mon, Jan 12, 2015 at 6:43 PM, Luis Henriques luis.henriq...@canonical.com wrote: On Mon, Jan 12, 2015 at 06:20:22PM +0100, Daniel Vetter wrote: On Sun, Jan 11, 2015 at 10:49 PM, Ben Hutchings b...@decadent.org.uk wrote: On Mon, 2014-12-15 at 14:24 +, Luis Henriques wrote: 3.16.7-ckt3

Re: [Intel-gfx] [PATCH] drm/i915: Initialize primary plane src/dst coords when reading hw state

2015-01-12 Thread Daniel Vetter
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch I guess long term we need to consolidate all our plane state related readout functions, atm it's splattered all over. But that's maybe something for after all the atomic

Re: [PATCH 3.16.y-ckt 030/168] drm/i915: Handle failure to kick out a conflicting fb driver

2015-01-12 Thread Daniel Vetter
f96de58fc7e7d3d717c7c63975c3b896c906b5e3 upstream. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reviewed-by: Jani Nikula jani.nik...@intel.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Luis Henriques luis.henriq...@canonical.com Should this also be applied

Re: [Intel-gfx] [PATCH] drm/i915/hsw: Implement Selective Write workaround

2015-01-05 Thread Daniel Vetter
the stable is what I'm thinking. Makes sense if we really don't need it any more with Chris' patches in -fixes. Can you please volunteer someone to cough up an r-b? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from

Re: [Intel-gfx] [PATCH] drm/i915: Fix mutex-owner inspection race under DEBUG_MUTEXES

2015-01-05 Thread Daniel Vetter
Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index ad55b06a3cb1..4c14db9587a6 100644 --- a/drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Disable PMSI sleep messages on all rings around context switches

2014-12-16 Thread Daniel Vetter
On Mon, Dec 15, 2014 at 07:03:43PM +0200, Ville Syrjälä wrote: On Mon, Dec 15, 2014 at 04:24:48PM +, Chris Wilson wrote: On Mon, Dec 15, 2014 at 10:41:52AM +0100, Daniel Vetter wrote: On Thu, Dec 11, 2014 at 08:17:01AM +, Chris Wilson wrote: There exists a current workaround

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Invalidate media caches on gen7

2014-12-16 Thread Daniel Vetter
On Tue, Dec 16, 2014 at 08:26:55AM +, Chris Wilson wrote: On Mon, Dec 15, 2014 at 10:34:45AM +0100, Daniel Vetter wrote: On Thu, Dec 11, 2014 at 08:16:59AM +, Chris Wilson wrote: In the gen7 pipe control there is an extra bit to flush the media caches, so let's set it during cache

  1   2   3   4   5   >