Managing photos within Subsurface

2015-02-06 Thread Willem Ferguson
Currently the facilities for managing the photos accessible to Subsurface are fairly crude. One can do a batch import using the "Load Images" context menu item on the dive list. This shows all the photos associated with each of the dives. But, once this is done, there is relatively little way o

CCR dive logs for APD

2015-02-06 Thread Willem Ferguson
Hallo Miika, I started a discussion earlier about catering for APD equipment. The APD dive logs are classical CSV files that can import into the existing CCR code straight-out without any modification. The headings are: Dive_time (s) Depth (m) Setpoint (bar) o2 sensor 1 (bar) o2 sensor 2 (bar

Re: CCR mode and our implementation of the setpoint

2015-02-06 Thread Willem Ferguson
On 06/02/2015 23:54, Dirk Hohndel wrote: Robert, Willem, you have spent more time with the code than I have. What am I missing? /D ___ As far as the dive logging of CCR dives is concerned, all the information is kept in the sample structures (for the moment, forget about the plot_info struc

Re: First patch - Delete dive(s) using the delete key

2015-02-06 Thread Dirk Hohndel
On Fri, Feb 06, 2015 at 03:41:18PM -0800, Steve wrote: > >> > >> This patch allows the user to delete dives using the delete key. > > > > Excellent. > >| Really? This seems like a recipe for mistakes and easy data loss. >| >| If I read the patch right, there's no confirmation etc, so now just >|

Re: First patch - Delete dive(s) using the delete key

2015-02-06 Thread Steve
Original message From: Linus Torvalds Date:02/06/2015 08:20 (GMT-08:00) To: Dirk Hohndel Cc: Subsurface Mailing List Subject: Re: First patch - Delete dive(s) using the delete key On Fri, Feb 6, 2015 at 7:20 AM, Dirk Hohndel wrote: > Hi Grace, > > welcome to the team!

[PATCH] Update spanish translation of user manual to english 7b44cf2

2015-02-06 Thread Salvador Cuñat
- Multi-cylinder dives. - SCR dives. - Changes on mean depth line explanation Signed-off-by: Salvador Cuñat --- Documentation/user-manual_es.txt | 99 1 file changed, 91 insertions(+), 8 deletions(-) diff --git a/Documentation/user-manual_es.txt b/Docum

Re: CCR mode and our implementation of the setpoint

2015-02-06 Thread Linus Torvalds
On Fri, Feb 6, 2015 at 3:30 PM, Henrik Brautaset Aronsen wrote: > > Is that a good idea? On several setups you can bail out to your diluent > cylinder(s). So it wouldn't be a cylinder change, but it would be a mode > change. Hmm Fair enough, that certainly argues for a separate event. I guess yo

Re: CCR mode and our implementation of the setpoint

2015-02-06 Thread Davide DB
On Sat, Feb 7, 2015 at 12:06 AM, Linus Torvalds wrote: > Quite frankly, wouldn't it be nicer to just make CCR be about which > *cylinder* you are breathing, making the "dive mode" change be just a > cylinder change event. > > .. and basically add a "CCR vs OC" to the cylinder information. And > w

Re: CCR mode and our implementation of the setpoint

2015-02-06 Thread Henrik Brautaset Aronsen
7. feb. 2015 00.07 skrev "Linus Torvalds" : > > Quite frankly, wouldn't it be nicer to just make CCR be about which > *cylinder* you are breathing, making the "dive mode" change be just a > cylinder change event. Is that a good idea? On several setups you can bail out to your diluent cylinder(s).

Re: CCR mode and our implementation of the setpoint

2015-02-06 Thread Linus Torvalds
On Fri, Feb 6, 2015 at 2:55 PM, Dirk Hohndel wrote: > On my phone. > We should just add our own event and not abuse the existing event. > Actually, have to events > Divemodechange and Setpointchange > That way setpoint of 0 is no longer ambiguous Quite frankly, wouldn't it be nicer to just make C

Re: CCR mode and our implementation of the setpoint

2015-02-06 Thread Dirk Hohndel
On my phone. We should just add our own event and not abuse the existing event. Actually, have to events Divemodechange and Setpointchange That way setpoint of 0 is no longer ambiguous /D On February 6, 2015 2:14:00 PM "Robert C. Helling" wrote: On 06 Feb 2015, at 22:54, Dirk Hohndel wrote

CCR mode and our implementation of the setpoint

2015-02-06 Thread Dirk Hohndel
OK, I'll admit it up front. I don't really care about rebreathers - they aren't interesting to me. So I clearly haven't paid enough attention to our CCR support. But a bug report from an OC diver forced me to dig into this and what I think I'm beginning to understand doesn't make me happy. It see

ssrf-version.h and rebuilding

2015-02-06 Thread Lubomir I. Ivanov
hello, in terms of our current scheme for updating ssrf-version.h, with each git HEAD change one potential small issue is present where the macros from the file itself are used on compile time by a number of files. this forces recompilation of said files into object code even if they effectively s

Re: RFC: Suunto Vyper Air configuration

2015-02-06 Thread Anton Lundin
On 06 February, 2015 - Jef Driesen wrote: > On 2015-02-06 14:49, Guillaume Gardet wrote: > >Currently, we are able to configure Suunto Vyper family with sample > >rates of 10, 20, 30 or 60 per seconds. > >The problem is that the Suunto Vyper Air is also able to set the > >sample rate to 1 per seco

[PATCH] Update user-manual images

2015-02-06 Thread Willem Ferguson
Subject: [PATCH 3/3] Update screenshots for user-manual We want to get rid of the dreaded red line. This gets rid of some of the last Ubuntu screenshots. Signed-off-by: willem ferguson --- Documentation/images/DiveProfile1_f20.jpg | Bin 41818 -> 30915 bytes Documentation/images/DiveProfile2_f

Re: First patch - Delete dive(s) using the delete key

2015-02-06 Thread Linus Torvalds
On Fri, Feb 6, 2015 at 7:20 AM, Dirk Hohndel wrote: > Hi Grace, > > welcome to the team! > > On Fri, Feb 06, 2015 at 02:19:04PM +0300, Grace Karanja wrote: >> >> This patch allows the user to delete dives using the delete key. > > Excellent. Really? This seems like a recipe for mistakes and easy

Re: RFC: Suunto Vyper Air configuration

2015-02-06 Thread Jef Driesen
On 2015-02-06 14:49, Guillaume Gardet wrote: Currently, we are able to configure Suunto Vyper family with sample rates of 10, 20, 30 or 60 per seconds. The problem is that the Suunto Vyper Air is also able to set the sample rate to 1 per second. The Vyper and Vyper Air belong to two different f

Re: First patch - Delete dive(s) using the delete key

2015-02-06 Thread Dirk Hohndel
Hi Grace, welcome to the team! On Fri, Feb 06, 2015 at 02:19:04PM +0300, Grace Karanja wrote: > > This patch allows the user to delete dives using the delete key. Excellent. I have a few comments... > diff --git a/qt-ui/divelistview.cpp b/qt-ui/divelistview.cpp > index d4e7442..a889af8 100644

Re: [PATCH] user-manual bugs #827 and #828

2015-02-06 Thread Dirk Hohndel
On Fri, Feb 06, 2015 at 10:03:23AM +0100, Salvador Cuñat wrote: > El 05/02/2015 20:37, "Dirk Hohndel" escribió: > > > > It would be great if the translations (especially Spanish and Russian - > > the French translation is far from complete, anyway) could be updated to > > this version with the the

Re: RFC: Suunto Vyper Air configuration

2015-02-06 Thread Guillaume Gardet
Le 06/02/2015 14:49, Guillaume Gardet a écrit : Hi, Currently, we are able to configure Suunto Vyper family with sample rates of 10, 20, 30 or 60 per seconds. The problem is that the Suunto Vyper Air is also able to set the sample rate to 1 per second. A quick search told me that Cobra2, Cob

RFC: Suunto Vyper Air configuration

2015-02-06 Thread Guillaume Gardet
Hi, Currently, we are able to configure Suunto Vyper family with sample rates of 10, 20, 30 or 60 per seconds. The problem is that the Suunto Vyper Air is also able to set the sample rate to 1 per second. I am wondering what would be the best way to add it. Is there a way (in the UI) to know

First patch - Delete dive(s) using the delete key

2015-02-06 Thread Grace Karanja
Dear all, This patch allows the user to delete dives using the delete key. - Grace K From f0fa09d24263101c9c156e647eb1cc124e96acf7 Mon Sep 17 00:00:00 2001 From: Grace Karanja Date: Fri, 6 Feb 2015 14:15:22 +0300 Subject: [PATCH] Delete dives using delete key Allow users to delete dives using

Re: [PATCH] user-manual bugs #827 and #828

2015-02-06 Thread Salvador Cuñat
El 05/02/2015 20:37, "Dirk Hohndel" escribió: > > It would be great if the translations (especially Spanish and Russian - > the French translation is far from complete, anyway) could be updated to > this version with the the updated pictures. > In 4.4.0 spanish only lacks of Facebook integration

[PATCH] HTML: add Depth and Duration data to the dive list view.

2015-02-06 Thread Gehad Elrobey
This patch adds the more important fields (depth, duration) to the list view. this was recommended by Willem and also Fixes #725. Regards, Gehad From e1260f0a4d5e9b82c7f998acf3be56e80bf2a238 Mon Sep 17 00:00:00 2001 From: Gehad elrobey Date: Fri, 6 Feb 2015 10:32:45 +0200 Subject: [PATCH] HTML: a