On 10/23/2014 6:21 PM, Mateusz Guzik wrote:
> On Thu, Oct 23, 2014 at 04:19:05PM -0700, Xin Li wrote:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA512
>>
>> On 10/23/14 15:47, Dag-Erling Smørgrav wrote:
>>> Xin LI writes:
Log: Test if 'env' is NULL before doing memset() and strlen(),
>>
On Thu, Oct 23, 2014 at 04:19:05PM -0700, Xin Li wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On 10/23/14 15:47, Dag-Erling Smørgrav wrote:
> > Xin LI writes:
> >> Log: Test if 'env' is NULL before doing memset() and strlen(),
> >> the caller may pass NULL to freeenv().
> >
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 10/23/14 15:47, Dag-Erling Smørgrav wrote:
> Xin LI writes:
>> Log: Test if 'env' is NULL before doing memset() and strlen(),
>> the caller may pass NULL to freeenv().
>
> If this is in response to a panic in early boot, the real bug is
> else
Xin LI writes:
> Log:
> Test if 'env' is NULL before doing memset() and strlen(),
> the caller may pass NULL to freeenv().
If this is in response to a panic in early boot, the real bug is
elsewhere (see r273564). Adding a NULL check here only hides it.
DES
--
Dag-Erling Smørgrav - d...@des
Author: delphij
Date: Thu Oct 23 18:23:50 2014
New Revision: 273552
URL: https://svnweb.freebsd.org/changeset/base/273552
Log:
Test if 'env' is NULL before doing memset() and strlen(),
the caller may pass NULL to freeenv().
Modified:
head/sys/kern/kern_environment.c
Modified: head/sys/kern