Re: svn commit: r261916 - head/sys/dev/xen/console

2014-02-16 Thread David Chisnall
On 16 Feb 2014, at 04:09, Bruce Evans b...@optusnet.com.au wrote: [a long list of corner cases where the warning may not be correct] Fortunately, the goal of compiler warnings is not to address every possible case, but rather to minimise false positives while still giving useful results. The

svn commit: r261916 - head/sys/dev/xen/console

2014-02-15 Thread Dimitry Andric
Author: dim Date: Sat Feb 15 12:37:26 2014 New Revision: 261916 URL: http://svnweb.freebsd.org/changeset/base/261916 Log: In sys/dev/xen/console/console.c, #if 0 an unused static function. MFC after:3 days Modified: head/sys/dev/xen/console/console.c Modified:

Re: svn commit: r261916 - head/sys/dev/xen/console

2014-02-15 Thread Bruce Evans
On Sat, 15 Feb 2014, Dimitry Andric wrote: Log: In sys/dev/xen/console/console.c, #if 0 an unused static function. MFC after: 3 days Modified: head/sys/dev/xen/console/console.c Modified: head/sys/dev/xen/console/console.c

Re: svn commit: r261916 - head/sys/dev/xen/console

2014-02-15 Thread David Chisnall
On 15 Feb 2014, at 17:02, Bruce Evans b...@optusnet.com.au wrote: Why? There are hundreds if not thousands of static inline functions in headers, and most of these functions are not always used, so there would be [hundreds if not thousands] * [number of #includes] compiler warnings if

Re: svn commit: r261916 - head/sys/dev/xen/console

2014-02-15 Thread Bruce Evans
On Sat, 15 Feb 2014, David Chisnall wrote: On 15 Feb 2014, at 17:02, Bruce Evans b...@optusnet.com.au wrote: Why? There are hundreds if not thousands of static inline functions in headers, and most of these functions are not always used, so there would be [hundreds if not thousands] *