The fix looks fine. Note that in the test the count of characters for
JFormattedTextFieldTest is set to 5, but 6 is used.
On 19.05.16 18:25, Rajeev Chamyal wrote:
Hello All,
Please review the following webrev.
Bug : https://bugs.openjdk.java.net/browse/JDK-7070795
Webrev : http://cr.openjd
Hello All,
Please review the following webrev.
Bug : https://bugs.openjdk.java.net/browse/JDK-7070795
Webrev : http://cr.openjdk.java.net/~rchamyal/7070795/webrev.00/
Issue: On changing the Windows theme to high contrast the high contrast color
scheme is not getting applied to JFormatt
Hi Sergey,
Thank you for the review. I will update the fix based on your suggestion.
Thanks,
Dmitry
On 19/05/2016 14:24, Sergey Bylokhov wrote:
Hi, Dmitry.
Looks fine, but can you please maintain 80 chars per line in the files
where this rule was applied already(UnsupportedAudioFileException.j
Hi, Dmitry.
Looks fine, but can you please maintain 80 chars per line in the files
where this rule was applied already(UnsupportedAudioFileException.java
for example). It is not necessary to send a new webrev.
On 19.05.16 13:35, dmitry markov wrote:
Hello,
Could you review a simple fix for j
Hello Dmitry
Looks just great!
Thanks
alexp
On 5/19/2016 13:35, dmitry markov wrote:
Hello,
Could you review a simple fix for jdk9, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8157322
webrev: http://cr.openjdk.java.net/~dmarkov/8157322/webrev.00/
Fixed several typos in cl
Hello,
Could you review a simple fix for jdk9, please?
bug: https://bugs.openjdk.java.net/browse/JDK-8157322
webrev: http://cr.openjdk.java.net/~dmarkov/8157322/webrev.00/
Fixed several typos in client libraries javadoc.
Thanks,
Dmitry
Looks fine.
On 19.05.16 8:31, Ajit Ghaisas wrote:
Thanks for the review.
I have corrected the test case to dispose the window if the test fails.
Here is the updated webrev.
http://cr.openjdk.java.net/~aghaisas/7172750/webrev.02/
Regards,
Ajit
-Original Message-
From: Sergey Bylokhov
S