Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Hi All, A gentle reminder, please review my code changes. With Regards, Avik Niyogi > On 08-Jul-2016, at 4:24 pm, Yuri Nesterenko > wrote: > > It pass for me if I provide some time to process native events > after the user activity simulation. For instance, >

Re: [9] Review request for 8159587: IOOBE in javax/swing/JFileChooser/7199708/bug7199708.java

The fix looks good to me. Thanks, Alexandr. On 7/11/2016 12:28 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8159587 webrev: http://cr.openjdk.java.net/~ssadetsky/8159587/webrev.00/ Exception is caused by row index value =0

Re: Review Request JDK-8159168 [hidpi] Window.setShape() works incorrectly on HiDPI

The fix looks good to me. Thanks, Alexandr. On 7/11/2016 12:13 PM, Semyon Sadetsky wrote: Looks good to me. --Semyon On 7/11/2016 12:08 PM, Rajeev Chamyal wrote: Hello Semyon, Please review the updated webrev as per review comments.

[9] Review request for 8159587: IOOBE in javax/swing/JFileChooser/7199708/bug7199708.java

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8159587 webrev: http://cr.openjdk.java.net/~ssadetsky/8159587/webrev.00/ Exception is caused by row index value =0 which is not in a valid range because table model contains no rows at the moment. The issue is

Re: Review Request JDK-8159168 [hidpi] Window.setShape() works incorrectly on HiDPI

Looks good to me. --Semyon On 7/11/2016 12:08 PM, Rajeev Chamyal wrote: Hello Semyon, Please review the updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8159168/webrev.04/ Regards, Rajeev Chamyal

Re: Review Request JDK-8159168 [hidpi] Window.setShape() works incorrectly on HiDPI

Hello Semyon, Please review the updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8159168/webrev.04/ Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 11 July 2016 14:29 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net; Sergey

Re: Review Request JDK-8159168 [hidpi] Window.setShape() works incorrectly on HiDPI

Hello Semyon, Thanks for the review. Yes, mouse move is not required I have removed it. Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8159168/webrev.03/ Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 11 July 2016 12:30 To: Rajeev Chamyal; Alexander

Re: Review Request JDK-8159168 [hidpi] Window.setShape() works incorrectly on HiDPI

Hi Rajeev, The fix itself looks good. I only did not get for what purpose mouse pointer is moved in the test? --Semyon On 7/5/2016 9:16 AM, Rajeev Chamyal wrote: Hello Alexandr, Please review updated webrev. http://cr.openjdk.java.net/~rchamyal/8159168/webrev.02/