Re: 8163169: [PIT][TEST_BUG] fix to JDK-8161470 doesn't work

2016-08-16 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/17/2016 9:48 AM, Avik Niyogi wrote: Hi All, Kindly review the fix for JDK9. *Bug: https://bugs.openjdk.java.net/browse/JDK-8163169* *Webrev: **http://cr.openjdk.java.net/~aniyogi/8163169/webrev.00/*

8163169: [PIT][TEST_BUG] fix to JDK-8161470 doesn't work

2016-08-16 Thread Avik Niyogi
Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8163169 Webrev: http://cr.openjdk.java.net/~aniyogi/8163169/webrev.00/ Issue: The test javax/swing/

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Rajeev Chamyal
Hello Sergey, Thanks for the review. In the bug its reported that border of button is grey. Instead of button border icon border should be checked. I have updated test instructions for this. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 16 August 2016 18:28 To

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Sergey Bylokhov
On 16.08.16 15:57, Sergey Bylokhov wrote: The changes looks fine, there are a notice, is it a known issues? there are a notice about different background of the buttons. On 16.08.16 15:01, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Webrev: http://cr.openjdk.j

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Sergey Bylokhov
The changes looks fine, there are a notice, is it a known issues? On 16.08.16 15:01, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8163160 Issue : manual

Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-16 Thread Rajeev Chamyal
Hello All, Please review the following webrev. Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8163160 Issue : manual tag was missing in test. Regards, Rajeev Chamyal

Swing Dev>[9] Review Request JDK-8161913 [PIT] java/awt/Window/8159168/SetShapeTest.java mostly fails

2016-08-16 Thread Rajeev Chamyal
Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8161913 Webrev : http://cr.openjdk.java.net/~rchamyal/8161913/webrev.00/ Issue : Test was failing when run repeatedly. Fix: Added delay in test. Regards, Rajeev Chamyal