Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

@openjdk.java.net Subject: Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10 The code change looks fine, a few notes about the test: - The empty catch block "catch (Exception e) {}, it will be better to re-throw an exception. - &

Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

feel only. For other LAF and platforms it works fine. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 05 May 2016 18:54 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-8152981 Double icons with JMenuItem

Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 05 May 2016 18:54 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10 The code chang

Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

tallDefaults to a private method. Calling same method on propertychange. Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 04 May 2016 19:47 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-8152981 Dou

Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

Bylokhov Sent: 04 May 2016 19:47 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10 Hi, Rajeev. Is it necessary to reinstall UI for the component from the UI itself

Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

Hi, Rajeev. Is it necessary to reinstall UI for the component from the UI itself, probably it will be possible to reconfigure the current one? On 03.05.16 15:08, Rajeev Chamyal wrote: Hello All, Please review the below webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8152981 Webrev

Re: [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

The fix looks good to me. Thanks, Alexandr, On 5/3/2016 3:08 PM, Rajeev Chamyal wrote: Hello All, Please review the below webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8152981 Webrev : http://cr.openjdk.java.net/~rchamyal/8152981/webrev.00/

[9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

Hello All, Please review the below webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8152981 Webrev : http://cr.openjdk.java.net/~rchamyal/8152981/webrev.00/ Issue : Setting horizontal text position on a menuItem with icon results in Icon appearing twice on menuItem. Cause: W